From: Mel Gorman <mel@csn.ul.ie>
To: Christoph Lameter <cl@linux.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
tony.luck@intel.com
Subject: Re: [PATCH 02/10] hugetlb: add allocate function for hugepage migration
Date: Thu, 23 Sep 2010 09:49:19 +0100 [thread overview]
Message-ID: <20100923084919.GA5185@csn.ul.ie> (raw)
In-Reply-To: <alpine.DEB.2.00.1009221558000.32661@router.home>
On Wed, Sep 22, 2010 at 04:05:47PM -0500, Christoph Lameter wrote:
> On Wed, 8 Sep 2010, Naoya Horiguchi wrote:
>
> > We can't use existing hugepage allocation functions to allocate hugepage
> > for page migration, because page migration can happen asynchronously with
> > the running processes and page migration users should call the allocation
> > function with physical addresses (not virtual addresses) as arguments.
>
> Ummm... Some arches like IA64 need huge pages fixed at certain virtual
> addresses in which only huge pages exist. A vma is needed in order to be
> able to assign proper virtual address to the page.
>
Are you sure about this case? The virtual address of the page being migrated
should not changed, only the physical address.
> How does that work with transparent huge pages anyways?
>
IA-64 doesn't support transparent huge pages. Even if it did, this
change is about hugetlbfs, not transparent huge page support.
> This looks like its going to break IA64 hugepage support for good.
How?
> Maybe
> thats okay given the reduced significance of IA64? Certainly would
> simplify the code.
>
Currently I'm not seeing how IA-64 gets broken.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
next prev parent reply other threads:[~2010-09-23 8:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 1:19 [PATCH 0/10] Hugepage migration (v5) Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 01/10] hugetlb: fix metadata corruption in hugetlb_fault() Naoya Horiguchi
2010-09-20 10:47 ` Mel Gorman
2010-09-22 20:41 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 02/10] hugetlb: add allocate function for hugepage migration Naoya Horiguchi
2010-09-20 10:59 ` Mel Gorman
2010-09-22 4:41 ` Naoya Horiguchi
2010-09-22 8:37 ` Mel Gorman
2010-09-22 21:05 ` Christoph Lameter
2010-09-23 8:49 ` Mel Gorman [this message]
2010-09-23 16:02 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 03/10] hugetlb: redefine hugepage copy functions Naoya Horiguchi
2010-09-20 11:03 ` Mel Gorman
2010-09-20 11:15 ` Andi Kleen
2010-09-20 11:18 ` Mel Gorman
2010-09-23 16:21 ` Christoph Lameter
2010-09-24 3:24 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 04/10] hugetlb: hugepage migration core Naoya Horiguchi
2010-09-20 11:10 ` Mel Gorman
2010-09-22 4:59 ` Naoya Horiguchi
2010-09-22 8:40 ` Mel Gorman
2010-09-23 16:52 ` Christoph Lameter
2010-09-24 5:58 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 05/10] HWPOISON, hugetlb: add free check to dequeue_hwpoison_huge_page() Naoya Horiguchi
2010-09-23 16:54 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 06/10] hugetlb: move refcounting in hugepage allocation inside hugetlb_lock Naoya Horiguchi
2010-09-23 17:12 ` Christoph Lameter
2010-09-24 6:47 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 07/10] HWPOSION, hugetlb: recover from free hugepage error when !MF_COUNT_INCREASED Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 08/10] HWPOISON, hugetlb: soft offlining for hugepage Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 09/10] HWPOISON, hugetlb: fix unpoison " Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 10/10] page-types.c: fix name of unpoison interface Naoya Horiguchi
2010-09-09 10:33 ` [PATCH 0/10] Hugepage migration (v5) Andi Kleen
2010-09-09 22:56 ` Naoya Horiguchi
2010-09-20 11:14 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2010-09-03 4:37 [PATCH 0/10] Hugepage migration (v4) Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 02/10] hugetlb: add allocate function for hugepage migration Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923084919.GA5185@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux.com \
--cc=fengguang.wu@intel.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).