From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759916Ab0I0RYc (ORCPT ); Mon, 27 Sep 2010 13:24:32 -0400 Received: from qmta05.emeryville.ca.mail.comcast.net ([76.96.30.48]:51541 "EHLO qmta05.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759479Ab0I0RYb (ORCPT ); Mon, 27 Sep 2010 13:24:31 -0400 Date: Mon, 27 Sep 2010 10:23:13 -0700 From: matt mooney To: Valdis.Kletnieks@vt.edu Cc: kernel-janitors@vger.kernel.org, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/24] hwmon: change to new flag variable Message-ID: <20100927172313.GC4598@haskell.muteddisk.com> Mail-Followup-To: Valdis.Kletnieks@vt.edu, kernel-janitors@vger.kernel.org, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org References: <9968d4260be8850200cc9c7dfe08addf611468b4.1285355033.git.mfm@muteddisk.com> <036514b5dd23c5af14303519d79d60d79adccbee.1285355033.git.mfm@muteddisk.com> <12873.1285599840@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12873.1285599840@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11:04 Mon 27 Sep , Valdis.Kletnieks@vt.edu wrote: > On Fri, 24 Sep 2010 12:17:14 PDT, matt mooney said: > > Replace EXTRA_CFLAGS with ccflags-y. > > > > Signed-off-by: matt mooney > > --- > > drivers/hwmon/Makefile | 4 +--- > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > > index e3c2484..764b4db 100644 > > --- a/drivers/hwmon/Makefile > > +++ b/drivers/hwmon/Makefile > > @@ -109,7 +109,5 @@ obj-$(CONFIG_SENSORS_W83L786NG) += w83l786ng.o > > obj-$(CONFIG_SENSORS_WM831X) += wm831x-hwmon.o > > obj-$(CONFIG_SENSORS_WM8350) += wm8350-hwmon.o > > > > -ifeq ($(CONFIG_HWMON_DEBUG_CHIP),y) > > -EXTRA_CFLAGS += -DDEBUG > > -endif > > +ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG > > Was this series intended as := rather than += as it seems that > overriding the entirely of a passed-in ccflags-y may not be what > we wanted to do. That is exactly why I changed += to :=. ccflags-y (and the older EXTRA_CFLAGS) is a per directory variable that only has effect on the current directory, so there is no passing in of ccflags-y. -mfm