Hi Len, On Fri, 17 Sep 2010 14:26:30 +1000 Stephen Rothwell wrote: > > On Mon, 30 Aug 2010 14:08:02 +0800 Zhang Rui wrote: > > > > On Mon, 2010-08-30 at 09:42 +0800, Stephen Rothwell wrote: > > > Hi Len, > > > > > > On Tue, 17 Aug 2010 11:24:39 +1000 Stephen Rothwell wrote: > > > > > > > > Today's linux-next build (x86_64 allmodconfig) produced these warnings: > > > > > > > > drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type > > > > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)' > > [several more elided] > > > > > Introduced by commit 1c8fce27e275fd7c6b75bc6455745f02d3903ee6 ("ACPI: > > > > introduce drivers/acpi/sysfs.c") interacting with commit > > > > 9bbb9e5a33109b2832e2e63dcc7a132924ab374b ("param: use ops in struct > > > > kernel_param, rather than get and set fns directly"). > > > > > > Can we have this fixed, please? > > patch attached. :) > > > > Use module_param_cb instead of the obsoleted module_param_call to fix a build warning. > > > > Signed-off-by: Zhang Rui > > Now that this has been in linux-next since Sep 6, can you please send it > to Linus. It removes quite a few warnings that were introduced during > this merge window - and I think we already have too many warnings. Ping? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/