linux-next: build failure after merge of the drivers-x86 tree

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

make[4]: *** No rule to make target `drivers/platform/x86/ideapad_laptop.c', needed by `drivers/platform/x86/ideapad_laptop.o'.  Stop.

Caused by commit 9efe5c1540a1e03cb2e0fca85e49fc4c57c6e771 ("ideapad:
Change the driver name to ideapad-laptop").  The commit renames
ideapad_acpi.c to ideapad-laptop.c but the Makefile uses ideapad_laptop.o
(note underscore v. dash).

Presumably this was never even build tested :-(

I have used the drivers-x86 tree from next-20101004 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the drivers-x86 tree

[Ike Panhc]

On 10/05/2010 12:11 PM, Stephen Rothwell wrote:
> Hi Matthew,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> make[4]: *** No rule to make target `drivers/platform/x86/ideapad_laptop.c', needed by `drivers/platform/x86/ideapad_laptop.o'.  Stop.
> 
> Caused by commit 9efe5c1540a1e03cb2e0fca85e49fc4c57c6e771 ("ideapad:
> Change the driver name to ideapad-laptop").  The commit renames
> ideapad_acpi.c to ideapad-laptop.c but the Makefile uses ideapad_laptop.o
> (note underscore v. dash).
> 
> Presumably this was never even build tested :-(
> 
> I have used the drivers-x86 tree from next-20101004 for today.

Sorry, my fault.

This line is wrong,

+obj-$(CONFIG_IDEAPAD_LAPTOP)	+= ideapad_laptop.o

shall be

+obj-$(CONFIG_IDEAPAD_LAPTOP)	+= ideapad-laptop.o

How shall I fix it? resend the whole patches or just this one?

Re: linux-next: build failure after merge of the drivers-x86 tree

[Ike Panhc]

Hi,

Sorry for the inconvenient.

I update the patches and push to
  git://kernel.ubuntu.com/ikepanhc/ideapad-laptop.git for-upstream

Just test build and install on ideapad I have. It works fine.


On 10/05/2010 12:11 PM, Stephen Rothwell wrote:
> Hi Matthew,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> make[4]: *** No rule to make target `drivers/platform/x86/ideapad_laptop.c', needed by `drivers/platform/x86/ideapad_laptop.o'.  Stop.
> 
> Caused by commit 9efe5c1540a1e03cb2e0fca85e49fc4c57c6e771 ("ideapad:
> Change the driver name to ideapad-laptop").  The commit renames
> ideapad_acpi.c to ideapad-laptop.c but the Makefile uses ideapad_laptop.o
> (note underscore v. dash).
> 
> Presumably this was never even build tested :-(
> 
> I have used the drivers-x86 tree from next-20101004 for today.

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/toshiba_acpi.c: In function 'wwan_rfkill_set_block':
drivers/platform/x86/toshiba_acpi.c:454: error: 'HCI_WIRELESS_WWAN_ENABLE' undeclared (first use in this function)
drivers/platform/x86/toshiba_acpi.c:454: error: (Each undeclared identifier is reported only once
drivers/platform/x86/toshiba_acpi.c:454: error: for each function it appears in.)

Caused by commit 64ea4efdd949c99d9206a44a43984d2e861350f1 ("wwan rfkill stubs").

I have used the version of the drivers-x86 tree from next-20101206 for today.

I also got the following new messages from the build:

drivers/platform/x86/Kconfig:422:error: recursive dependency detected!
drivers/platform/x86/Kconfig:422:	symbol EEEPC_WMI depends on ACPI_WMI
drivers/platform/x86/Kconfig:438:	symbol ACPI_WMI is selected by ACER_WMI
drivers/platform/x86/Kconfig:18:	symbol ACER_WMI depends on LEDS_CLASS
drivers/leds/Kconfig:10:	symbol LEDS_CLASS is selected by EEEPC_WMI

warning: (ADB_PMU_LED && MACINTOSH_DRIVERS && ADB_PMU || ATH5K && NETDEVICES && WLAN && ATH_COMMON && (PCI || ATHEROS_AR231X) && MAC80211 || ATH9K && NETDEVICES && WLAN && ATH_COMMON && PCI && MAC80211 || ATH9K_HTC && NETDEVICES && WLAN && ATH_COMMON && USB && MAC80211 || CARL9170_LEDS && NETDEVICES && WLAN && ATH_COMMON && CARL9170 || INPUT_WISTRON_BTNS && !S390 && INPUT && INPUT_MISC && X86 && !X86_64 || SENSORS_APPLESMC && HWMON && INPUT && X86 || SENSORS_LIS3LV02D && HWMON && ACPI && INPUT || IR_WINBOND_CIR && MEDIA_SUPPORT && X86 && PNP && RC_CORE || BACKLIGHT_ADP8860 && HAS_IOMEM && BACKLIGHT_LCD_SUPPORT && BACKLIGHT_CLASS_DEVICE && I2C || MSM_STAGING && STAGING && !STAGING_EXCLUDE_BUILD && FB && ARCH_MSM && !FB_MSM || ASUS_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && !ACPI_ASUS && INPUT && (RFKILL || RFKILL=n) || THINKPAD_ACPI && X86 && X86_PLATFORM_DEVICES && ACPI && INPUT && (RFKILL || RFKILL=n) || EEEPC_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && INPUT && EXPERIMENTAL && (RFKILL || RFKILL=n) && HOTPLUG_PCI || EEEPC_WMI && X86 && X86_PLATFORM_DEVICES && ACPI_WMI && INPUT && EXPERIMENTAL && BACKLIGHT_CLASS_DEVICE && (RFKILL || RFKILL=n)) selects LEDS_CLASS which has unmet direct dependencies (NEW_LEDS)

drivers/platform/x86/toshiba_acpi.c:460: warning: label 'out' defined but not used
drivers/platform/x86/toshiba_acpi.c:448: warning: unused variable 'radio_state'
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64_allmodconfig)
failed like this:

drivers/platform/x86/eeepc-wmi.c:118: error: 'KEY_CAMERA_ZOOMIN' undeclared here (not in a function)
drivers/platform/x86/eeepc-wmi.c:124: error: 'KEY_CAMERA_ZOOMOUT' undeclared here (not in a function)
drivers/platform/x86/eeepc-wmi.c:125: error: 'KEY_CAMERA_UP' undeclared here (not in a function)
drivers/platform/x86/eeepc-wmi.c:126: error: 'KEY_CAMERA_DOWN' undeclared here (not in a function)
drivers/platform/x86/eeepc-wmi.c:127: error: 'KEY_CAMERA_LEFT' undeclared here (not in a function)
drivers/platform/x86/eeepc-wmi.c:128: error: 'KEY_CAMERA_RIGHT' undeclared here (not in a function)

Caused by commit 8e077c067a95956859341cd0caddabd99371c7b7 ("eeepc-wmi:
add camera keys").  Presumably a missing update to a header file ...

I have used the drivers-x86 tree from next-20110207 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the drivers-x86 tree

[Matthew Garrett]

On Tue, Feb 08, 2011 at 02:45:22PM +1100, Stephen Rothwell wrote:
> Hi Matthew,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64_allmodconfig)
> failed like this:
> 
> drivers/platform/x86/eeepc-wmi.c:118: error: 'KEY_CAMERA_ZOOMIN' undeclared here (not in a function)
> drivers/platform/x86/eeepc-wmi.c:124: error: 'KEY_CAMERA_ZOOMOUT' undeclared here (not in a function)
> drivers/platform/x86/eeepc-wmi.c:125: error: 'KEY_CAMERA_UP' undeclared here (not in a function)
> drivers/platform/x86/eeepc-wmi.c:126: error: 'KEY_CAMERA_DOWN' undeclared here (not in a function)
> drivers/platform/x86/eeepc-wmi.c:127: error: 'KEY_CAMERA_LEFT' undeclared here (not in a function)
> drivers/platform/x86/eeepc-wmi.c:128: error: 'KEY_CAMERA_RIGHT' undeclared here (not in a function)
> 
> Caused by commit 8e077c067a95956859341cd0caddabd99371c7b7 ("eeepc-wmi:
> add camera keys").  Presumably a missing update to a header file ...

Sorry, it was in my tree but uncommitted after I fixed up a merge 
conflict. Repushed.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/xo15-ebook.c: In function 'ebook_switch_add':
drivers/platform/x86/xo15-ebook.c:136: error: 'struct acpi_device_wakeup' has no member named 'run_wake_count'

Caused by commit f160ad4c2a720411a136db7b867c3b4b868b8933 ("OLPC XO-1.5
ebook switch driver") interacting with commit
0cab2dcf9963b1a7ed32e730384e1e8925b099cd ("ACPI: Remove the
wakeup.run_wake_count device field") from the acpi tree.

I have applied this merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 14 Feb 2011 16:36:41 +1100
Subject: [PATCH] OLPC: fix for removal of run_wak_count

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/platform/x86/xo15-ebook.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/xo15-ebook.c b/drivers/platform/x86/xo15-ebook.c
index 2343bb3..c1372ed 100644
--- a/drivers/platform/x86/xo15-ebook.c
+++ b/drivers/platform/x86/xo15-ebook.c
@@ -133,7 +133,6 @@ static int ebook_switch_add(struct acpi_device *device)
 		/* Button's GPE is run-wake GPE */
 		acpi_enable_gpe(device->wakeup.gpe_device,
 				device->wakeup.gpe_number);
-		device->wakeup.run_wake_count++;
 		device_set_wakeup_enable(&device->dev, true);
 	}
 
-- 
1.7.2.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the drivers-x86 tree

[Rafael J. Wysocki]

On Monday, February 14, 2011, Stephen Rothwell wrote:
> Hi Matthew,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/platform/x86/xo15-ebook.c: In function 'ebook_switch_add':
> drivers/platform/x86/xo15-ebook.c:136: error: 'struct acpi_device_wakeup' has no member named 'run_wake_count'
> 
> Caused by commit f160ad4c2a720411a136db7b867c3b4b868b8933 ("OLPC XO-1.5
> ebook switch driver") interacting with commit
> 0cab2dcf9963b1a7ed32e730384e1e8925b099cd ("ACPI: Remove the
> wakeup.run_wake_count device field") from the acpi tree.
> 
> I have applied this merge fix patch:

The fix is correct, thanks Stephen!

Rafael


> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 14 Feb 2011 16:36:41 +1100
> Subject: [PATCH] OLPC: fix for removal of run_wak_count
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/platform/x86/xo15-ebook.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/xo15-ebook.c b/drivers/platform/x86/xo15-ebook.c
> index 2343bb3..c1372ed 100644
> --- a/drivers/platform/x86/xo15-ebook.c
> +++ b/drivers/platform/x86/xo15-ebook.c
> @@ -133,7 +133,6 @@ static int ebook_switch_add(struct acpi_device *device)
>  		/* Button's GPE is run-wake GPE */
>  		acpi_enable_gpe(device->wakeup.gpe_device,
>  				device->wakeup.gpe_number);
> -		device->wakeup.run_wake_count++;
>  		device_set_wakeup_enable(&device->dev, true);
>  	}

Re: linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

Hi Matthew,

On Mon, 14 Feb 2011 16:39:44 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/platform/x86/xo15-ebook.c: In function 'ebook_switch_add':
> drivers/platform/x86/xo15-ebook.c:136: error: 'struct acpi_device_wakeup' has no member named 'run_wake_count'
> 
> Caused by commit f160ad4c2a720411a136db7b867c3b4b868b8933 ("OLPC XO-1.5
> ebook switch driver") interacting with commit
> 0cab2dcf9963b1a7ed32e730384e1e8925b099cd ("ACPI: Remove the
> wakeup.run_wake_count device field") from the acpi tree.

This acpi commit has now been merged into Linus' tree (as commit
5190726765b4) so the patch below can now be applied to the drivers-x86
tree (after merging Linus' tree).  Or should be sent to Linus along with
your merge request.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 14 Feb 2011 16:36:41 +1100
Subject: [PATCH] OLPC: fix for removal of run_wake_count

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/platform/x86/xo15-ebook.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/xo15-ebook.c b/drivers/platform/x86/xo15-ebook.c
index 2343bb3..c1372ed 100644
--- a/drivers/platform/x86/xo15-ebook.c
+++ b/drivers/platform/x86/xo15-ebook.c
@@ -133,7 +133,6 @@ static int ebook_switch_add(struct acpi_device *device)
 		/* Button's GPE is run-wake GPE */
 		acpi_enable_gpe(device->wakeup.gpe_device,
 				device->wakeup.gpe_number);
-		device->wakeup.run_wake_count++;
 		device_set_wakeup_enable(&device->dev, true);
 	}
 
-- 
1.7.2.3


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/sony-laptop.c: In function 'sony_nc_handles_setup':
drivers/platform/x86/sony-laptop.c:772: error: invalid type argument of '->' (have 'struct device_attribute')
drivers/platform/x86/sony-laptop.c: In function 'sony_nc_kbd_backlight_setup':
drivers/platform/x86/sony-laptop.c:1462: error: invalid type argument of '->' (have 'struct device_attribute')
drivers/platform/x86/sony-laptop.c:1468: error: invalid type argument of '->' (have 'struct device_attribute')

Caused by commit 73dd0f8d0f1f5ac19b56f343cfcf5876b31e699f ("sony-laptop:
cache handles and report them via sysfs").

Please build this stuff *before* putting it into linux-next.

I have used the drivers-x86 tree from next-20110221 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the drivers-x86 tree

[Mattia Dongili]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

>Hi Matthew,
>
>After merging the drivers-x86 tree, today's linux-next build (x86_64
>allmodconfig) failed like this:

Apologies, I didn't test my code with
DEBUG_LOCK_ALLOC=y.
I'll send a fix in as soon as I get around a usable network
connection.

-- 
mattia
:wq

Re: linux-next: build failure after merge of the drivers-x86 tree

[Mattia Dongili]

On Tue, Feb 22, 2011 at 03:26:53PM +0900, Mattia Dongili wrote:
> 
> 
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> >Hi Matthew,
> >
> >After merging the drivers-x86 tree, today's linux-next build (x86_64
> >allmodconfig) failed like this:
> 
> Apologies, I didn't test my code with
> DEBUG_LOCK_ALLOC=y.
> I'll send a fix in as soon as I get around a usable network
> connection.

the below patch fixes the build failure.

how does linux-next work? should this patch be a separate commit or can
it be folded into the offending one?

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index a097a27..a0ba0e7 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -769,7 +769,7 @@ static int sony_nc_handles_setup(struct platform_device *pd)
 
 	handles = kzalloc(sizeof(*handles), GFP_KERNEL);
 
-	sysfs_attr_init(handles->devattr);
+	sysfs_attr_init(&handles->devattr.attr);
 	handles->devattr.attr.name = "handles";
 	handles->devattr.attr.mode = S_IRUGO;
 	handles->devattr.show = sony_nc_handles_show;
@@ -1459,13 +1459,13 @@ static int sony_nc_kbd_backlight_setup(struct platform_device *pd)
 
 	kbdbl_handle = kzalloc(sizeof(*kbdbl_handle), GFP_KERNEL);
 
-	sysfs_attr_init(kbdbl_handle->mode_attr);
+	sysfs_attr_init(&kbdbl_handle->mode_attr.attr);
 	kbdbl_handle->mode_attr.attr.name = "kbd_backlight";
 	kbdbl_handle->mode_attr.attr.mode = S_IRUGO | S_IWUSR;
 	kbdbl_handle->mode_attr.show = sony_nc_kbd_backlight_mode_show;
 	kbdbl_handle->mode_attr.store = sony_nc_kbd_backlight_mode_store;
 
-	sysfs_attr_init(kbdbl_handle->timeout_attr);
+	sysfs_attr_init(&kbdbl_handle->timeout_attr.attr);
 	kbdbl_handle->timeout_attr.attr.name = "kbd_backlight_timeout";
 	kbdbl_handle->timeout_attr.attr.mode = S_IRUGO | S_IWUSR;
 	kbdbl_handle->timeout_attr.show = sony_nc_kbd_backlight_timeout_show;
-- 
mattia
:wq!

Re: linux-next: build failure after merge of the drivers-x86 tree

[Matthew Garrett]

On Tue, Feb 22, 2011 at 08:46:01PM +0900, Mattia Dongili wrote:

> how does linux-next work? should this patch be a separate commit or can
> it be folded into the offending one?

I'll fold it into the offending one and repush. Sorry about the 
breakage, Stephen - I don't have DEBUG_ALLOC enabled so didn't see the 
failure. Do you build with a defined configuration I can test against?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Tue, 22 Feb 2011 14:34:34 +0000 Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>
> On Tue, Feb 22, 2011 at 08:46:01PM +0900, Mattia Dongili wrote:
> 
> > how does linux-next work? should this patch be a separate commit or can
> > it be folded into the offending one?
> 
> I'll fold it into the offending one and repush. Sorry about the 
> breakage, Stephen - I don't have DEBUG_ALLOC enabled so didn't see the 
> failure. Do you build with a defined configuration I can test against?

As the original report said, this was an x86_64 allmodconfig build.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/toshiba_acpi.c:141:1: error: unknown type name 'sturct'
drivers/platform/x86/toshiba_acpi.c:141:32: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
drivers/platform/x86/toshiba_acpi.c: In function 'toshiba_acpi_i8042_filter':
drivers/platform/x86/toshiba_acpi.c:877:18: error: 'toshiba_acpi' undeclared (first use in this function)
drivers/platform/x86/toshiba_acpi.c:877:18: note: each undeclared identifier is reported only once for each function it appears in
drivers/platform/x86/toshiba_acpi.c: In function 'toshiba_acpi_remove':
drivers/platform/x86/toshiba_acpi.c:1050:6: error: 'toshiba_acpi' undeclared (first use in this function)
drivers/platform/x86/toshiba_acpi.c: In function 'toshiba_acpi_add':
drivers/platform/x86/toshiba_acpi.c:1083:6: error: 'toshiba_acpi' undeclared (first use in this function)

Caused by commit 5ea3879c8e16 ("toshiba_acpi: Support alternate hotkey interfaces").

Please build test this stuff :-(

I have used the drivers-x86 tree from next-20120320 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the drivers-x86 tree

[Matthew Garrett]

Damnit. Sorry, I fixed up the for-linus branch but failed to carry that 
over to next. Not Seth's fault, I screwed up when hand-merging his 
patch.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/toshiba_acpi.c: In function 'toshiba_acpi_i8042_filter':
drivers/platform/x86/toshiba_acpi.c:877:30: error: dereferencing pointer to incomplete type

Caused by commit b2a7ad1dd939 ("toshiba_acpi: Support alternate hotkey
interfaces").

Please at least build test this! :-(

I have used the drivers-x86 from next-20120320 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/asus-wmi.c: In function 'asus_new_rfkill':
drivers/platform/x86/asus-wmi.c:892:3: error: implicit declaration of function 'rfkill_set_led_trigger_name' [-Werror=implicit-function-declaration]

Caused by commit 154a7a7b2234 ("asus-wmi: update wlan LED through rfkill
led trigger").  Please build test this stuff ... according to the bug
report, this patch depends on another rfkill patch.

I have used the drivers-x86 tree from next-20120817 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the drivers-x86 tree

[AceLan Kao]

Hi,

The commit 154a7a7b2234 ("asus-wmi: update wlan LED through rfkill led trigger")
needs another patch which was submitted to rfkill, but still not be merged yet.
see https://patchwork.kernel.org/patch/1240091/

Sorry for leading to the problem.

Best regards,
AceLan Kao.

2012/8/20 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Matthew,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/platform/x86/asus-wmi.c: In function 'asus_new_rfkill':
> drivers/platform/x86/asus-wmi.c:892:3: error: implicit declaration of function 'rfkill_set_led_trigger_name' [-Werror=implicit-function-declaration]
>
> Caused by commit 154a7a7b2234 ("asus-wmi: update wlan LED through rfkill
> led trigger").  Please build test this stuff ... according to the bug
> report, this patch depends on another rfkill patch.
>
> I have used the drivers-x86 tree from next-20120817 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au



-- 
Chia-Lin Kao(AceLan)
http://blog.acelan.idv.tw/
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "acpi_bus_get_status_handle" [drivers/platform/x86/pvpanic.ko] undefined!

Caused by commit b8f8cf6b02b6 ("pvpanic: handle missing _STA correctly").

I have used the drivers-x86 tree from next-20150603 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build failure after merge of the drivers-x86 tree

[Radim Krčmář]

2015-06-04 18:13+1000, Stephen Rothwell:
> After merging the drivers-x86 tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "acpi_bus_get_status_handle" [drivers/platform/x86/pvpanic.ko] undefined!
> 
> Caused by commit b8f8cf6b02b6 ("pvpanic: handle missing _STA correctly").

Classic, I only built with Y, sorry.

acpi_bus_get_status_handle is not exported, so a simple solution would
be to make it so.  Or it's possible to rewrite the patch in a way that
uses current infrastructure.

Would you prefer a patch to export it, a build fix on top of
b8f8cf6b02b6 or a replacement patch?

Thanks.

A fix on top of b8f8cf6b02b6:
---8<---
pvpanic: use acpi_bus_get_status to fix build

The previous version used acpi_bus_get_status_handle, which was not
being exported, so module build blew up;  switch to acpi_bus_get_status
and use the status it populates.

Populated status is a bitfield so we can make the code self-documenting.
We do not check 'present' because 'enabled' has to be false in that case
by specification.  Older QEMUs set 0xff to status and newer ones do 0xb.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 drivers/platform/x86/pvpanic.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/pvpanic.c b/drivers/platform/x86/pvpanic.c
index 7b6860333267..fd86daba7ffd 100644
--- a/drivers/platform/x86/pvpanic.c
+++ b/drivers/platform/x86/pvpanic.c
@@ -92,12 +92,13 @@ pvpanic_walk_resources(struct acpi_resource *res, void *context)
 
 static int pvpanic_add(struct acpi_device *device)
 {
-	acpi_status status;
-	u64 ret;
+	int ret;
 
-	status = acpi_bus_get_status_handle(device->handle, &ret);
+	ret = acpi_bus_get_status(device);
+	if (ret < 0)
+		return ret;
 
-	if (ACPI_FAILURE(status) || (ret & 0x0B) != 0x0B)
+	if (!device->status.enabled || !device->status.functional)
 		return -ENODEV;
 
 	acpi_walk_resources(device->handle, METHOD_NAME__CRS,

Re: linux-next: build failure after merge of the drivers-x86 tree

[Darren Hart]

On Thu, Jun 04, 2015 at 07:51:36PM +0200, Radim Krčmář wrote:
> 2015-06-04 18:13+1000, Stephen Rothwell:
> > After merging the drivers-x86 tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> > 
> > ERROR: "acpi_bus_get_status_handle" [drivers/platform/x86/pvpanic.ko] undefined!
> > 
> > Caused by commit b8f8cf6b02b6 ("pvpanic: handle missing _STA correctly").
> 
> Classic, I only built with Y, sorry.

While I, as a rule, build with both. My apologies for letting this slip through
into -next.

> 
> acpi_bus_get_status_handle is not exported, so a simple solution would
> be to make it so.  Or it's possible to rewrite the patch in a way that
> uses current infrastructure.
> 
> Would you prefer a patch to export it, a build fix on top of
> b8f8cf6b02b6 or a replacement patch?

I'll take the incremental below, but I will roll it into the existing one so
as not to break bisectability in Linus tree.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center

linux-next: build failure after merge of the drivers-x86 tree

[Michael Ellerman]

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "acpi_bus_get_status_handle" [drivers/platform/x86/pvpanic.ko] undefined!

Caused by commit b8f8cf6b02b6 ("pvpanic: handle missing _STA correctly").

I have applied the fixup patch from Radim for today
(http://marc.info/?l=linux-next&m=143344030214935&w=2).

cheers

Re: linux-next: build failure after merge of the drivers-x86 tree

[Darren Hart]

On Fri, Jun 05, 2015 at 08:13:01PM +1000, Michael Ellerman wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "acpi_bus_get_status_handle" [drivers/platform/x86/pvpanic.ko] undefined!
> 
> Caused by commit b8f8cf6b02b6 ("pvpanic: handle missing _STA correctly").
> 
> I have applied the fixup patch from Radim for today
> (http://marc.info/?l=linux-next&m=143344030214935&w=2).

It is now fixed on my for-next HEAD.

I rolled this incremental fix into the original to avoid breaking bisect.

-- 
Darren Hart
Intel Open Source Technology Center

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

Hi all,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/silead_dmi.c:84:21: error: variable 'chuwi_vi10_data' has initializer but incomplete type
 static const struct ts_dmi_data chuwi_vi10_data = {
                     ^~~~~~~~~~~
drivers/platform/x86/silead_dmi.c:85:3: error: 'const struct ts_dmi_data' has no member named 'acpi_name'
  .acpi_name      = "MSSL0002:00",
   ^~~~~~~~~
drivers/platform/x86/silead_dmi.c:85:20: warning: excess elements in struct initializer
  .acpi_name      = "MSSL0002:00",
                    ^~~~~~~~~~~~~
drivers/platform/x86/silead_dmi.c:85:20: note: (near initialization for 'chuwi_vi10_data')
drivers/platform/x86/silead_dmi.c:86:3: error: 'const struct ts_dmi_data' has no member named 'properties'
  .properties     = chuwi_vi10_props,
   ^~~~~~~~~~
drivers/platform/x86/silead_dmi.c:86:20: warning: excess elements in struct initializer
  .properties     = chuwi_vi10_props,
                    ^~~~~~~~~~~~~~~~
drivers/platform/x86/silead_dmi.c:86:20: note: (near initialization for 'chuwi_vi10_data')
drivers/platform/x86/silead_dmi.c:84:33: error: storage size of 'chuwi_vi10_data' isn't known
 static const struct ts_dmi_data chuwi_vi10_data = {
                                 ^~~~~~~~~~~~~~~

Caused by commit

  2da502a0aea7 ("platform/x86: silead_dmi: Add touchscreen info for the Chuwi Vi10 tablet")

I have reverted that commit for today.  More care please.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the drivers-x86 tree

[dvhart]

On June 11, 2018 6:23:10 PM PDT, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>Hi all,
>
>After merging the drivers-x86 tree, today's linux-next build (x86_64
>allmodconfig) failed like this:
>
>drivers/platform/x86/silead_dmi.c:84:21: error: variable
>'chuwi_vi10_data' has initializer but incomplete type
> static const struct ts_dmi_data chuwi_vi10_data = {
>                     ^~~~~~~~~~~
...
>Caused by commit
>
>2da502a0aea7 ("platform/x86: silead_dmi: Add touchscreen info for the
>Chuwi Vi10 tablet")
>
>I have reverted that commit for today.  More care please.

Grmbl. Thanks Stephen. I'll work with Andy tonight to get for-next back into good shape.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: linux-next: build failure after merge of the drivers-x86 tree

[Darren Hart]

On Tue, Jun 12, 2018 at 11:23:10AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/platform/x86/silead_dmi.c:84:21: error: variable 'chuwi_vi10_data' has initializer but incomplete type
>  static const struct ts_dmi_data chuwi_vi10_data = {
>                      ^~~~~~~~~~~
> drivers/platform/x86/silead_dmi.c:85:3: error: 'const struct ts_dmi_data' has no member named 'acpi_name'
>   .acpi_name      = "MSSL0002:00",
>    ^~~~~~~~~
> drivers/platform/x86/silead_dmi.c:85:20: warning: excess elements in struct initializer
>   .acpi_name      = "MSSL0002:00",
>                     ^~~~~~~~~~~~~
> drivers/platform/x86/silead_dmi.c:85:20: note: (near initialization for 'chuwi_vi10_data')
> drivers/platform/x86/silead_dmi.c:86:3: error: 'const struct ts_dmi_data' has no member named 'properties'
>   .properties     = chuwi_vi10_props,
>    ^~~~~~~~~~
> drivers/platform/x86/silead_dmi.c:86:20: warning: excess elements in struct initializer
>   .properties     = chuwi_vi10_props,
>                     ^~~~~~~~~~~~~~~~
> drivers/platform/x86/silead_dmi.c:86:20: note: (near initialization for 'chuwi_vi10_data')
> drivers/platform/x86/silead_dmi.c:84:33: error: storage size of 'chuwi_vi10_data' isn't known
>  static const struct ts_dmi_data chuwi_vi10_data = {
>                                  ^~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   2da502a0aea7 ("platform/x86: silead_dmi: Add touchscreen info for the Chuwi Vi10 tablet")
> 
> I have reverted that commit for today.  More care please.

Thank you Stephen. We caught this earlier, but failed to remove it from for-next
while repairing the series. Our apologies. I have removed this series back to
the known good patch in for-next:

26ed9d1 platform/x86: silead_dmi: Add entry for Chuwi Hi8 tablet touchscreen

Andy has this reworked already and is working on completing
testing before pushing the update to for-next.

-- 
Darren Hart
VMware Open Source Technology Center

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi all,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/huawei-wmi.c: In function 'huawei_wmi_exit':
drivers/platform/x86/huawei-wmi.c:890:41: error: 'struct huawei_wmi' has no member named 'pdev'; did you mean 'idev'?
  890 |  platform_device_unregister(huawei_wmi->pdev);
      |                                         ^~~~
      |                                         idev

Caused by commit

  eda34f06b2e0 ("platform/x86: huawei-wmi: No need to keep pointer to platform device")

interacting with commit

  7532afb35012 ("platform/x86: huawei-wmi: Move to platform driver")

I have used the drivers-x86 tree from next-20191014 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the drivers-x86 tree

[Andy Shevchenko]

On Tue, Oct 15, 2019 at 5:00 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/platform/x86/huawei-wmi.c: In function 'huawei_wmi_exit':
> drivers/platform/x86/huawei-wmi.c:890:41: error: 'struct huawei_wmi' has no member named 'pdev'; did you mean 'idev'?
>   890 |  platform_device_unregister(huawei_wmi->pdev);
>       |                                         ^~~~
>       |                                         idev
>
> Caused by commit
>
>   eda34f06b2e0 ("platform/x86: huawei-wmi: No need to keep pointer to platform device")
>
> interacting with commit
>
>   7532afb35012 ("platform/x86: huawei-wmi: Move to platform driver")

Oops, thank you for pointing out, should be fixed.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

Hi Andy,

On Tue, 15 Oct 2019 11:04:29 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> Oops, thank you for pointing out, should be fixed.

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the drivers-x86 tree

[Mark Brown]

Hi all,

After merging the drivers-x86 tree, today's linux-next build
(x86 allmodconfig) failed like this:

error: the following would cause module name conflict:
  drivers/misc/c2port/core.ko
  drivers/platform/x86/intel/pmc/core.ko

Caused by commit

  29036fcc92b22d ("platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder")

Since there was nothing in the branch yesterday I've just dropped the
tree entirely.

Re: linux-next: build failure after merge of the drivers-x86 tree

[Andy Shevchenko]

On Wed, Jul 28, 2021 at 7:49 PM Mark Brown <broonie@kernel.org> wrote:
>
> Hi all,
>
> After merging the drivers-x86 tree, today's linux-next build
> (x86 allmodconfig) failed like this:
>
> error: the following would cause module name conflict:
>   drivers/misc/c2port/core.ko
>   drivers/platform/x86/intel/pmc/core.ko
>
> Caused by commit
>
>   29036fcc92b22d ("platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder")
>
> Since there was nothing in the branch yesterday I've just dropped the
> tree entirely.

Yeah, PMC Makefile should keep the object name the same, something like

obj-$(..._PMC_...) += intel_pmc_....o
intel-pmc_...-y := core.o ...


-- 
With Best Regards,
Andy Shevchenko

RE: linux-next: build failure after merge of the drivers-x86 tree

[Kammela, Gayatri]

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Wednesday, July 28, 2021 10:02 AM
> To: Mark Brown <broonie@kernel.org>
> Cc: Hans de Goede <hdegoede@redhat.com>; Gross, Mark
> <mark.gross@intel.com>; Kammela, Gayatri <gayatri.kammela@intel.com>;
> Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> next@vger.kernel.org>; Platform Driver <platform-driver-
> x86@vger.kernel.org>
> Subject: Re: linux-next: build failure after merge of the drivers-x86 tree
> 
> On Wed, Jul 28, 2021 at 7:49 PM Mark Brown <broonie@kernel.org> wrote:
> >
> > Hi all,
> >
> > After merging the drivers-x86 tree, today's linux-next build
> > (x86 allmodconfig) failed like this:
> >
> > error: the following would cause module name conflict:
> >   drivers/misc/c2port/core.ko
> >   drivers/platform/x86/intel/pmc/core.ko
> >
> > Caused by commit
> >
> >   29036fcc92b22d ("platform/x86/intel: intel_pmc_core: Move
> > intel_pmc_core* files to pmc subfolder")
> >
> > Since there was nothing in the branch yesterday I've just dropped the
> > tree entirely.
> 
> Yeah, PMC Makefile should keep the object name the same, something like
> 
> obj-$(..._PMC_...) += intel_pmc_....o
> intel-pmc_...-y := core.o ...
> 
Hi Andy and Mark,
We've found the issue on our side as well and planning to push the fix soon. Would you prefer to have the whole patch series redone or just the fix ?

> 
> --
> With Best Regards,
> Andy Shevchenko

Re: linux-next: build failure after merge of the drivers-x86 tree

[Hans de Goede]

Hi,

On 7/28/21 7:27 PM, Kammela, Gayatri wrote:
>> -----Original Message-----
>> From: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Sent: Wednesday, July 28, 2021 10:02 AM
>> To: Mark Brown <broonie@kernel.org>
>> Cc: Hans de Goede <hdegoede@redhat.com>; Gross, Mark
>> <mark.gross@intel.com>; Kammela, Gayatri <gayatri.kammela@intel.com>;
>> Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>; Linux Kernel Mailing List
>> <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-
>> next@vger.kernel.org>; Platform Driver <platform-driver-
>> x86@vger.kernel.org>
>> Subject: Re: linux-next: build failure after merge of the drivers-x86 tree
>>
>> On Wed, Jul 28, 2021 at 7:49 PM Mark Brown <broonie@kernel.org> wrote:
>>>
>>> Hi all,
>>>
>>> After merging the drivers-x86 tree, today's linux-next build
>>> (x86 allmodconfig) failed like this:
>>>
>>> error: the following would cause module name conflict:
>>>   drivers/misc/c2port/core.ko
>>>   drivers/platform/x86/intel/pmc/core.ko
>>>
>>> Caused by commit
>>>
>>>   29036fcc92b22d ("platform/x86/intel: intel_pmc_core: Move
>>> intel_pmc_core* files to pmc subfolder")
>>>
>>> Since there was nothing in the branch yesterday I've just dropped the
>>> tree entirely.
>>
>> Yeah, PMC Makefile should keep the object name the same, something like
>>
>> obj-$(..._PMC_...) += intel_pmc_....o
>> intel-pmc_...-y := core.o ...

Right, I will drop the patches from pdx86/for-next and do a forced push.

> Hi Andy and Mark,
> We've found the issue on our side as well and planning to push the fix soon. Would you prefer to have the whole patch series redone or just the fix ?

I've just dropped the current version of the patches,
please send the whole patch series redone.

Thanks & Regards,

Hans

RE: linux-next: build failure after merge of the drivers-x86 tree

[Kammela, Gayatri]

> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Wednesday, July 28, 2021 10:56 AM
> To: Kammela, Gayatri <gayatri.kammela@intel.com>; Andy Shevchenko
> <andy.shevchenko@gmail.com>; Mark Brown <broonie@kernel.org>
> Cc: Gross, Mark <mark.gross@intel.com>; Rajneesh Bhardwaj
> <irenic.rajneesh@gmail.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> next@vger.kernel.org>; Platform Driver <platform-driver-
> x86@vger.kernel.org>
> Subject: Re: linux-next: build failure after merge of the drivers-x86 tree
> 
> Hi,
> 
> On 7/28/21 7:27 PM, Kammela, Gayatri wrote:
> >> -----Original Message-----
> >> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> >> Sent: Wednesday, July 28, 2021 10:02 AM
> >> To: Mark Brown <broonie@kernel.org>
> >> Cc: Hans de Goede <hdegoede@redhat.com>; Gross, Mark
> >> <mark.gross@intel.com>; Kammela, Gayatri
> <gayatri.kammela@intel.com>;
> >> Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>; Linux Kernel Mailing
> >> List <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> >> next@vger.kernel.org>; Platform Driver <platform-driver-
> >> x86@vger.kernel.org>
> >> Subject: Re: linux-next: build failure after merge of the drivers-x86
> >> tree
> >>
> >> On Wed, Jul 28, 2021 at 7:49 PM Mark Brown <broonie@kernel.org>
> wrote:
> >>>
> >>> Hi all,
> >>>
> >>> After merging the drivers-x86 tree, today's linux-next build
> >>> (x86 allmodconfig) failed like this:
> >>>
> >>> error: the following would cause module name conflict:
> >>>   drivers/misc/c2port/core.ko
> >>>   drivers/platform/x86/intel/pmc/core.ko
> >>>
> >>> Caused by commit
> >>>
> >>>   29036fcc92b22d ("platform/x86/intel: intel_pmc_core: Move
> >>> intel_pmc_core* files to pmc subfolder")
> >>>
> >>> Since there was nothing in the branch yesterday I've just dropped
> >>> the tree entirely.
> >>
> >> Yeah, PMC Makefile should keep the object name the same, something
> >> like
> >>
> >> obj-$(..._PMC_...) += intel_pmc_....o intel-pmc_...-y := core.o ...
> 
> Right, I will drop the patches from pdx86/for-next and do a forced push.
> 
> > Hi Andy and Mark,
> > We've found the issue on our side as well and planning to push the fix
> soon. Would you prefer to have the whole patch series redone or just the fix
> ?
> 
> I've just dropped the current version of the patches, please send the whole
> patch series redone.
Sure Hans! I will send the whole patch series redone.
> 
> Thanks & Regards,
> 
> Hans

linux-next: build failure after merge of the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

Hi all,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/platform/x86/ideapad-laptop.c: In function 'ideapad_wmi_notify':
drivers/platform/x86/ideapad-laptop.c:1469:3: error: a label can only be part of a statement and a declaration is not a statement
 1469 |   unsigned long result;
      |   ^~~~~~~~

Caused by commit

  18cfd76e7b84 ("ideapad-laptop: Fix Legion 5 Fn lock LED")

I have used the drivers-x86 tree from next-20210819 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the drivers-x86 tree

[M D]

On Fri, Aug 20, 2021 at 1:00 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/platform/x86/ideapad-laptop.c: In function 'ideapad_wmi_notify':
> drivers/platform/x86/ideapad-laptop.c:1469:3: error: a label can only be part of a statement and a declaration is not a statement
>  1469 |   unsigned long result;
>       |   ^~~~~~~~
>
> Caused by commit
>
>   18cfd76e7b84 ("ideapad-laptop: Fix Legion 5 Fn lock LED")
>
> I have used the drivers-x86 tree from next-20210819 for today.
>
> --
> Cheers,
> Stephen Rothwell

Hi Stephen,

Thanks for your work!

This error occurs because only a statement is allowed after a label,
but a definition is not a statement in C99.
This can be fixed by wrapping the case block with curly braces like this:
case 208: {
...
}

However I don't know why my compiler did not report this error. I was
using gcc 11.1.0 under Arch Linux.

Regards,
Meng Dong

Re: linux-next: build failure after merge of the drivers-x86 tree

[Hans de Goede]

Hi,

On 8/20/21 9:31 AM, M D wrote:
> On Fri, Aug 20, 2021 at 1:00 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi all,
>>
>> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/platform/x86/ideapad-laptop.c: In function 'ideapad_wmi_notify':
>> drivers/platform/x86/ideapad-laptop.c:1469:3: error: a label can only be part of a statement and a declaration is not a statement
>>  1469 |   unsigned long result;
>>       |   ^~~~~~~~
>>
>> Caused by commit
>>
>>   18cfd76e7b84 ("ideapad-laptop: Fix Legion 5 Fn lock LED")
>>
>> I have used the drivers-x86 tree from next-20210819 for today.
>>
>> --
>> Cheers,
>> Stephen Rothwell
> 
> Hi Stephen,
> 
> Thanks for your work!
> 
> This error occurs because only a statement is allowed after a label,
> but a definition is not a statement in C99.
> This can be fixed by wrapping the case block with curly braces like this:
> case 208: {
> ...
> }

Yes, or just move the declaration of result to the beginning of
the function, which is a bit cleaner IMHO.

I've moved the declaration to the beginning of the function and
squashed this fix into the original commit. I'll do a forced
push with the squashed in fix to for-next as soon as a test-compile
completes.

Stephen, as always thank you your work on linux-next and for reporting this.

> However I don't know why my compiler did not report this error. I was
> using gcc 11.1.0 under Arch Linux.

Yes gcc 11.2.1 under Fedora also happily compiles this, and this
sat in my review-hans branch for a while and got happily compiled
by "kernel test robot <lkp@intel.com> " there too.

So this compile error slipped through the crack of all our (compile)
testing until Stephen caught it :)

Regards,

Hans