From: Christoph Hellwig <hch@infradead.org>
To: Alessio Igor Bogani <abogani@texware.it>
Cc: Jan Kara <jack@suse.cz>, Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@infradead.org>,
Tim Bird <tim.bird@am.sony.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] udf: Remove unnecessary bkl usages
Date: Sat, 6 Nov 2010 14:06:39 -0400 [thread overview]
Message-ID: <20101106180639.GC13315@infradead.org> (raw)
In-Reply-To: <1289065631-2256-2-git-send-email-abogani@texware.it>
On Sat, Nov 06, 2010 at 06:47:09PM +0100, Alessio Igor Bogani wrote:
> The udf_lookup, udf_create, udf_mknod, udf_mkdir, udf_rmdir, udf_link,
> udf_unlink and udf_readdir functions seems already adequately protected
> by i_mutex held by VFS invoking calls. The udf_rename function instead
> should be already protected by lock_rename again by VFS.
>
> The udf_get_parent, udf_count_free_bitmap, udf_count_free_table and
> udf_put_super functions don't require any protection.
This looks correct to me. But I'd suggest to reorder it to be the last
patch in the series, after the fine grained locking for the low level
code has been in place.
next prev parent reply other threads:[~2010-11-06 18:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 17:47 [PATCH 1/4] udf: Add missed protection for s_lvid_dirty Alessio Igor Bogani
2010-11-06 17:47 ` [PATCH 2/4] udf: Remove unnecessary bkl usages Alessio Igor Bogani
2010-11-06 18:06 ` Christoph Hellwig [this message]
2010-11-06 17:47 ` [PATCH 3/4] udf: Replace bkl with a mutex for protect udf_inode_info struct Alessio Igor Bogani
2010-11-06 18:10 ` Christoph Hellwig
2010-11-06 17:47 ` [PATCH 4/4] udf: Replace bkl with a mutex for protect udf_sb_info struct Alessio Igor Bogani
2010-11-06 18:16 ` Christoph Hellwig
2010-11-06 18:05 ` [PATCH 1/4] udf: Add missed protection for s_lvid_dirty Christoph Hellwig
2010-11-07 14:14 ` Jan Kara
2010-11-07 14:27 ` Christoph Hellwig
2010-11-07 15:06 ` Jan Kara
2010-11-15 22:46 ` Arnd Bergmann
2010-11-16 0:43 ` Jan Kara
2010-11-16 13:03 ` Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101106180639.GC13315@infradead.org \
--to=hch@infradead.org \
--cc=abogani@texware.it \
--cc=arnd@arndb.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).