From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753962Ab0KHXyd (ORCPT ); Mon, 8 Nov 2010 18:54:33 -0500 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:40478 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302Ab0KHXyc (ORCPT ); Mon, 8 Nov 2010 18:54:32 -0500 Date: Tue, 9 Nov 2010 08:54:07 +0900 From: Paul Mundt To: Alexey Charkov Cc: linux-arm-kernel@lists.infradead.org, vt8500-wm8505-linux-kernel@googlegroups.com, Andrew Morton , Guennadi Liakhovetski , Florian Tobias Schandinat , Ralf Baechle , "David S. Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6 v4] ARM: Add support for the display controllers in VT8500 and WM8505 Message-ID: <20101108235407.GB18385@linux-sh.org> References: <1289147348-31969-1-git-send-email-alchark@gmail.com> <1289147348-31969-6-git-send-email-alchark@gmail.com> <20101108041721.GA11605@linux-sh.org> <20101108141407.GA25739@alchark-u3s.lan> <20101108204315.GA12050@linux-sh.org> <20101108213008.GB17708@linux-sh.org> <20101108234239.GA20819@alchark-u3s.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101108234239.GA20819@alchark-u3s.lan> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 09, 2010 at 02:42:39AM +0300, Alexey Charkov wrote: > From 95942cc0cd0909d700c236ba63d3488ec9fccf1a Mon Sep 17 00:00:00 2001 > From: Alexey Charkov > Date: Tue, 9 Nov 2010 02:25:40 +0300 > Subject: [PATCH 3/3] ARM: Add support for the display controllers in VT8500 and WM8505 > > This adds drivers for the LCD controller found in VIA VT8500 SoC, > GOVR display controller found in WonderMedia WM8505 SoC and for the > Graphics Engine present in both of them that provides hardware > accelerated raster operations (used for copyarea and fillrect). > > Signed-off-by: Alexey Charkov > --- > > This incorporates fixes to the issues last mentioned by Paul. > > I just dropped , as that seems to be not used at all currently > (must have been some old cut-and-paste as well). As for the Graphics > Engine, I decided not to disable it for now at device exit time, at least > until we reach a conclusion on how or whether to implement support for its > alpha-mixing capabilities. Unlike with display drivers, this should have no > user-visible consequences. This can be changed later, when time comes for > device clocks and power management support. > Looks good to me! Reviewed-by: Paul Mundt