From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755091Ab0KIKde (ORCPT ); Tue, 9 Nov 2010 05:33:34 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:58129 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754105Ab0KIKdd (ORCPT ); Tue, 9 Nov 2010 05:33:33 -0500 Date: Tue, 9 Nov 2010 10:33:12 +0000 From: Russell King - ARM Linux To: Paul Mundt Cc: Alexey Charkov , Florian Tobias Schandinat , linux-kernel@vger.kernel.org, Ralf Baechle , "David S. Miller" , vt8500-wm8505-linux-kernel@googlegroups.com, Andrew Morton , Guennadi Liakhovetski , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/6 v3] ARM: Add support for the display controllers in VT8500 and WM8505 Message-ID: <20101109103312.GA2869@n2100.arm.linux.org.uk> References: <1289147348-31969-1-git-send-email-alchark@gmail.com> <1289147348-31969-6-git-send-email-alchark@gmail.com> <20101108041721.GA11605@linux-sh.org> <20101108141407.GA25739@alchark-u3s.lan> <20101108204315.GA12050@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101108204315.GA12050@linux-sh.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 09, 2010 at 05:43:16AM +0900, Paul Mundt wrote: > > diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c > > new file mode 100644 > > index 0000000..640d8a3 > > --- /dev/null > > +++ b/drivers/video/vt8500lcdfb.c > > +#include > > + > linux/irq.h is preferred here. I assume you've read the comment at the top of linux/irq.h ?