From: Ingo Molnar <mingo@elte.hu>
To: Kees Cook <kees.cook@canonical.com>
Cc: matthieu castet <castet.matthieu@free.fr>,
Siarhei Liakh <sliakh.lkml@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Arjan van de Ven <arjan@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Security] proactive defense: using read-only memory, RO/NX modules
Date: Thu, 11 Nov 2010 10:07:13 +0100 [thread overview]
Message-ID: <20101111090713.GC18789@elte.hu> (raw)
In-Reply-To: <20101111065658.GA5876@outflux.net>
* Kees Cook <kees.cook@canonical.com> wrote:
> Hi Ingo,
>
> On Wed, Nov 10, 2010 at 10:04:15AM +0100, Ingo Molnar wrote:
> > * Kees Cook <kees.cook@canonical.com> wrote:
> > > Oh, well, yes, that's a good reason. :) Where was this covered? I'd like to help
> > > get it reproduced and ironed out.
> >
> > Matthieu Castet seems to have dusted off those patches and submitted two of them in
> > this mail:
> >
> > Subject: [RFC] reworked NX protection for kernel data
> >
> > Matthieu, are you still interested in this topic?
> >
> > The original, broken patches were these -tip commits:
> >
> > 1e858c081af5: x86, mm: RO/NX protection for loadable kernel modules
> > 18c60ddc9eff: x86, mm: NX protection for kernel data
> > c226a2feba21: x86, mm: Set first MB as RW+NX
> > b29d530510d4: x86, mm: Correcting improper large page preservation
> >
> > I reported one of the crashes in:
> >
> > Subject: Re: [tip:x86/mm] x86, mm: Set first MB as RW+NX
> >
> > on lkml.
>
> Thanks for looking this up!
>
> Can we get 1e858c081af5 and 18c60ddc9eff back in, and then work forward
> from there?
Yeah. Please port them to latest -tip:
http://people.redhat.com/mingo/tip.git/README
And give them some testing, and send out the new series. I'll re-report the crash to
you for a new kernel, if it still occurs.
(Please also keep Rusty and Linus Cc:-ed for the module bits.)
In hindsight, i think the kernel/module.c bits should be in arch/x86/kernel/module.c
- the new code is full of x86 only names and facilities.
Also, please remove various checkpatch col80 artifacts, such as:
+ if (end_pfn > begin_pfn)
+ set_memory_nx(begin_pfn << PAGE_SHIFT,
+ end_pfn - begin_pfn);
that should be:
+ if (end_pfn > begin_pfn)
+ set_memory_nx(begin_pfn << PAGE_SHIFT, end_pfn - begin_pfn);
Thanks,
Ingo
next prev parent reply other threads:[~2010-11-11 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 19:35 [Security] proactive defense: using read-only memory Kees Cook
2010-11-08 6:13 ` [Security] proactive defense: using read-only memory, RO/NX modules Ingo Molnar
2010-11-08 10:03 ` Alan Cox
2010-11-08 21:42 ` Kees Cook
2010-11-10 9:04 ` Ingo Molnar
2010-11-11 6:56 ` Kees Cook
2010-11-11 9:07 ` Ingo Molnar [this message]
2010-11-13 19:59 ` matthieu castet
2010-11-14 9:56 ` Ingo Molnar
2010-11-17 10:00 ` [Security] proactive defense: using read-only memory Pavel Machek
2010-11-17 22:14 ` Kees Cook
2011-01-02 9:09 ` Pavel Machek
2010-11-18 0:12 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111090713.GC18789@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=castet.matthieu@free.fr \
--cc=hpa@zytor.com \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sliakh.lkml@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).