From: Thomas Renninger <trenn@suse.de>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: mingo@elte.hu, rjw@sisk.pl, linux-kernel@vger.kernel.org,
arjan@linux.intel.com
Subject: Re: [PATCH 2/3] PERF(kernel): Cleanup power events
Date: Sun, 14 Nov 2010 07:34:07 -0600 [thread overview]
Message-ID: <201011140734.07770.trenn@suse.de> (raw)
In-Reply-To: <AANLkTim00A5V9PLP3f_enZ05xR-3VvKOR_9vvXORVPS7@mail.gmail.com>
On Friday 12 November 2010 03:50:21 pm Jean Pihet wrote:
> On Fri, Nov 12, 2010 at 7:17 PM, Thomas Renninger <trenn@suse.de> wrote:
...
> >> > +
> >> > +#ifdef CONFIG_EVENT_POWER_TRACING_DEPRECATED
> >> > +
> >> > #ifndef _TRACE_POWER_ENUM_
> >> > #define _TRACE_POWER_ENUM_
> >> > enum {
> >> > @@ -153,8 +214,32 @@ DEFINE_EVENT(power_domain, power_domain_target,
> >> >
> >> > TP_ARGS(name, state, cpu_id)
> >> > );
> >> > -
> >> > +#endif /* CONFIG_EVENT_POWER_TRACING_DEPRECATED */
> >> The clock and power_domain events have been recently introduced and so
> >> must be part of the new API. Can this #endif be moved right after the
> >> definition of power_end?
> > Oops, I pulled again meanwhile and the patches still patched without fuzz,
> > but probably with some offset.
> > I'll look at that and resend this one.
> Ok
Thanks for pointing this out. Because pre-processor conditionals only have
been moved around it looks like my test build after pulling still succeeded,
while the #ifdefs/#endifs were rather messed up.
I adjusted these parts and successfully test-built on quite a lot .config
flavors on i386, x86_64, different ppc, ia64 and s390.
> >> A string is needed here. Without it it is impossible to have the option
> >> unset.
> >> This does the trick: +bool "Deprecated power event trace API, to be
> >> removed"
Adjusted, thanks.
> > I am currently rebuilding on several archs/flavors and hope to be able
> > to re-send this one today or on Tue.
Done.
@Ingo: If this does not go into x86/tip, but perf or whatever tree, it would
be great if you can ping me as soon as this stuff is in.
I want to cleanup the "double cpu_idle events" issues on top and make this
more architecture independent (throw cpu_idle events from cpuidle framework
instead of throwing very x86 specific mwait states, etc.).
Thanks,
Thomas
next prev parent reply other threads:[~2010-11-14 13:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 18:03 [RESEND] Power trace event cleanup by still providing old interface for some time Thomas Renninger
2010-11-11 18:03 ` [PATCH 1/3] PERF: Do not export power_frequency, but power_start event Thomas Renninger
2010-11-15 15:50 ` Jean Pihet
2010-11-11 18:03 ` [PATCH 2/3] PERF(kernel): Cleanup power events Thomas Renninger
2010-11-12 14:20 ` Jean Pihet
2010-11-12 18:17 ` Thomas Renninger
2010-11-12 21:50 ` Jean Pihet
2010-11-14 13:34 ` Thomas Renninger [this message]
2010-11-18 8:01 ` Ingo Molnar
2010-11-18 9:27 ` Thomas Renninger
2010-11-18 9:36 ` Ingo Molnar
2010-11-18 9:44 ` Jean Pihet
2010-11-18 10:52 ` Ingo Molnar
2010-11-18 16:34 ` Jean Pihet
2010-11-19 0:14 ` Thomas Renninger
2010-11-14 13:22 ` Thomas Renninger
2010-11-15 15:49 ` Jean Pihet
2010-11-11 18:03 ` [PATCH 3/3] PERF(userspace): Adjust perf timechart to the new " Thomas Renninger
2010-11-18 13:01 Power trace event cleanup by still providing old interface for some time Thomas Renninger
2010-11-18 13:01 ` [PATCH 2/3] PERF(kernel): Cleanup power events Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011140734.07770.trenn@suse.de \
--to=trenn@suse.de \
--cc=arjan@linux.intel.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).