From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: 7eggert@gmx.de
Cc: kosaki.motohiro@jp.fujitsu.com,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>, Ying Han <yinghan@google.com>,
linux-kernel@vger.kernel.org, gspencer@chromium.org,
piman@chromium.org, wad@chromium.org, olofj@chromium.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] oom: create a resource limit for oom_adj
Date: Sun, 14 Nov 2010 14:07:12 +0900 (JST) [thread overview]
Message-ID: <20101114140237.E010.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <E1PGgMk-0001AW-OD@be1.7eggert.dyndns.org>
> > Hmm, at first glance that seems potentially dangerous if the current tab
> > generates a burt of memory allocations and it ends up killing all other
> > tabs before finally targeting the culprit whereas currently the heuristic
> > should do a good job of finding this problematic tab and killing it
> > instantly.
>
> The original oom_adj design would e.g. adjust all background tabs to seem
> twice as bad as the current tab, so a ever-growing current tab would
> only be able to get one or two tabs killed in the worst case:
>
> System is near OOM while the current tab starts using a normal amount of
> mem and grows beyond limits. After it easily killed the first bg tab by
> allocating one byte, it needs to grow to twice the normal tab memsize to
> start the OOM killer again. By then, it's score will be equal to normal
> background tabs (half size, double score), and killing the second tab will
> be luck. Killing the third tab should be impossible.
>
> (If you adjust the bg tabs to be four times as killable, you'll get what
> you asked for.)
Sorry for the delay.
I've sent revert patch to linus. We DON'T want to break any userland seriously.
So, we reconsider about this area. personally I hope to reintroduce oom_score_adj
later, but It must don't break current userland.
next prev parent reply other threads:[~2010-11-14 5:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fNx73-1cI-1@gated-at.bofh.it>
[not found] ` <fNzVf-5UY-3@gated-at.bofh.it>
[not found] ` <fNKdY-6FU-11@gated-at.bofh.it>
[not found] ` <fNMps-1S1-21@gated-at.bofh.it>
2010-11-11 23:15 ` [PATCH] oom: create a resource limit for oom_adj Bodo Eggert
2010-11-11 23:21 ` David Rientjes
2010-11-14 5:07 ` KOSAKI Motohiro [this message]
2010-11-14 21:42 ` David Rientjes
2010-11-23 7:16 ` KOSAKI Motohiro
[not found] ` <fNNOx-4qf-1@gated-at.bofh.it>
[not found] ` <fNOAW-5Oi-35@gated-at.bofh.it>
[not found] ` <fNPdF-6Hu-33@gated-at.bofh.it>
[not found] ` <fOctz-4o0-9@gated-at.bofh.it>
2010-11-14 0:05 ` [PATCH] oom: allow a non-CAP_SYS_RESOURCE proces to oom_score_adj down Bodo Eggert
2010-11-11 5:19 [PATCH] oom: create a resource limit for oom_adj Figo.zhang
-- strict thread matches above, loose matches on Subject: below --
2010-11-11 4:35 Mandeep Singh Baines
2010-11-11 7:35 ` David Rientjes
2010-11-11 18:30 ` Mandeep Singh Baines
2010-11-11 20:57 ` David Rientjes
2010-11-11 22:25 ` Mandeep Singh Baines
2010-11-11 23:19 ` David Rientjes
2010-11-11 23:56 ` Mandeep Singh Baines
2010-11-14 5:07 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114140237.E010.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=7eggert@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=gspencer@chromium.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=piman@chromium.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).