From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm,vmscan: Convert lumpy_mode into a bitmask
Date: Sun, 14 Nov 2010 14:40:21 +0900 (JST) [thread overview]
Message-ID: <20101114143744.E01C.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1289502424-12661-2-git-send-email-mel@csn.ul.ie>
> Currently lumpy_mode is an enum and determines if lumpy reclaim is off,
> syncronous or asyncronous. In preparation for using compaction instead of
> lumpy reclaim, this patch converts the flags into a bitmap.
>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> ---
> include/trace/events/vmscan.h | 6 +++---
> mm/vmscan.c | 37 +++++++++++++++++++------------------
> 2 files changed, 22 insertions(+), 21 deletions(-)
>
> diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
> index c255fcc..be76429 100644
> --- a/include/trace/events/vmscan.h
> +++ b/include/trace/events/vmscan.h
> @@ -25,13 +25,13 @@
>
> #define trace_reclaim_flags(page, sync) ( \
> (page_is_file_cache(page) ? RECLAIM_WB_FILE : RECLAIM_WB_ANON) | \
> - (sync == LUMPY_MODE_SYNC ? RECLAIM_WB_SYNC : RECLAIM_WB_ASYNC) \
> + (sync & LUMPY_MODE_SYNC ? RECLAIM_WB_SYNC : RECLAIM_WB_ASYNC) \
> )
>
> #define trace_shrink_flags(file, sync) ( \
> - (sync == LUMPY_MODE_SYNC ? RECLAIM_WB_MIXED : \
> + (sync & LUMPY_MODE_SYNC ? RECLAIM_WB_MIXED : \
> (file ? RECLAIM_WB_FILE : RECLAIM_WB_ANON)) | \
> - (sync == LUMPY_MODE_SYNC ? RECLAIM_WB_SYNC : RECLAIM_WB_ASYNC) \
> + (sync & LUMPY_MODE_SYNC ? RECLAIM_WB_SYNC : RECLAIM_WB_ASYNC) \
> )
>
> TRACE_EVENT(mm_vmscan_kswapd_sleep,
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b8a6fdc..ffa438e 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -51,11 +51,11 @@
> #define CREATE_TRACE_POINTS
> #include <trace/events/vmscan.h>
>
> -enum lumpy_mode {
> - LUMPY_MODE_NONE,
> - LUMPY_MODE_ASYNC,
> - LUMPY_MODE_SYNC,
> -};
> +typedef unsigned __bitwise__ lumpy_mode;
> +#define LUMPY_MODE_SINGLE ((__force lumpy_mode)0x01u)
> +#define LUMPY_MODE_ASYNC ((__force lumpy_mode)0x02u)
> +#define LUMPY_MODE_SYNC ((__force lumpy_mode)0x04u)
> +#define LUMPY_MODE_CONTIGRECLAIM ((__force lumpy_mode)0x08u)
Please write a comment of description of each bit meaning.
>
> struct scan_control {
> /* Incremented by the number of inactive pages that were scanned */
> @@ -88,7 +88,7 @@ struct scan_control {
> * Intend to reclaim enough continuous memory rather than reclaim
> * enough amount of memory. i.e, mode for high order allocation.
> */
> - enum lumpy_mode lumpy_reclaim_mode;
> + lumpy_mode lumpy_reclaim_mode;
>
> /* Which cgroup do we reclaim from */
> struct mem_cgroup *mem_cgroup;
> @@ -274,13 +274,13 @@ unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask,
> static void set_lumpy_reclaim_mode(int priority, struct scan_control *sc,
> bool sync)
> {
> - enum lumpy_mode mode = sync ? LUMPY_MODE_SYNC : LUMPY_MODE_ASYNC;
> + lumpy_mode mode = sync ? LUMPY_MODE_SYNC : LUMPY_MODE_ASYNC;
>
> /*
> * Some reclaim have alredy been failed. No worth to try synchronous
> * lumpy reclaim.
> */
> - if (sync && sc->lumpy_reclaim_mode == LUMPY_MODE_NONE)
> + if (sync && sc->lumpy_reclaim_mode & LUMPY_MODE_SINGLE)
> return;
Probaby, we can remove LUMPY_MODE_SINGLE entirely. and this line can be
change to
if (sync && !(sc->lumpy_reclaim_mode & LUMPY_MODE_CONTIGRECLAIM))
btw, LUMPY_MODE_ASYNC can be removed too.
>
> /*
> @@ -288,17 +288,18 @@ static void set_lumpy_reclaim_mode(int priority, struct scan_control *sc,
> * trouble getting a small set of contiguous pages, we
> * will reclaim both active and inactive pages.
> */
> + sc->lumpy_reclaim_mode = LUMPY_MODE_CONTIGRECLAIM;
> if (sc->order > PAGE_ALLOC_COSTLY_ORDER)
> - sc->lumpy_reclaim_mode = mode;
> + sc->lumpy_reclaim_mode |= mode;
> else if (sc->order && priority < DEF_PRIORITY - 2)
> - sc->lumpy_reclaim_mode = mode;
> + sc->lumpy_reclaim_mode |= mode;
> else
> - sc->lumpy_reclaim_mode = LUMPY_MODE_NONE;
> + sc->lumpy_reclaim_mode = LUMPY_MODE_SINGLE | LUMPY_MODE_ASYNC;
> }
>
> static void disable_lumpy_reclaim_mode(struct scan_control *sc)
> {
> - sc->lumpy_reclaim_mode = LUMPY_MODE_NONE;
> + sc->lumpy_reclaim_mode = LUMPY_MODE_SINGLE | LUMPY_MODE_ASYNC;
> }
>
> static inline int is_page_cache_freeable(struct page *page)
> @@ -429,7 +430,7 @@ static pageout_t pageout(struct page *page, struct address_space *mapping,
> * first attempt to free a range of pages fails.
> */
> if (PageWriteback(page) &&
> - sc->lumpy_reclaim_mode == LUMPY_MODE_SYNC)
> + (sc->lumpy_reclaim_mode & LUMPY_MODE_SYNC))
> wait_on_page_writeback(page);
>
> if (!PageWriteback(page)) {
> @@ -615,7 +616,7 @@ static enum page_references page_check_references(struct page *page,
> referenced_page = TestClearPageReferenced(page);
>
> /* Lumpy reclaim - ignore references */
> - if (sc->lumpy_reclaim_mode != LUMPY_MODE_NONE)
> + if (sc->lumpy_reclaim_mode & LUMPY_MODE_CONTIGRECLAIM)
> return PAGEREF_RECLAIM;
>
> /*
> @@ -732,7 +733,7 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> * for any page for which writeback has already
> * started.
> */
> - if (sc->lumpy_reclaim_mode == LUMPY_MODE_SYNC &&
> + if ((sc->lumpy_reclaim_mode & LUMPY_MODE_SYNC) &&
> may_enter_fs)
> wait_on_page_writeback(page);
> else {
> @@ -1317,7 +1318,7 @@ static inline bool should_reclaim_stall(unsigned long nr_taken,
> return false;
>
> /* Only stall on lumpy reclaim */
> - if (sc->lumpy_reclaim_mode == LUMPY_MODE_NONE)
> + if (sc->lumpy_reclaim_mode & LUMPY_MODE_SINGLE)
> return false;
>
> /* If we have relaimed everything on the isolated list, no stall */
> @@ -1368,7 +1369,7 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone,
> if (scanning_global_lru(sc)) {
> nr_taken = isolate_pages_global(nr_to_scan,
> &page_list, &nr_scanned, sc->order,
> - sc->lumpy_reclaim_mode == LUMPY_MODE_NONE ?
> + sc->lumpy_reclaim_mode & LUMPY_MODE_SINGLE ?
> ISOLATE_INACTIVE : ISOLATE_BOTH,
> zone, 0, file);
> zone->pages_scanned += nr_scanned;
> @@ -1381,7 +1382,7 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone,
> } else {
> nr_taken = mem_cgroup_isolate_pages(nr_to_scan,
> &page_list, &nr_scanned, sc->order,
> - sc->lumpy_reclaim_mode == LUMPY_MODE_NONE ?
> + sc->lumpy_reclaim_mode & LUMPY_MODE_SINGLE ?
> ISOLATE_INACTIVE : ISOLATE_BOTH,
> zone, sc->mem_cgroup,
> 0, file);
> --
> 1.7.1
>
next prev parent reply other threads:[~2010-11-14 5:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 19:07 [RFC PATCH 0/3] Use compaction to reduce a dependency on lumpy reclaim Mel Gorman
2010-11-11 19:07 ` [PATCH 1/3] mm,vmscan: Convert lumpy_mode into a bitmask Mel Gorman
2010-11-14 5:40 ` KOSAKI Motohiro [this message]
2010-11-15 9:16 ` Mel Gorman
2010-11-11 19:07 ` [PATCH 2/3] mm,compaction: Add COMPACTION_BUILD Mel Gorman
2010-11-14 5:45 ` KOSAKI Motohiro
2010-11-15 9:26 ` Mel Gorman
2010-11-11 19:07 ` [PATCH 3/3] mm,vmscan: Reclaim order-0 and compact instead of lumpy reclaim when under light pressure Mel Gorman
2010-11-12 9:37 ` Mel Gorman
2010-11-14 5:43 ` KOSAKI Motohiro
2010-11-15 9:17 ` Mel Gorman
2010-11-14 6:02 ` KOSAKI Motohiro
2010-11-15 9:22 ` Mel Gorman
2010-11-15 15:23 ` Andrea Arcangeli
2010-11-14 5:59 ` KOSAKI Motohiro
2010-11-15 9:25 ` Mel Gorman
2010-11-14 5:31 ` [RFC PATCH 0/3] Use compaction to reduce a dependency on lumpy reclaim KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114143744.E01C.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).