From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754615Ab0KOJ1L (ORCPT ); Mon, 15 Nov 2010 04:27:11 -0500 Received: from gir.skynet.ie ([193.1.99.77]:50574 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753221Ab0KOJ1K (ORCPT ); Mon, 15 Nov 2010 04:27:10 -0500 Date: Mon, 15 Nov 2010 09:26:55 +0000 From: Mel Gorman To: KOSAKI Motohiro Cc: Andrea Arcangeli , Andrew Morton , Rik van Riel , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm,compaction: Add COMPACTION_BUILD Message-ID: <20101115092655.GG27362@csn.ul.ie> References: <1289502424-12661-1-git-send-email-mel@csn.ul.ie> <1289502424-12661-3-git-send-email-mel@csn.ul.ie> <20101114144413.E022.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20101114144413.E022.A69D9226@jp.fujitsu.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 14, 2010 at 02:45:07PM +0900, KOSAKI Motohiro wrote: > > To avoid #ifdef COMPACTION in a following patch, this patch adds > > COMPACTION_BUILD that is similar to NUMA_BUILD in operation. > > > > Signed-off-by: Mel Gorman > > --- > > include/linux/kernel.h | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/kernel.h b/include/linux/kernel.h > > index 450092c..c00c5d1 100644 > > --- a/include/linux/kernel.h > > +++ b/include/linux/kernel.h > > @@ -826,6 +826,13 @@ struct sysinfo { > > #define NUMA_BUILD 0 > > #endif > > > > +/* This helps us avoid #ifdef CONFIG_COMPACTION */ > > +#ifdef CONFIG_COMPACTION > > +#define COMPACTION_BUILD 1 > > +#else > > +#define COMPACTION_BUILD 0 > > +#endif > > + > > Looks good, of cource. but I think this patch can be fold [3/3] beucase > it doesn't have any change. > Ok, I can do that. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab