From: David Miller <davem@davemloft.net>
To: w.sang@pengutronix.de
Cc: wg@grandegger.com, tomoya-linux@dsn.okisemi.com,
andrew.chih.howe.khor@intel.com, masa-korg@dsn.okisemi.com,
sameo@linux.intel.com, margie.foster@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
socketcan-core@lists.berlios.de, kok.howg.ewe@intel.com,
joel.clark@intel.com, yong.y.wang@intel.com, chripell@fsfe.org,
qi.wang@intel.com
Subject: Re: [PATCH net-next-2.6 v4] can: Topcliff: PCH_CAN driver: Add Flow control/Fix Endianess issue/Separate IF register/Enumerate LEC macro/Move MSI processing/Use BIT(X)/Change Message Object index/Add prefix PCH_
Date: Tue, 16 Nov 2010 13:10:08 -0800 (PST) [thread overview]
Message-ID: <20101116.131008.212663108.davem@davemloft.net> (raw)
In-Reply-To: <20101116210716.GA19893@pengutronix.de>
From: Wolfram Sang <w.sang@pengutronix.de>
Date: Tue, 16 Nov 2010 22:07:16 +0100
> On Tue, Nov 16, 2010 at 12:43:25PM -0800, David Miller wrote:
>> From: Wolfgang Grandegger <wg@grandegger.com>
>> Date: Tue, 16 Nov 2010 21:39:47 +0100
>>
>> > Please take into account that this patch got accepted by accident
>> > (because the maintainer did not respond properly in time). At that time
>> > the driver was incomplete, not ready for mainline and did not even work
>> > properly. Therefore it makes little sense to debug or even bisec these
>> > changes. Just for that reason I made an exemption and added my
>> > "Acked-by". Hope you can share my arguments.
>>
>> You don't put stupid on top of stupid and justify the latter using
>> the former.
>
> Is reverting the incomplete driver an option?
I told everyone that the plan was that we had several months
to fix this, and that's what we should do.
But yes if people are going to be maximally difficult about this and
refuse to split up the bug fixes, I will have to regrettably revert
the driver.
But let's avoid that if we can.
next prev parent reply other threads:[~2010-11-16 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 12:14 [PATCH net-next-2.6 v4] can: Topcliff: PCH_CAN driver: Add Flow control/Fix Endianess issue/Separate IF register/Enumerate LEC macro/Move MSI processing/Use BIT(X)/Change Message Object index/Add prefix PCH_ Tomoya MORINAGA
2010-11-16 12:22 ` Wolfgang Grandegger
2010-11-16 17:14 ` David Miller
2010-11-16 20:39 ` Wolfgang Grandegger
2010-11-16 20:43 ` David Miller
2010-11-16 21:07 ` Wolfram Sang
2010-11-16 21:10 ` David Miller [this message]
2010-11-17 3:00 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116.131008.212663108.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=w.sang@pengutronix.de \
--cc=wg@grandegger.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).