From: Andrew Morton <akpm@linux-foundation.org>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com,
stable@kernel.org
Subject: Re: [PATCH] Make swap accounting default behavior configurable
Date: Tue, 16 Nov 2010 17:12:25 -0800 [thread overview]
Message-ID: <20101116171225.274019cf.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101117092339.1b7c2d6d.nishimura@mxp.nes.nec.co.jp>
On Wed, 17 Nov 2010 09:23:39 +0900 Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> > >
> > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> > > index ed45e98..14eafa5 100644
> > > --- a/Documentation/kernel-parameters.txt
> > > +++ b/Documentation/kernel-parameters.txt
> > > @@ -2385,6 +2385,9 @@ and is between 256 and 4096 characters. It is defined in the file
> > > improve throughput, but will also increase the
> > > amount of memory reserved for use by the client.
> > >
> > > + swapaccount [KNL] Enable accounting of swap in memory resource
> > > + controller. (See Documentation/cgroups/memory.txt)
> >
> > So we have swapaccount and noswapaccount. Ho hum, "swapaccount=[1|0]"
> > would have been better.
> >
> I suggested to keep "noswapaccount" for compatibility.
> If you and other guys don't like having two parameters, I don't stick to
> the old parameter.
>
Yes, we're stuck with the old one now.
But we should note that "foo=[0|1]" is superior to "foo" and "nofoo".
Even if we didn't initially intend to add "nofoo".
next prev parent reply other threads:[~2010-11-17 1:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 10:17 [PATCH] Make swap accounting default behavior configurable Michal Hocko
2010-11-16 20:46 ` Andrew Morton
2010-11-16 21:21 ` [stable] " Greg KH
2010-11-18 8:21 ` Michal Hocko
2010-11-18 16:36 ` Greg KH
2010-11-17 0:23 ` Daisuke Nishimura
2010-11-17 0:57 ` KAMEZAWA Hiroyuki
2010-11-17 1:12 ` Andrew Morton [this message]
2010-11-17 3:28 ` Daisuke Nishimura
2010-11-18 8:23 ` Michal Hocko
2010-11-18 8:46 ` Daisuke Nishimura
2010-11-18 8:53 ` KAMEZAWA Hiroyuki
2010-11-18 9:56 ` [PATCH] Make swap accounting default behavior configurable v4 Michal Hocko
2010-11-18 10:14 ` Daisuke Nishimura
2010-11-18 10:23 ` Michal Hocko
2010-11-18 17:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116171225.274019cf.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).