From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934907Ab0KQQbg (ORCPT ); Wed, 17 Nov 2010 11:31:36 -0500 Received: from kroah.org ([198.145.64.141]:48204 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933815Ab0KQQbf (ORCPT ); Wed, 17 Nov 2010 11:31:35 -0500 Date: Wed, 17 Nov 2010 08:09:19 -0800 From: Greg KH To: Pavel Machek Cc: Eric Cooper , linux-kernel@vger.kernel.org, Richard Purdie Subject: Re: [PATCH] add netdev led trigger Message-ID: <20101117160919.GC10992@kroah.com> References: <1289768305-1224-1-git-send-email-ecc@cmu.edu> <20101117105925.GC1574@ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101117105925.GC1574@ucw.cz> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 17, 2010 at 12:05:16PM +0100, Pavel Machek wrote: > Hi! > > > Add a netdev LED trigger for all Blinkenlights lovers... > > Originally taken from https://dev.openwrt.org/ticket/2776 > > Slightly updated for 2.6.24 by Mickey Lauer > > and for 2.6.36 by Eric Cooper > > Nice! > > > +/* > > + * Configurable sysfs attributes: > > + * > > + * device_name - network device name to monitor > > + * > > + * interval - duration of LED blink, in milliseconds > > This needs to go to Doc/ somewhere. Documentation/ABI is the correct place for it. thanks, greg k-h