linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	USB list <linux-usb@vger.kernel.org>,
	linux-next@vger.kernel.org,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the usb tree
Date: Wed, 17 Nov 2010 13:25:44 -0800	[thread overview]
Message-ID: <20101117212544.GA10541@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1011171049130.1704-100000@iolanthe.rowland.org>

On Wed, Nov 17, 2010 at 10:56:01AM -0500, Alan Stern wrote:
> On Tue, 16 Nov 2010, Greg KH wrote:
> 
> > On Wed, Nov 17, 2010 at 01:14:53PM +1100, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > > 
> > > drivers/media/video/tlg2300/pd-main.c: In function 'poseidon_probe':
> > > drivers/media/video/tlg2300/pd-main.c:455: error: 'struct usb_device' has no member named 'autosuspend_delay'
> > > drivers/net/wimax/i2400m/usb.c: In function 'i2400mu_probe':
> > > drivers/net/wimax/i2400m/usb.c:517: error: 'struct usb_device' has no member named 'autosuspend_delay'
> > > 
> > > Caused by commit fcc4a01eb8661226e80632327673f67bf6a5840b ("USB: use the
> > > runtime-PM autosuspend implementation").  More grepping required ...
> > > 
> > > I have used the usb tree from next-20101116 for today.
> > 
> > Ick.  Alan, care to provide a patch?
> 
> Here it is.  I'm not sure that having this code at all is really the
> best approach.  It means the drivers will override any autosuspend
> values set by userspace when their devices are first detected.
> 
> Also there are bogus calls to device_init_wakeup(), and truly silly
> preprocessor tests of the kernel version in the staging-tree file.  
> Nevertheless, this is the minimal fix.

Don't worry about that staging driver that much, it has been massivly
cleaned up for .38, and then abandonded so the future of it is very
unlikely :)

I've applied this now, thanks.

greg k-h

  reply	other threads:[~2010-11-17 21:37 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  2:14 linux-next: build failure after merge of the usb tree Stephen Rothwell
2010-11-17  4:20 ` Greg KH
2010-11-17 15:56   ` Alan Stern
2010-11-17 21:25     ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-10-04  2:22 Stephen Rothwell
2023-10-04  6:43 ` Greg KH
2023-10-04  6:47   ` Rohit Agarwal
2023-10-04 12:46     ` Greg KH
2023-10-09  9:18       ` Rohit Agarwal
2023-10-09  9:48         ` Greg KH
2023-10-09  9:49           ` Dmitry Baryshkov
2023-10-12 17:03             ` Rohit Agarwal
2023-10-16 18:43               ` Greg KH
2023-03-27  5:02 Stephen Rothwell
2023-03-27  7:37 ` Greg KH
2022-11-30  2:18 Stephen Rothwell
2022-11-30 10:52 ` Greg KH
2022-11-30 10:58   ` Andy Shevchenko
2022-11-30 17:43     ` Andy Shevchenko
2022-11-30 17:46       ` Greg KH
2022-11-30 10:53 ` Andy Shevchenko
2022-07-18  6:31 Stephen Rothwell
2022-07-18 20:43 ` Greg KH
2022-07-18 21:41   ` Prashant Malani
2022-07-18 22:08     ` Prashant Malani
2022-07-19  6:50     ` Greg KH
2022-07-19 12:01       ` Greg KH
2022-07-19 17:11         ` Prashant Malani
2022-07-19  6:08   ` Stephen Rothwell
2022-06-14  2:08 Stephen Rothwell
2022-06-14  2:41 ` Neal Liu
2022-06-14  6:30   ` Stephen Rothwell
2022-06-14  6:41 ` Greg KH
2022-06-14  7:52   ` Stephen Rothwell
2022-06-14  8:10     ` Bagas Sanjaya
2022-06-14  9:28       ` Greg KH
2022-06-14 11:11       ` Stephen Rothwell
2022-05-02 11:07 Stephen Rothwell
2022-05-02 11:40 ` Greg KH
2022-05-02 17:09   ` Matthias Kaehlcke
2022-05-02 17:32     ` Greg KH
2022-05-02 17:49       ` Matthias Kaehlcke
2022-05-03 14:49 ` Greg KH
2021-04-12 11:36 Stephen Rothwell
2021-04-12 12:35 ` Greg KH
2021-04-12 12:41   ` Heikki Krogerus
2020-03-16  3:10 Stephen Rothwell
2020-03-16 11:30 ` Thierry Reding
2020-03-16 13:28   ` Greg KH
2020-03-16 13:44     ` Thierry Reding
2019-06-19  6:43 Stephen Rothwell
2019-06-19 14:56 ` Greg KH
2014-12-01  8:19 Stephen Rothwell
2014-12-02 18:12 ` Greg KH
2014-12-03  5:57   ` Kishon Vijay Abraham I
2014-07-24  7:07 Stephen Rothwell
2014-07-24  7:44 ` Greg KH
2014-08-06  1:39   ` Stephen Rothwell
2014-08-06  4:04     ` Greg KH
2014-05-29  9:01 Stephen Rothwell
2014-05-29 18:18 ` Greg KH
2014-05-29 18:40   ` Dan Williams
2013-04-18  6:05 Stephen Rothwell
2013-04-18 16:06 ` Joe Perches
2013-03-27  3:41 Stephen Rothwell
2013-03-27  3:51 ` Ming Lei
2013-03-27  4:20   ` Greg KH
2013-03-28 18:04 ` Greg KH
2013-01-28 10:46 Stephen Rothwell
2013-01-28 14:45 ` Greg KH
2013-01-28 14:50   ` Lan Tianyu
2013-01-28 15:28   ` Lan Tianyu
2013-01-28 16:03   ` Lan, Tianyu
2013-01-29 13:41     ` Greg KH
2013-01-29 13:51       ` Lan, Tianyu
2013-01-29 14:59         ` Greg KH
2013-01-21  4:21 Stephen Rothwell
2013-01-21  8:37 ` Lan, Tianyu
2012-09-19  4:31 Stephen Rothwell
2012-09-19  7:17 ` Greg KH
2012-09-19 13:59 ` Alan Cox
2012-09-19 14:13   ` Greg KH
2012-05-21  6:22 Stephen Rothwell
2012-05-21 12:56 ` Sarah Sharp
2012-04-27  4:12 Stephen Rothwell
2012-04-27 18:25 ` Greg KH
2010-09-14  2:54 Stephen Rothwell
2010-09-14  4:03 ` Greg KH
2010-09-14  4:08 ` Greg KH
2010-09-14  4:25   ` Stephen Rothwell
2010-09-14 13:26     ` Greg KH
2010-09-15 13:21     ` Mihai Donțu
2010-09-02  3:54 Stephen Rothwell
2010-09-02  4:32 ` Greg KH
2010-09-02  4:36   ` Michał Nazarewicz
2010-09-02  4:51   ` Stephen Rothwell
2010-05-18  7:42 Stephen Rothwell
2010-05-18 13:54 ` Alan Stern
2010-05-18 14:08   ` Greg KH
2010-05-18 21:11   ` Greg KH
2010-05-19 22:49     ` Stephen Rothwell
2010-05-20  6:39       ` Greg KH
2010-05-18 14:00 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117212544.GA10541@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).