Re: [PATCH v4 0/6] FM V4L2 drivers for WL128x

[Hans Verkuil <hverkuil@xs4all.nl>]

On Thursday, November 18, 2010 06:54:16 Pavan Savoy wrote:
> Hans, Mauro, Ohad,
> 
> On Wed, Nov 17, 2010 at 6:32 PM, Ohad Ben-Cohen <ohad@wizery.com> wrote:
> > Hi Manjunatha,
> >
> > On Tue, Nov 16, 2010 at 3:18 PM,  <manjunatha_halli@ti.com> wrote:
> >>  drivers/staging/ti-st/Kconfig        |   10 +
> >>  drivers/staging/ti-st/Makefile       |    2 +
> >>  drivers/staging/ti-st/fmdrv.h        |  259 ++++
> >>  drivers/staging/ti-st/fmdrv_common.c | 2141 ++++++++++++++++++++++++++++++++++
> >>  drivers/staging/ti-st/fmdrv_common.h |  458 ++++++++
> >>  drivers/staging/ti-st/fmdrv_rx.c     |  979 ++++++++++++++++
> >>  drivers/staging/ti-st/fmdrv_rx.h     |   59 +
> >>  drivers/staging/ti-st/fmdrv_tx.c     |  461 ++++++++
> >>  drivers/staging/ti-st/fmdrv_tx.h     |   37 +
> >>  drivers/staging/ti-st/fmdrv_v4l2.c   |  757 ++++++++++++
> >>  drivers/staging/ti-st/fmdrv_v4l2.h   |   32 +
> >>  11 files changed, 5195 insertions(+), 0 deletions(-)
> >
> > Usually when a driver is added to staging, it should also have a TODO
> > file specifying what needs to be done before the driver can be taken
> > out of staging (at least as far as the author knows of today).
> >
> > It helps keeping track of the open issues in the driver, which is good
> > for everyone - the author, the random contributor/observer, and
> > probably even the staging maintainer.
> >
> > Can you please add such a TODO file ?
> >
> > Thanks,
> > Ohad.
> 
> Thanks Ohad, for the comments, We do have an internal TODO.
> In terms of functionality we have stuff like TX RDS which already has
> few CIDs in the extended controls.
> extend V4L2 for complete-scan, add in stop search during hw_seek .. etc...
> But I just wanted to ask whether this is good enough to be staged.
> Because as we begin to implement and add in the items in TODO - the
> patch set will keep continuing to grow.
> 
> So Hans, Mauro, What do you think ?
> It would be real helpful - if this can be staged, it is becoming
> difficult to maintain for us.

I have no problem with it going to staging. It is not yet ready for the
mainline. I'll try to do a quick review and point out what needs to be
changed.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by Cisco