From: Andres Salomon <dilinger@queued.net>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: michael@ellerman.id.au, Ingo Molnar <mingo@elte.hu>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Milton Miller <miltonm@bga.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2)
Date: Thu, 18 Nov 2010 09:41:53 -0800 [thread overview]
Message-ID: <20101118094153.4515cbc2@queued.net> (raw)
In-Reply-To: <4CE54064.6010702@zytor.com>
On Thu, 18 Nov 2010 07:04:04 -0800
"H. Peter Anvin" <hpa@zytor.com> wrote:
> On 11/18/2010 03:02 AM, Michael Ellerman wrote:
> > On Thu, 2010-11-18 at 09:34 +0100, Ingo Molnar wrote:
> >>
> >> Look at the general balance of hardship: very little harm is done
> >> (it's not a big deal if a variable is only used in a single
> >> function) but having it with local variables can be _really_
> >> harmful - for example i overlooked them when i reviewed this
> >> patch. I dont like important details obscured - i like them to be
> >> apparent. Again, this is something that some people can parse
> >> immediately on the visual level
> >> - me and many others cannot.
> >
>
> No, sorry, this sounds like a personal preference that is well out of
> line with the vast majority of C programmers I've ever come across,
> not just in the Linux kernel world but outside of it.
This is actually one of the reasons I specifically like initialized
static variables (inside of functions). Take the following code:
int foo(void)
{
static char *frob = NULL;
int p;
if (frob) {
...
}
Upon seeing that and thinking "whoa, how could frob be
initialized and then checked?", I realize that it's either a bug or I
look back at the initialization and realize that frob is static. It's
less obvious (to me) with non-explicit initialization.
next prev parent reply other threads:[~2010-11-18 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 5:45 [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2) Andres Salomon
2010-11-12 7:48 ` Milton Miller
2010-11-12 8:27 ` Andres Salomon
2010-11-14 9:50 ` Ingo Molnar
2010-11-15 4:21 ` H. Peter Anvin
2010-11-15 7:02 ` Ingo Molnar
2010-11-15 17:43 ` H. Peter Anvin
2010-11-17 6:12 ` [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v3) Andres Salomon
2010-11-29 23:39 ` [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v4) Andres Salomon
2010-12-16 2:58 ` [tip:x86/olpc] x86, olpc: Speed up device tree creation during boot tip-bot for Andres Salomon
2010-11-18 8:34 ` [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2) Ingo Molnar
2010-11-18 11:02 ` Michael Ellerman
2010-11-18 15:04 ` H. Peter Anvin
2010-11-18 17:41 ` Andres Salomon [this message]
2010-11-18 17:48 ` H. Peter Anvin
2010-11-19 20:24 ` Andres Salomon
2010-12-23 11:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118094153.4515cbc2@queued.net \
--to=dilinger@queued.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=miltonm@bga.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).