From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Robert Morell <rmorell@nvidia.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] perf: Remove hardcoded include paths for elfutils
Date: Fri, 19 Nov 2010 16:44:38 -0200 [thread overview]
Message-ID: <20101119184438.GB23996@ghostprotocols.net> (raw)
In-Reply-To: <4CE339C3.6070009@hitachi.com>
Em Wed, Nov 17, 2010 at 11:11:15AM +0900, Masami Hiramatsu escreveu:
> (2010/11/17 7:16), Robert Morell wrote:
> > This change removes the use of hardcoded absolute
> > "/usr/include/elfutils" paths from the perf build. The problem with
> > hardcoded paths is that it prevents them from being overridden by
> > $prefix or by -I in CFLAGS (e.g., for cross-compiling purposes).
> >
> > Instead, just include the "elfutils/" subdirectory as a relative path
> > when files are needed from that directory.
>
> Looks good to me, Thanks!
>
> >
> > Tested by building perf:
> > - Cross-compiled for ARM on x86_64
> > - Built natively on x86_64
> > - Built on x86_64 with /usr/include/elfutils moved to another location
> > and manually included in CFLAGS
> >
> > Signed-off-by: Robert Morell <rmorell@nvidia.com>
>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks, applied,
- Arnaldo
next prev parent reply other threads:[~2010-11-19 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 22:16 [PATCH RESEND] perf: Remove hardcoded include paths for elfutils Robert Morell
2010-11-17 2:11 ` Masami Hiramatsu
2010-11-19 18:44 ` Arnaldo Carvalho de Melo [this message]
2010-11-21 13:43 ` [tip:perf/core] perf tools: " tip-bot for Robert Morell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119184438.GB23996@ghostprotocols.net \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rmorell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).