From: Ingo Molnar <mingo@elte.hu>
To: Arnd Hannemann <arnd@arndnet.de>
Cc: "Berg, Johannes" <johannes.berg@intel.com>,
Michal Hocko <mhocko@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Richard Purdie <rpurdie@linux.intel.com>
Subject: Re: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS
Date: Tue, 23 Nov 2010 07:32:00 +0100 [thread overview]
Message-ID: <20101123063200.GA23907@elte.hu> (raw)
In-Reply-To: <4CEAA151.7050404@arndnet.de>
* Arnd Hannemann <arnd@arndnet.de> wrote:
> Am 18.11.2010 17:52, schrieb Berg, Johannes:
> >>>> it seems that your patch (5ada28bf76752e33dce3d807bf0dfbe6d1b943ad)
> >>>> causes the following compilatation error:
> >>>> LD .tmp_vmlinux1
> >>>> drivers/built-in.o: In function `led_trigger_set':
> >>>> drivers/leds/led-triggers.c:116: undefined reference to
> >>>> `led_brightness_set'
> >>>> make[1]: *** [.tmp_vmlinux1] Error 1
> >>>>
> >>>> AFAICS, led_brightness_set is defined in drivers/leds/led-class.c
> >> which
> >>>> is compiled only if CONFIG_LEDS_CLASS is configured which is not my
> >>>> case (after make oldconfig with all default values from 37-rc1).
> >>>>
> >>>> I am not sure what is the right solution whether
> >> CONFIG_LEDS_TRIGGERS
> >>>> should depend on CONFIG_LEDS_CLASS or the patch should be reverted.
> >>>>
> >>>> My config is attached, if somebody need it.
> >>>
> >>> Hmm, we did find that, and I made a patch to fix up the Kconfig, that
> >> apparently hasn't made it in? Bit confused now.
> >>
> >> Does this mean that I should enable CONFIG_LEDS_CLASS to work around
> >> the issue for this moment?
> >
> > I think that'd be easiest, yes.
>
> I also ran into this today.
> Any updates or pointer to the patch?
Same here - i'm running into this build bug frequently as well, as of 2.6.37-rc3.
Please guys at minimum post the pending fix for this.
Thanks,
Ingo
next prev parent reply other threads:[~2010-11-23 6:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 14:20 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS Michal Hocko
2010-11-16 17:41 ` Berg, Johannes
2010-11-18 8:24 ` Michal Hocko
2010-11-18 16:52 ` Berg, Johannes
2010-11-22 16:58 ` Arnd Hannemann
2010-11-23 6:32 ` Ingo Molnar [this message]
2010-11-23 7:32 ` Berg, Johannes
2010-11-23 7:36 ` Andrew Morton
2010-11-23 7:41 ` Berg, Johannes
2010-11-23 7:44 ` Andrew Morton
2010-11-23 7:57 ` Berg, Johannes
2010-11-23 8:02 ` Ingo Molnar
2010-11-23 7:57 ` Ingo Molnar
2010-11-23 8:02 ` Andrew Morton
2010-11-23 8:09 ` Berg, Johannes
2010-11-23 9:17 ` Ingo Molnar
2010-11-23 9:35 ` Berg, Johannes
2010-11-23 9:59 ` Ingo Molnar
2010-11-23 9:41 ` Johannes Berg
2010-11-29 23:03 ` Andrew Morton
2010-11-30 0:22 ` Randy Dunlap
2010-11-30 11:25 ` Ingo Molnar
2010-11-23 7:44 ` Ingo Molnar
2010-11-23 7:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123063200.GA23907@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndnet.de \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).