linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: [resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable"
Date: Tue, 30 Nov 2010 22:03:43 +0900 (JST)	[thread overview]
Message-ID: <20101130220221.832B.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1011271737110.3764@chino.kir.corp.google.com>

> On Tue, 23 Nov 2010, KOSAKI Motohiro wrote:
> 
> > > > No irrelevant. Your patch break their environment even though
> > > > they don't use oom_adj explicitly. because their application are using it.
> > > > 
> > > 
> > > The _only_ difference too oom_adj since the rewrite is that it is now 
> > > mapped on a linear scale rather than an exponential scale.  
> > 
> > _only_ mean don't ZERO different. Why do userland application need to rewrite?
> > 
> 
> Because NOTHING breaks with the new mapping.  Eight months later since 
> this was initially proposed on linux-mm, you still cannot show a single 
> example that depended on the exponential mapping of oom_adj.  I'm not 
> going to continue responding to your criticism about this point since your 
> argument is completely and utterly baseless.

No regression mean no break. Not single nor multiple. see?


> 
> > Again, IF you need to [0 .. 1000] range, you can calculate it by your
> > application. current oom score can be get from /proc/pid/oom_score and
> > total memory can be get from /proc/meminfo. You shouldn't have break
> > anything.
> > 
> 
> That would require the userspace tunable to be adjusted anytime a task's 
> mempolicy changes, its nodemask changes, it's cpuset attachment changes, 

All situation can be calculated on userland. User process can be know
their bindings.



> its mems change, a memcg limit changes, etc.  The only constant is the 
> task's priority, and the current oom_score_adj implementation preserves 
> that unless explicitly changed later by the user.  I completely understand 
> that you may not have a use for this.




  reply	other threads:[~2010-11-30 13:03 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25  3:26 [resend][PATCH 1/4] oom: remove totalpage normalization from oom_badness() KOSAKI Motohiro
2010-10-25  3:27 ` [resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable" KOSAKI Motohiro
2010-10-25 20:40   ` David Rientjes
2010-10-26 13:01     ` KOSAKI Motohiro
2010-10-26 19:37       ` David Rientjes
2010-11-01  7:06         ` KOSAKI Motohiro
2010-11-01 19:36           ` David Rientjes
2010-11-09  2:26             ` KOSAKI Motohiro
2010-11-09  3:28               ` KOSAKI Motohiro
2010-11-15  0:24                 ` KOSAKI Motohiro
2010-11-15  9:59                   ` David Rientjes
2010-11-09 23:33               ` David Rientjes
2010-11-09 23:35                 ` Alan Cox
2010-11-09 23:48                   ` David Rientjes
2010-11-09 23:55                     ` [patch] oom: document obsolete oom_adj tunable David Rientjes
2010-11-15  0:22                       ` KOSAKI Motohiro
2010-11-15 10:38                         ` David Rientjes
2010-11-23  7:16                           ` KOSAKI Motohiro
2010-11-14  5:07                 ` [resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable" KOSAKI Motohiro
2010-11-14 21:39                   ` David Rientjes
2010-11-23  7:16                     ` KOSAKI Motohiro
2010-11-28  1:41                       ` David Rientjes
2010-11-30 13:03                         ` KOSAKI Motohiro [this message]
2010-11-30 20:07                           ` David Rientjes
2010-10-25  3:28 ` [resend][PATCH 3/4] move cred_guard_mutex from task_struct to signal_struct KOSAKI Motohiro
2010-10-25 17:26   ` Roland McGrath
2010-10-25 17:42     ` Oleg Nesterov
2010-10-25 17:51       ` Roland McGrath
2010-10-26 13:04         ` KOSAKI Motohiro
2010-10-26 13:18           ` Roland McGrath
2010-10-25  3:29 ` [resend][PATCH 4/4] oom: don't ignore rss in nascent mm KOSAKI Motohiro
2010-10-25 11:28   ` pageexec
2010-10-26  7:25     ` KOSAKI Motohiro
2010-11-23 14:34   ` Oleg Nesterov
2010-11-24  0:24     ` KOSAKI Motohiro
2010-11-24 11:09       ` Oleg Nesterov
2010-11-25 11:06         ` KOSAKI Motohiro
2010-11-25 14:02           ` Oleg Nesterov
2010-11-25 19:36             ` Oleg Nesterov
2010-11-29  5:25               ` KOSAKI Motohiro
2010-11-29 11:33                 ` Oleg Nesterov
2010-11-29 18:23                   ` Oleg Nesterov
2010-11-30 19:54                     ` [PATCH 0/2] exec: more excessive argument size fixes for 2.6.37/stable Oleg Nesterov
2010-11-30 19:55                       ` [PATCH 1/2] exec: make argv/envp memory visible to oom-killer Oleg Nesterov
2010-12-01  0:12                         ` KOSAKI Motohiro
2010-12-01 18:07                           ` Oleg Nesterov
2010-11-30 19:56                       ` [PATCH 2/2] exec: copy-and-paste the fixes into compat_do_execve() paths Oleg Nesterov
2010-12-01  3:04                         ` KOSAKI Motohiro
2010-11-30 20:00                       ` [PATCH 0/4] exec: unify compat/non-compat code Oleg Nesterov
2010-11-30 20:00                         ` [PATCH 1/4] exec: introduce get_arg_ptr() helper Oleg Nesterov
2010-11-30 20:01                         ` [PATCH 2/4] exec: introduce "bool compat" argument Oleg Nesterov
2010-11-30 20:01                         ` [PATCH 3/4] exec: unify compat_do_execve() code Oleg Nesterov
2010-12-01 17:37                           ` (No subject header) Milton Miller
2010-12-01 18:27                             ` Oleg Nesterov
2011-02-25 17:52                               ` [PATCH 0/4 RESEND] exec: unify compat/non-compat code Oleg Nesterov
2011-02-25 17:52                                 ` [PATCH 1/5] exec: introduce get_arg_ptr() helper Oleg Nesterov
2011-02-25 17:52                                 ` [PATCH 2/5] exec: introduce "bool compat" argument Oleg Nesterov
2011-02-25 18:57                                   ` Linus Torvalds
2011-02-26 12:37                                     ` Oleg Nesterov
2011-02-25 17:53                                 ` [PATCH 3/5] exec: unify compat_do_execve() code Oleg Nesterov
2011-02-25 19:10                                   ` Linus Torvalds
2011-02-26 12:37                                     ` Oleg Nesterov
2011-02-26 12:57                                       ` Oleg Nesterov
2011-02-26 15:55                                       ` Linus Torvalds
2011-02-26 17:44                                         ` Oleg Nesterov
2011-03-01 20:47                                           ` [PATCH v2 0/5] exec: unify native/compat code Oleg Nesterov
2011-03-01 20:48                                             ` [PATCH v2 1/5] exec: introduce get_arg_ptr() helper Oleg Nesterov
2011-03-01 20:48                                             ` [PATCH v2 2/5] exec: introduce "bool compat" argument Oleg Nesterov
2011-03-01 20:48                                             ` [PATCH v2 3/5] exec: introduce conditional_user_ptr_t Oleg Nesterov
2011-03-01 20:49                                             ` [PATCH v2 4/5] exec: unify do_execve/compat_do_execve code Oleg Nesterov
2011-03-01 20:49                                             ` [PATCH v2 5/5] exec: document acct_arg_size() Oleg Nesterov
2011-03-01 21:39                                             ` [PATCH v2 0/5] exec: unify native/compat code Linus Torvalds
2011-03-02 16:26                                               ` [PATCH v3 0/4] " Oleg Nesterov
2011-03-02 16:27                                                 ` [PATCH v3 1/4] exec: introduce get_arg_ptr() helper Oleg Nesterov
2011-03-03  3:01                                                   ` KOSAKI Motohiro
2011-03-03 15:47                                                     ` Oleg Nesterov
2011-03-03 16:07                                                       ` Linus Torvalds
2011-03-05 20:30                                                         ` [PATCH v4 0/4] exec: unify native/compat code Oleg Nesterov
2011-03-05 20:31                                                           ` [PATCH v4 1/4] exec: introduce get_user_arg_ptr() helper Oleg Nesterov
2011-03-05 20:31                                                           ` [PATCH v4 2/4] exec: introduce struct user_arg_ptr Oleg Nesterov
2011-03-05 20:31                                                           ` [PATCH v4 3/4] exec: unify do_execve/compat_do_execve code Oleg Nesterov
2011-03-05 20:52                                                             ` Linus Torvalds
2011-03-05 21:20                                                               ` Oleg Nesterov
2011-03-05 20:31                                                           ` [PATCH v4 4/4] exec: document acct_arg_size() Oleg Nesterov
2011-03-06 12:04                                                           ` [PATCH v4 0/4] exec: unify native/compat code KOSAKI Motohiro
2011-03-06 17:01                                                             ` [PATCH v5 " Oleg Nesterov
2011-03-06 17:02                                                               ` [PATCH v5 1/4] exec: introduce get_user_arg_ptr() helper Oleg Nesterov
2011-03-06 17:02                                                               ` [PATCH v5 2/4] exec: introduce struct user_arg_ptr Oleg Nesterov
2011-03-06 17:02                                                               ` [PATCH v5 3/4] exec: unify do_execve/compat_do_execve code Oleg Nesterov
2011-03-06 17:03                                                               ` [PATCH v5 4/4] exec: document acct_arg_size() Oleg Nesterov
2011-03-02 16:27                                                 ` [PATCH v3 2/4] exec: introduce struct conditional_ptr Oleg Nesterov
2011-03-03  3:08                                                   ` KOSAKI Motohiro
2011-03-02 16:27                                                 ` [PATCH v3 3/4] exec: unify do_execve/compat_do_execve code Oleg Nesterov
2011-03-03  3:13                                                   ` KOSAKI Motohiro
2011-03-02 16:28                                                 ` [PATCH v3 4/4] exec: document acct_arg_size() Oleg Nesterov
2011-03-03  3:09                                                   ` KOSAKI Motohiro
2011-03-02 16:44                                                 ` [PATCH v3 0/4] exec: unify native/compat code Oleg Nesterov
2011-03-02 18:00                                                   ` Linus Torvalds
2011-03-02 19:40                                                     ` David Miller
2011-03-02 19:48                                                       ` Linus Torvalds
2011-03-02 19:54                                                         ` David Miller
2011-02-25 17:53                                 ` [PATCH 4/5] exec: unexport acct_arg_size() and get_arg_page() Oleg Nesterov
2011-02-25 17:54                                 ` [PATCH 5/5] exec: document acct_arg_size() Oleg Nesterov
2011-02-25 18:54                                 ` [PATCH 0/4 RESEND] exec: unify compat/non-compat code Linus Torvalds
2011-02-26 12:35                                   ` Oleg Nesterov
2010-11-30 20:01                         ` [PATCH 4/4] exec: unexport acct_arg_size() and get_arg_page() Oleg Nesterov
2010-12-01  3:09                         ` [PATCH 0/4] exec: unify compat/non-compat code KOSAKI Motohiro
2010-11-30  0:06                   ` [resend][PATCH 4/4] oom: don't ignore rss in nascent mm KOSAKI Motohiro
2010-10-25 20:37 ` [resend][PATCH 1/4] oom: remove totalpage normalization from oom_badness() David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101130220221.832B.A69D9226@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).