From: Jeff Layton <jlayton@samba.org>
To: Bernhard Walle <bernhard@bwalle.de>
Cc: sfrench@samba.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: Add information about noserverino
Date: Mon, 6 Dec 2010 09:57:25 -0500 [thread overview]
Message-ID: <20101206095725.78422138@tlielax.poochiereds.net> (raw)
In-Reply-To: <1291568855-22604-1-git-send-email-bernhard@bwalle.de>
On Sun, 5 Dec 2010 18:07:35 +0100
Bernhard Walle <bernhard@bwalle.de> wrote:
> In my case I had the problem that 32 bit userspace applications in an
> amd64 environment was not able to list the directories of a CIFS-mounted
> share. The simple userspace code
>
> int main(int argc, char *argv[])
> {
> DIR *dir;
> struct dirent *dirent;
>
> if (!argv[1]) {
> fprintf(stderr, "Usage: %s <directory>\n", argv[0]);
> return -1;
> }
>
> dir = opendir(argv[1]);
> if (!dir) {
> perror("Unable to open directory");
> return -1;
> }
>
> while ((dirent = readdir(dir)) != NULL)
> puts(dirent->d_name);
>
> closedir(dir);
>
> return 0;
> }
>
> was sufficient to trigger the problem.
>
> I discovered that the problem was that the inodes were too large to fit
> in a 32 bit (unsigned long) integer, so the compat_filldir() function
> returned -EOVERFLOW.
>
> While that is okay it would have saved me a some hours of debugging if
> the message below would have appeared in my kernel log.
>
> The target was a Samba server (I guess) of a Buffalo LinkStation Duo
> with the unmodified vendor firmware 1.34.
>
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
> fs/cifs/readdir.c | 23 +++++++++++++++++++----
> 1 files changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
> index d5e591f..d979826 100644
> --- a/fs/cifs/readdir.c
> +++ b/fs/cifs/readdir.c
> @@ -773,6 +773,7 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir)
> char *tmp_buf = NULL;
> char *end_of_smb;
> unsigned int max_len;
> + int err;
>
> xid = GetXid();
>
> @@ -783,17 +784,31 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir)
>
> switch ((int) file->f_pos) {
> case 0:
> - if (filldir(direntry, ".", 1, file->f_pos,
> - file->f_path.dentry->d_inode->i_ino, DT_DIR) < 0) {
> + err = filldir(direntry, ".", 1, file->f_pos,
> + file->f_path.dentry->d_inode->i_ino, DT_DIR);
> + if (err < 0) {
> cERROR(1, "Filldir for current dir failed");
> + if (err == -EOVERFLOW) {
> + cERROR(1, "Server inodes are too large for 32 "
> + "bit userspace. You might "
> + "consider using 'noserverino' "
> + "mount option for this mount.");
> + }
> rc = -ENOMEM;
> break;
> }
> file->f_pos++;
> case 1:
> - if (filldir(direntry, "..", 2, file->f_pos,
> - file->f_path.dentry->d_parent->d_inode->i_ino, DT_DIR) < 0) {
> + err = filldir(direntry, "..", 2, file->f_pos,
> + file->f_path.dentry->d_parent->d_inode->i_ino, DT_DIR);
> + if (err < 0) {
> cERROR(1, "Filldir for parent dir failed");
> + if (err == -EOVERFLOW) {
> + cERROR(1, "Server inodes are too large for 32 "
> + "bit userspace. You might "
> + "consider using 'noserverino' "
> + "mount option for this mount.");
> + }
> rc = -ENOMEM;
> break;
> }
This doesn't look right to me...
i_ino is an unsigned long. The code in filldir() is this:
unsigned long d_ino;
[...]
d_ino = ino;
if (sizeof(d_ino) < sizeof(ino) && d_ino != ino) {
buf->error = -EOVERFLOW;
return -EOVERFLOW;
}
...so the first condition will return true on a 32-bit arch, but it's
not clear to me how you'd get the second one to return true in this
situation.
--
Jeff Layton <jlayton@samba.org>
next prev parent reply other threads:[~2010-12-06 14:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 17:07 [PATCH] cifs: Add information about noserverino Bernhard Walle
2010-12-06 6:57 ` Suresh Jayaraman
2010-12-06 14:57 ` Jeff Layton [this message]
2010-12-06 15:11 ` Bernhard Walle
2010-12-06 15:12 ` Jeff Layton
2010-12-06 15:35 ` Bernhard Walle
2010-12-06 15:38 ` Jeff Layton
2010-12-09 11:40 ` Suresh Jayaraman
2010-12-09 12:09 ` Jeff Layton
2010-12-09 18:26 ` Steve French
2010-12-09 19:34 ` Jeff Layton
2010-12-09 20:44 ` Steve French
2010-12-09 20:56 ` Jeff Layton
2010-12-10 3:09 ` Suresh Jayaraman
2010-12-10 4:58 ` Steve French
2010-12-10 11:05 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206095725.78422138@tlielax.poochiereds.net \
--to=jlayton@samba.org \
--cc=bernhard@bwalle.de \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).