From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: "rydberg@euromail.se" <rydberg@euromail.se>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices
Date: Fri, 17 Dec 2010 20:23:21 -0800 [thread overview]
Message-ID: <20101218042320.GA14104@ericsson.com> (raw)
In-Reply-To: <1292624661-32474-1-git-send-email-mjg@redhat.com>
On Fri, Dec 17, 2010 at 05:24:20PM -0500, Matthew Garrett wrote:
> The AppleSMC device is described in ACPI, including a list of its resources.
> We should use those rather than hardcoding the ports. A side-effect is that
> we can then remove the DMI matching, since there's a unique identifier to
> indicate that the machine has one of these devices.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
You added a whitespace error, and kfree() is safe and doesn't need a check.
I fixed those, so no need to resubmit. If Henrik gives his Ack we are ready to go.
Guenter
next prev parent reply other threads:[~2010-12-18 4:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 15:33 [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Matthew Garrett
2010-12-16 15:33 ` [PATCH 2/2] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-16 16:48 ` [PATCH 1/2] applesmc: Use PnP rather than hardcoding resources and devices Henrik Rydberg
2010-12-16 17:00 ` Matthew Garrett
2010-12-16 17:00 ` [lm-sensors] " Guenter Roeck
2010-12-17 21:57 ` Matthew Garrett
2010-12-17 21:58 ` Matthew Garrett
2010-12-17 22:16 ` Guenter Roeck
2010-12-17 22:22 ` Matthew Garrett
2010-12-17 22:24 ` [PATCH 1/2 V3] " Matthew Garrett
2010-12-18 4:23 ` Guenter Roeck [this message]
2010-12-18 9:07 ` Henrik Rydberg
2010-12-18 14:40 ` Matthew Garrett
2010-12-18 15:31 ` Henrik Rydberg
2010-12-18 9:37 ` Henrik Rydberg
2010-12-18 10:09 ` [lm-sensors] " Jean Delvare
2010-12-18 10:31 ` Henrik Rydberg
2010-12-18 11:29 ` Julien BLACHE
2010-12-18 11:57 ` Henrik Rydberg
2010-12-20 13:44 ` Mikael Ström
2010-12-20 13:57 ` Jean Delvare
2010-12-20 14:23 ` Henrik Rydberg
2010-12-20 14:28 ` Matthew Garrett
2010-12-20 15:06 ` Henrik Rydberg
2010-12-20 15:12 ` Matthew Garrett
2010-12-20 15:37 ` Henrik Rydberg
2010-12-20 14:00 ` Matthew Garrett
2010-12-21 6:04 ` Mikael Ström
2010-12-21 11:09 ` Julien BLACHE
2010-12-18 14:43 ` Matthew Garrett
2010-12-18 15:30 ` Henrik Rydberg
2010-12-18 15:39 ` Matthew Garrett
2010-12-17 22:24 ` [PATCH 2/2 V3] applesmc: Perform some more sanity checking on temperatures Matthew Garrett
2010-12-17 21:58 ` [PATCH 2/2] " Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218042320.GA14104@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mjg@redhat.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).