* linux-next: build warnings after merge of the fsinfo tree
@ 2020-08-04 7:34 Stephen Rothwell
2020-08-04 8:10 ` David Howells
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-08-04 7:34 UTC (permalink / raw)
To: David Howells; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]
Hi all,
After merging the fsinfo tree, today's linux-next build (powerpc
allyesconfig) produced these warnings:
samples/vfs/test-mntinfo.c: In function 'display_mount':
samples/vfs/test-mntinfo.c:146:19: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type '__u64' {aka 'long unsigned int'} [-Wformat=]
146 | printf("%10u %8llx %2x %x %5s %s",
| ~~~~^
| |
| long long unsigned int
| %8lx
147 | info.mnt_id,
148 | (info.mnt_attr_changes +
| ~~~~~~~~~~~~~~~~~~~~~~~~
149 | info.mnt_topology_changes +
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| __u64 {aka long unsigned int}
150 | info.mnt_subtree_notifications),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
samples/vfs/test-fsinfo.c: In function 'dump_fsinfo_generic_mount_all':
samples/vfs/test-fsinfo.c:384:30: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 5 has type '__u64' {aka 'long unsigned int'} [-Wformat=]
384 | printf("%5x %5x %12llx %10llu %s\n",
| ~~~~~^
| |
| long long unsigned int
| %10lu
385 | r->mnt_id, r->parent_id, (unsigned long long)r->mnt_unique_id,
386 | r->mnt_notify_sum, mp);
| ~~~~~~~~~~~~~~~~~
| |
| __u64 {aka long unsigned int}
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings after merge of the fsinfo tree
2020-08-04 7:34 linux-next: build warnings after merge of the fsinfo tree Stephen Rothwell
@ 2020-08-04 8:10 ` David Howells
0 siblings, 0 replies; 5+ messages in thread
From: David Howells @ 2020-08-04 8:10 UTC (permalink / raw)
To: Stephen Rothwell
Cc: dhowells, Linux Next Mailing List, Linux Kernel Mailing List
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> After merging the fsinfo tree, today's linux-next build (powerpc
> allyesconfig) produced these warnings:
>
> samples/vfs/test-mntinfo.c: In function 'display_mount':
> samples/vfs/test-mntinfo.c:146:19: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type '__u64' {aka 'long unsigned int'} [-Wformat=]
...
I've appended a patch for that.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings after merge of the fsinfo tree
2020-05-28 10:11 ` Stephen Rothwell
@ 2020-05-28 13:44 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2020-05-28 13:44 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Jens Axboe, David Howells, Linux Next Mailing List,
Linux Kernel Mailing List, Christoph Hellwig
On Thu, May 28, 2020 at 08:11:04PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> This should have been the block tree, not the fsinfo tree, of course.
Fix sent to Jens and the linux-block list, thanks for the report.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings after merge of the fsinfo tree
2020-05-28 8:40 Stephen Rothwell
@ 2020-05-28 10:11 ` Stephen Rothwell
2020-05-28 13:44 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-05-28 10:11 UTC (permalink / raw)
To: Jens Axboe
Cc: David Howells, Linux Next Mailing List,
Linux Kernel Mailing List, Christoph Hellwig
[-- Attachment #1: Type: text/plain, Size: 9744 bytes --]
Hi all,
This should have been the block tree, not the fsinfo tree, of course.
On Thu, 28 May 2020 18:40:17 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the fsinfo tree, today's linux-next build (x86_64
> allnoconfig) produced these warnings:
>
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/loadavg.c:9:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from fs/super.c:26:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/clock.c:56:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/idle.c:9:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/cputime.c:5:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/rt.c:6:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/core.c:9:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/swait.c:5:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/wait_bit.c:5:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/fair.c:23:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/wait.c:7:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/deadline.c:18:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from kernel/sched/sched.h:39,
> from kernel/sched/completion.c:14:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
> In file included from fs/libfs.c:7:
> include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
> | ^~~~~~~
> include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
> 1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> | ^~~~~~~
>
> Introduced by commit
>
> 956d510ee78c ("block: add disk/bio-based accounting helpers")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: build warnings after merge of the fsinfo tree
@ 2020-05-28 8:40 Stephen Rothwell
2020-05-28 10:11 ` Stephen Rothwell
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-05-28 8:40 UTC (permalink / raw)
To: David Howells
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Christoph Hellwig
[-- Attachment #1: Type: text/plain, Size: 9351 bytes --]
Hi all,
After merging the fsinfo tree, today's linux-next build (x86_64
allnoconfig) produced these warnings:
In file included from kernel/sched/sched.h:39,
from kernel/sched/loadavg.c:9:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from fs/super.c:26:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/clock.c:56:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/idle.c:9:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/cputime.c:5:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/rt.c:6:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/core.c:9:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/swait.c:5:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/wait_bit.c:5:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/fair.c:23:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/wait.c:7:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/deadline.c:18:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from kernel/sched/sched.h:39,
from kernel/sched/completion.c:14:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
In file included from fs/libfs.c:7:
include/linux/blkdev.h:1895:41: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1895 | unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors,
| ^~~~~~~
include/linux/blkdev.h:1897:30: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
1897 | void disk_end_io_acct(struct gendisk *disk, unsigned int op,
| ^~~~~~~
Introduced by commit
956d510ee78c ("block: add disk/bio-based accounting helpers")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-04 8:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 7:34 linux-next: build warnings after merge of the fsinfo tree Stephen Rothwell
2020-08-04 8:10 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2020-05-28 8:40 Stephen Rothwell
2020-05-28 10:11 ` Stephen Rothwell
2020-05-28 13:44 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).