linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>,
	Nicholas Bellinger <nab@linux-iscsi.org>,
	James Bottomley <James.Bottomley@suse.de>,
	Randy Dunlap <randy.dunlap@oracle.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: netconsole build breakage (Re: [GIT] Networking)
Date: Wed, 19 Jan 2011 10:59:20 +0100	[thread overview]
Message-ID: <20110119095920.GA10543@elte.hu> (raw)
In-Reply-To: <20110114.130323.201674039.davem@davemloft.net>


FYI, there's a .38-rc1 build failure that triggers rather often:

 drivers/built-in.o: In function `drop_netconsole_target':
 netconsole.c:(.text+0x130146): undefined reference to `config_item_put'
 drivers/built-in.o: In function `write_msg':
 netconsole.c:(.text+0x1301aa): undefined reference to `config_item_get'
 netconsole.c:(.text+0x130217): undefined reference to `config_item_put'
 drivers/built-in.o: In function `netconsole_netdev_event':
 netconsole.c:(.text+0x1302ab): undefined reference to `config_item_get'
 ...

Triggered by this configuration:

 CONFIG_CONFIGFS_FS=m
 CONFIG_NETCONSOLE=y

Probably caused by:

 d9f9ab51e55e: net: Make NETCONSOLE_DYNAMIC depend on CONFIGFS_FS

The commit appears to have gone upstream via the iscsi tree. The commit is going in 
the wrong direction as well, beyond being buggy.

The original problem was caused by this iscsi commit:

 e205117285d6: configfs: change depends -> select SYSFS

and the dependency problems snowballed from there, and one side-effect was patched 
up - but others remain.

Thanks,

	Ingo

  reply	other threads:[~2011-01-19  9:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14 21:03 [GIT] Networking David Miller
2011-01-19  9:59 ` Ingo Molnar [this message]
2011-01-19 10:08   ` netconsole build breakage (Re: [GIT] Networking) Américo Wang
2011-01-19 10:33     ` Nicholas A. Bellinger
2011-01-19 10:57       ` Ingo Molnar
2011-01-27 15:51       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110119095920.GA10543@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).