From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, Michael J Wolf <mjwolf@us.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFC][PATCH 5/6] teach smaps_pte_range() about THP pmds
Date: Mon, 31 Jan 2011 16:34:03 -0800 [thread overview]
Message-ID: <20110201003403.736A24DF@kernel> (raw)
In-Reply-To: <20110201003357.D6F0BE0D@kernel>
This adds code to explicitly detect and handle
pmd_trans_huge() pmds. It then passes HPAGE_SIZE units
in to the smap_pte_entry() function instead of PAGE_SIZE.
This means that using /proc/$pid/smaps now will no longer
cause THPs to be broken down in to small pages.
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---
linux-2.6.git-dave/fs/proc/task_mmu.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff -puN fs/proc/task_mmu.c~teach-smaps_pte_range-about-thp-pmds fs/proc/task_mmu.c
--- linux-2.6.git/fs/proc/task_mmu.c~teach-smaps_pte_range-about-thp-pmds 2011-01-31 15:10:55.387856566 -0800
+++ linux-2.6.git-dave/fs/proc/task_mmu.c 2011-01-31 15:25:12.231239775 -0800
@@ -1,5 +1,6 @@
#include <linux/mm.h>
#include <linux/hugetlb.h>
+#include <linux/huge_mm.h>
#include <linux/mount.h>
#include <linux/seq_file.h>
#include <linux/highmem.h>
@@ -385,6 +386,17 @@ static int smaps_pte_range(pmd_t *pmd, u
pte_t *pte;
spinlock_t *ptl;
+ if (pmd_trans_huge(*pmd)) {
+ if (pmd_trans_splitting(*pmd)) {
+ spin_unlock(&walk->mm->page_table_lock);
+ wait_split_huge_page(vma->anon_vma, pmd);
+ spin_lock(&walk->mm->page_table_lock);
+ goto normal_ptes;
+ }
+ smaps_pte_entry(*(pte_t *)pmd, addr, HPAGE_SIZE, walk);
+ return 0;
+ }
+normal_ptes:
split_huge_page_pmd(walk->mm, pmd);
pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl);
diff -puN mm/vmscan.c~teach-smaps_pte_range-about-thp-pmds mm/vmscan.c
diff -puN include/trace/events/vmscan.h~teach-smaps_pte_range-about-thp-pmds include/trace/events/vmscan.h
diff -puN mm/pagewalk.c~teach-smaps_pte_range-about-thp-pmds mm/pagewalk.c
diff -puN mm/huge_memory.c~teach-smaps_pte_range-about-thp-pmds mm/huge_memory.c
diff -puN mm/memory.c~teach-smaps_pte_range-about-thp-pmds mm/memory.c
diff -puN include/linux/huge_mm.h~teach-smaps_pte_range-about-thp-pmds include/linux/huge_mm.h
diff -puN mm/internal.h~teach-smaps_pte_range-about-thp-pmds mm/internal.h
_
next prev parent reply other threads:[~2011-02-01 0:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 0:33 [RFC][PATCH 0/6] more detailed per-process transparent hugepage statistics Dave Hansen
2011-02-01 0:33 ` [RFC][PATCH 1/6] count transparent hugepage splits Dave Hansen
2011-02-01 9:58 ` Johannes Weiner
2011-02-03 21:22 ` David Rientjes
2011-02-04 21:18 ` Andrea Arcangeli
2011-02-04 21:28 ` Dave Hansen
2011-02-01 0:33 ` [RFC][PATCH 2/6] pagewalk: only split huge pages when necessary Dave Hansen
2011-02-01 10:04 ` Johannes Weiner
2011-02-01 15:03 ` Dave Hansen
2011-02-03 21:22 ` David Rientjes
2011-02-03 21:33 ` Dave Hansen
2011-02-03 21:46 ` David Rientjes
2011-02-04 17:19 ` Dave Hansen
2011-02-04 21:10 ` Andrea Arcangeli
2011-02-01 0:34 ` [RFC][PATCH 3/6] break out smaps_pte_entry() from smaps_pte_range() Dave Hansen
2011-02-01 10:08 ` Johannes Weiner
2011-02-03 21:22 ` David Rientjes
2011-02-03 21:40 ` Dave Hansen
2011-02-01 0:34 ` [RFC][PATCH 4/6] pass pte size argument in to smaps_pte_entry() Dave Hansen
2011-02-01 10:09 ` Johannes Weiner
2011-02-03 21:22 ` David Rientjes
2011-02-01 0:34 ` Dave Hansen [this message]
2011-02-01 10:11 ` [RFC][PATCH 5/6] teach smaps_pte_range() about THP pmds Johannes Weiner
2011-02-01 15:02 ` Dave Hansen
2011-02-01 16:09 ` Andrea Arcangeli
2011-02-03 21:22 ` David Rientjes
2011-02-03 21:34 ` Dave Hansen
2011-02-01 0:34 ` [RFC][PATCH 6/6] have smaps show transparent huge pages Dave Hansen
2011-02-01 10:12 ` Johannes Weiner
2011-02-03 21:22 ` David Rientjes
2011-02-01 15:38 ` [RFC][PATCH 0/6] more detailed per-process transparent hugepage statistics Andrea Arcangeli
2011-02-01 17:15 ` Dave Hansen
2011-02-01 20:39 ` Andrea Arcangeli
2011-02-01 20:56 ` Dave Hansen
2011-02-02 0:07 ` Andrea Arcangeli
2011-02-08 17:54 ` Dave Hansen
2011-02-08 18:17 ` Andrea Arcangeli
2011-02-03 21:54 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201003403.736A24DF@kernel \
--to=dave@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjwolf@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).