From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755796Ab1BCEpc (ORCPT ); Wed, 2 Feb 2011 23:45:32 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:40105 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755644Ab1BCEpb (ORCPT ); Wed, 2 Feb 2011 23:45:31 -0500 Date: Wed, 02 Feb 2011 20:46:06 -0800 (PST) Message-Id: <20110202.204606.226770967.davem@davemloft.net> To: sfr@canb.auug.org.au Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the final tree (net tree related) From: David Miller In-Reply-To: <20110203151309.d4a6c344.sfr@canb.auug.org.au> References: <20110203151309.d4a6c344.sfr@canb.auug.org.au> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Rothwell Date: Thu, 3 Feb 2011 15:13:09 +1100 > Hi all, > > After merging the final tree, today's linux-next build (sparc32 defconfig) > failed like this: > > net/ipv4/fib_trie.c:98: error: redefinition of 'struct node' > > Probably exposed by commit 3630b7c050d9c3564f143d595339fc06b888d6f3 > ("ipv4: Remove fib_hash"). > > Naming a struct "node" (in the face of include/linux/node.h) is a bit > hopeful. :-) > > I have left this broken for now ... This problem has existed forever, you just have only been testing the build with fib_hash enabled instead of fib_trie. I'm really surprised this has never been hit before. :-) I'll fix it up, thanks for the report.