From: jacob pan <jacob.jun.pan@linux.intel.com>
To: "Kirill A. Shutsemov" <kirill@shutemov.name>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
containers@lists.linux-foundation.org,
Arjan van de Ven <arjan@linux.intel.com>,
linux-kernel@vger.kernel.org, Matt Helsley <matthltc@us.ibm.com>
Subject: Re: [PATCH, v3 2/2] cgroups: introduce timer slack subsystem
Date: Wed, 2 Feb 2011 14:56:05 -0800 [thread overview]
Message-ID: <20110202145605.6c9006fa@putvin> (raw)
In-Reply-To: <1296679656-31163-3-git-send-email-kirill@shutemov.name>
On Wed, 2 Feb 2011 22:47:36 +0200
"Kirill A. Shutsemov" <kirill@shutemov.name> wrote:
> From: Kirill A. Shutemov <kirill@shutemov.name>
>
> Provides a way of tasks grouping by timer slack value. Introduces per
> cgroup max and min timer slack value. When a task attaches to a
> cgroup, its timer slack value adjusts (if needed) to fit min-max
> range.
>
> It also provides a way to set timer slack value for all tasks in the
> cgroup at once.
>
> This functionality is useful in mobile devices where certain
> background apps are attached to a cgroup and minimum wakeups are
> desired.
>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> Idea-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
> include/linux/cgroup_subsys.h | 6 +
> include/linux/init_task.h | 4 +-
> init/Kconfig | 10 ++
> kernel/Makefile | 1 +
> kernel/cgroup_timer_slack.c | 242
> +++++++++++++++++++++++++++++++++++++++++
> +
> +static int cgroup_timer_slack_check(struct task_struct *task,
> + unsigned long slack_ns)
> +{
> + struct cgroup_subsys_state *css;
> + struct timer_slack_cgroup *tslack_cgroup;
> +
use rcu_read_lock()/unlock?
lockdep complains unprotected rcu dereference check.
> + css = task_subsys_state(task, timer_slack_subsys.subsys_id);
> + tslack_cgroup = container_of(css, struct timer_slack_cgroup,
> css); +
> + if (slack_ns < tslack_cgroup->min_slack_ns)
> + return -EPERM;
> + if (slack_ns > tslack_cgroup->max_slack_ns)
> + return -EPERM;
> + return 0;
> +}
> +
> +
> +static struct cftype files[] = {
> + {
> + .name = "set_slack_ns",
> + .write_u64 = tslack_write_set_slack_ns,
> + },
should we also allow reading of the current slack_ns?
> + {
> + .name = "min_slack_ns",
> + .private = TIMER_SLACK_MIN,
> + .read_u64 = tslack_read_range,
> + .write_u64 = tslack_write_range,
> + },
> + {
> + .name = "max_slack_ns",
> + .private = TIMER_SLACK_MAX,
> + .read_u64 = tslack_read_range,
> + .write_u64 = tslack_write_range,
> + },
> +};
> +
next prev parent reply other threads:[~2011-02-02 22:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 20:47 [PATCH, v3 0/2] Timer slack cgroup subsystem Kirill A. Shutsemov
2011-02-02 20:47 ` [PATCH, v3 1/2] cgroups: export cgroup_iter_{start,next,end} Kirill A. Shutsemov
2011-02-02 21:21 ` Paul Menage
2011-02-02 20:47 ` [PATCH, v3 2/2] cgroups: introduce timer slack subsystem Kirill A. Shutsemov
2011-02-02 22:56 ` jacob pan [this message]
2011-02-03 9:22 ` Kirill A. Shutemov
2011-02-03 17:51 ` Jacob Pan
2011-02-03 18:12 ` Paul Menage
2011-02-03 19:57 ` Jacob Pan
2011-02-04 13:34 ` Kirill A. Shutemov
2011-02-04 17:27 ` Jacob Pan
2011-02-07 0:33 ` Matt Helsley
2011-02-07 11:06 ` Kirill A. Shutemov
2011-02-07 17:20 ` Jacob Pan
2011-02-07 18:32 ` Kirill A. Shutemov
2011-02-02 23:23 ` Paul Menage
2011-02-03 5:48 ` Matt Helsley
2011-02-03 9:28 ` Kirill A. Shutemov
2011-02-03 5:46 ` Matt Helsley
2011-02-03 9:41 ` Kirill A. Shutemov
2011-02-06 2:49 ` Matt Helsley
2011-02-07 9:48 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202145605.6c9006fa@putvin \
--to=jacob.jun.pan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=containers@lists.linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=matthltc@us.ibm.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).