From: David Miller <davem@davemloft.net>
To: hagen@jauu.net
Cc: sledz@dresearch.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net,
m.schuknecht@dresearch.de
Subject: Re: [PATCH v3] tcp: ioctl type SIOCOUTQNSD returns amount of data not sent
Date: Thu, 10 Mar 2011 14:16:05 -0800 (PST) [thread overview]
Message-ID: <20110310.141605.189705143.davem@davemloft.net> (raw)
In-Reply-To: <20110310221205.GF3121@nuttenaction>
From: Hagen Paul Pfeifer <hagen@jauu.net>
Date: Thu, 10 Mar 2011 23:12:05 +0100
> * David Miller | 2011-03-09 14:09:51 [-0800]:
>
>>From: Steffen Sledz <sledz@dresearch.de>
>>Date: Sun, 6 Mar 2011 20:59:55 +0100
>>
>>> From: Mario Schuknecht <m.schuknecht@dresearch.de>
>>>
>>> In contrast to SIOCOUTQ which returns the amount of data sent
>>> but not yet acknowledged plus data not yet sent this patch only
>>> returns the data not sent.
>>>
>>> For various methods of live streaming bitrate control it may
>>> be helpful to know how much data are in the tcp outqueue are
>>> not sent yet.
>>>
>>> Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
>>> Signed-off-by: Steffen Sledz <sledz@dresearch.de>
>>
>>Applied, thanks.
>
> A little bit late - but why not using struct tcp_info for that? The
> information is already provided via getsockopt(TCP_INFO).
It's pretty heavy handed to copy that entire TCP_INFO struct into
userspace during every I/O sequence the application makes.
prev parent reply other threads:[~2011-03-10 22:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 8:48 [PATCH resent] tcp: ioctl type SIOCOUTQNSD returns amount of data not sent Steffen Sledz
2011-03-04 9:04 ` David Miller
2011-03-04 9:51 ` Steffen Sledz
2011-03-04 9:57 ` Arnd Bergmann
2011-03-04 10:20 ` [PATCH v2] " Steffen Sledz
2011-03-04 12:26 ` Steffen Sledz
2011-03-04 12:39 ` Alan Cox
2011-03-06 19:59 ` [PATCH v3] " Steffen Sledz
2011-03-08 11:57 ` Steffen Sledz
2011-03-08 18:48 ` David Miller
2011-03-09 22:09 ` David Miller
2011-03-10 22:12 ` Hagen Paul Pfeifer
2011-03-10 22:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310.141605.189705143.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hagen@jauu.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=m.schuknecht@dresearch.de \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=sledz@dresearch.de \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).