From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756216Ab1CVBRl (ORCPT ); Mon, 21 Mar 2011 21:17:41 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37977 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755227Ab1CVBRi (ORCPT ); Mon, 21 Mar 2011 21:17:38 -0400 Date: Mon, 21 Mar 2011 18:18:16 -0700 (PDT) Message-Id: <20110321.181816.15242871.davem@davemloft.net> To: arnd@arndb.de Cc: eric.dumazet@gmail.com, mingo@elte.hu, torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, tglx@linutronix.de Subject: Re: [held lock freed] Re: [GIT] Networking From: David Miller In-Reply-To: <201103211622.40851.arnd@arndb.de> References: <201103211550.10694.arnd@arndb.de> <1300719332.2884.370.camel@edumazet-laptop> <201103211622.40851.arnd@arndb.de> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 21 Mar 2011 16:22:40 +0100 > net/appletalk: fix atalk_release use after free > > The BKL removal in appletalk introduced a use-after-free problem, > where atalk_destroy_socket frees a sock, but we still release > the socket lock on it. > > An easy fix is to take an extra reference on the sock and sock_put > it when returning from atalk_release. > > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.