From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Prasad Joshi <prasadjoshi124@gmail.com>
Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
mitra@kqinfotech.com
Subject: Re: [RFC][PATCH v3 09/22] mm, s390: add gfp flags variant of pud, pte, and pte allocations
Date: Tue, 22 Mar 2011 08:56:24 +0100 [thread overview]
Message-ID: <20110322085624.6a7efecf@mschwide.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20110321190239.GA6541@prasad-kvm>
On Mon, 21 Mar 2011 19:02:39 +0000
Prasad Joshi <prasadjoshi124@gmail.com> wrote:
> On Mon, Mar 21, 2011 at 09:34:12AM +0100, Martin Schwidefsky wrote:
> > On Fri, 18 Mar 2011 19:56:44 +0000
> > Prasad Joshi <prasadjoshi124@gmail.com> wrote:
> >
> > > - Added function __crst_table_alloc() which is similar to crst_table_alloc()
> > > but accepts an extra argument gfp_t. The function uses given allocation
> > > flag to allocate pages.
> > >
> > > - Added a function __page_table_alloc() to allocate page table entries. This
> > > function is allows caller to specify the page allocation flag. The
> > > allocation flag is then passed to alloc_page(). The rest of the function is
> > > copy of the original page_table_alloc().
> >
> > The approach of this patch series seems straightforward, the only nitpick I
> > have is the fact that two new functions __crst_table_alloc/__page_table_alloc
> > are introduced. There aren't many call sites for the two original functions,
> > namely 4 for crst_table_alloc and 3 for page_table_alloc. Why not add the
> > gfp flag GFP_KERNEL to these call sites? Then the two additional functions
> > would not be needed.
>
> Thanks a lot Martin for your reply. Here is a new patch, which the changes
> you suggested.
Looks good now. For the s390 architecture part:
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2011-03-22 7:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 19:41 [RFC][PATCH v3 00/22] __vmalloc: Propagating GFP allocation flag inside __vmalloc() Prasad Joshi
2011-03-18 19:43 ` [RFC][PATCH v3 01/22] mm: " Prasad Joshi
2011-03-18 19:46 ` [RFC][PATCH v3 02/22] mm, xtensa: add gfp flags variant of pte allocations Prasad Joshi
2011-03-18 19:47 ` [RFC][PATCH v3 03/22] mm, x86: add gfp flags variant of pud, pmd, and " Prasad Joshi
2011-03-18 19:49 ` [RFC][PATCH v3 04/22] mm, um: add gfp flags variant of pmd " Prasad Joshi
2011-03-18 19:50 ` [RFC][PATCH v3 05/22] mm, tile: " Prasad Joshi
2011-03-18 19:51 ` [RFC][PATCH v3 06/22] mm, sparc: " Prasad Joshi
2011-03-18 19:53 ` [RFC][PATCH v3 07/22] mm, sh: " Prasad Joshi
2011-03-18 19:55 ` [RFC][PATCH v3 08/22] mm, score: add gfp flags variant of " Prasad Joshi
2011-03-18 19:56 ` [RFC][PATCH v3 09/22] mm, s390: add gfp flags variant of pud, pte, and " Prasad Joshi
2011-03-18 19:57 ` [RFC][PATCH v3 10/22] mm, powerpc: " Prasad Joshi
2011-03-18 19:59 ` [RFC][PATCH v3 11/22] mm, parisc: add gfp flags variant of pmd " Prasad Joshi
2011-03-18 20:00 ` [RFC][PATCH v3 12/22] mm, mn10300: add gfp flags variant of " Prasad Joshi
2011-03-18 20:01 ` [RFC][PATCH v3 13/22] mm, mips: add gfp flags variant of pmd and " Prasad Joshi
2011-03-18 20:02 ` [RFC][PATCH v3 14/22] mm, microblaze: " Prasad Joshi
2011-03-18 20:04 ` [RFC][PATCH v3 15/22] mm, m68k: " Prasad Joshi
2011-03-18 20:04 ` [RFC][PATCH v3 16/22] mm, m32r: " Prasad Joshi
2011-03-18 20:05 ` [RFC][PATCH v3 17/22] mm, ia64: add gfp flags variant of pud, " Prasad Joshi
2011-03-18 20:06 ` [RFC][PATCH v3 18/22] mm, frv: " Prasad Joshi
2011-03-18 20:07 ` [RFC][PATCH v3 19/22] mm, cris: add gfp flags variant of " Prasad Joshi
2011-03-18 20:08 ` [RFC][PATCH v3 20/22] mm, avr32: " Prasad Joshi
2011-03-18 20:09 ` [RFC][PATCH v3 21/22] mm, arm: add gfp flags variant of pmd and " Prasad Joshi
2011-03-18 20:10 ` [RFC][PATCH v3 22/22] mm, alpha: " Prasad Joshi
2011-03-21 8:34 ` [RFC][PATCH v3 09/22] mm, s390: add gfp flags variant of pud, pte, " Martin Schwidefsky
2011-03-21 19:02 ` Prasad Joshi
2011-03-22 7:56 ` Martin Schwidefsky [this message]
2011-03-22 14:42 ` [RFC][PATCH v3 07/22] mm, sh: add gfp flags variant of pmd " Paul Mundt
[not found] ` <4D83B7F2.4000903@tilera.com>
2011-03-18 20:12 ` [RFC][PATCH v3 05/22] mm, tile: " Prasad Joshi
2011-03-18 22:17 ` [RFC][PATCH v3 03/22] mm, x86: add gfp flags variant of pud, pmd, " David Rientjes
2011-03-21 19:05 ` Prasad Joshi
2011-03-21 20:15 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322085624.6a7efecf@mschwide.boeblingen.de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mitra@kqinfotech.com \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).