From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755975Ab1CWKAG (ORCPT ); Wed, 23 Mar 2011 06:00:06 -0400 Received: from linux-sh.org ([111.68.239.195]:43193 "EHLO linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519Ab1CWKAD (ORCPT ); Wed, 23 Mar 2011 06:00:03 -0400 Date: Wed, 23 Mar 2011 18:59:20 +0900 From: Paul Mundt To: "Rafael J. Wysocki" Cc: LKML , Greg KH , Kay Sievers , Linux PM mailing list , Russell King , Magnus Damm , linux-sh@vger.kernel.org Subject: Re: [PATCH 9/10] sh: Use struct syscore_ops instead of sysdev class and sysdev Message-ID: <20110323095920.GA6008@linux-sh.org> References: <201103100131.58206.rjw@sisk.pl> <201103190147.28001.rjw@sisk.pl> <20110322140420.GA24004@linux-sh.org> <201103222119.28328.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201103222119.28328.rjw@sisk.pl> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2011 at 09:19:28PM +0100, Rafael J. Wysocki wrote: > Convert the SuperH clocks framework and shared interrupt handling > code to using struct syscore_ops instead of a sysdev classes and > sysdevs for power managment. > > This reduces the code size significantly and simplifies it. The > optimizations causing things not to be restored after creating a > hibernation image are removed, but they might lead to undesirable > effects during resume from hibernation (e.g. the clocks would be left > as the boot kernel set them, which might be not the same way as the > hibernated kernel had seen them before the hibernation). > > This also is necessary for removing sysdevs from the kernel entirely > in the future. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/sh/clk/core.c | 68 ++++++++----------------------- > drivers/sh/intc/core.c | 95 +++++++++++++++++++++----------------------- > drivers/sh/intc/internals.h | 1 > 3 files changed, 65 insertions(+), 99 deletions(-) > This one looks good, and seems to work fine. Applied, thanks.