From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932766Ab1CWOqb (ORCPT ); Wed, 23 Mar 2011 10:46:31 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:64077 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932434Ab1CWOqa (ORCPT ); Wed, 23 Mar 2011 10:46:30 -0400 From: Arnd Bergmann To: "Par-Gunnar Hjalmdahl" Subject: Re: [PATCH 1/2] staging: Add ST-Ericsson CG2900 driver Date: Wed, 23 Mar 2011 15:46:09 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; ) Cc: "Greg Kroah-Hartman" , devel@driverdev.osuosl.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Pavan Savoy , Vitaly Wool , Alan Cox , Marcel Holtmann , Lukasz Rymanowski , Linus Walleij , "Par-Gunnar Hjalmdahl" , Lee Jones References: <1300888771-26437-1-git-send-email-par-gunnar.p.hjalmdahl@stericsson.com> In-Reply-To: <1300888771-26437-1-git-send-email-par-gunnar.p.hjalmdahl@stericsson.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103231546.10206.arnd@arndb.de> X-Provags-ID: V02:K0:q/EJvsSDJMNixKU29zPcqVJzwCbcZdqdLd3jULnNAck x8JTeZdKNgvi1vOLBkvZbLcBAOUfsILU1OAfcQHL62BjHt1p6q 1hHU1QL39Jdl18f+O3/uR3Feleel3k4VUWoAonF2kTWdUKN10s rnui9ZdfwsHQokNQZOwtbF6oPjqZQX4M4t1/BCqw5RB5L8ymEN V8491QhM40NlcTivhRYZw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 23 March 2011, Par-Gunnar Hjalmdahl wrote: > +TODO > +---- > + > + - Decide upon architecture. Some people consider architecture in the cg2900 > + driver to be too complex. We consider it to be not more complex than needed. > + > + - Currently the cg2900_uart registers as protocol driver against hci_ldisc.c. > + There is however some common functionality with hci_h4.c and the cg2900 could > + therefore register it's vendor specific channels to hci_h4.c, but this would > + require adding a registration functionality in the hci_h4 file. > + > + - Some people demand that the cg2900 driver re-use the Bluetooth driver to send > + and receive BT commands and events. That is however not possible with current > + BT API and might not be feasible, for example when using FM only in > + the cg2900 chip. > + > + - TI has already delivered a driver for a multi-function chip called ti-st. > + This driver is currently located in drivers/misc/ti-st/. There has however > + been criticism raised against design/architecture of the driver. There > + currently also doesn't seem to be a way to add support for cg2900 in that > + driver even though some people has raised this as an alternative. I assume that this TODO list will evolve a bit as we start resume the driver. For now, I'm fine this patch going into staging (aside from my comments on patch 2/2). I'll do a new review soon, please ping me again if I haven't done it by next week. Arnd