From: Andi Kleen <andi@firstfloor.org>
To: "K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Huang Ying <ying.huang@intel.com>,
Jin Dongming <jin.dongming@np.css.fujitsu.com>,
linux-kernel@vger.kernel.org,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
hughd@google.com
Subject: Re: [PATCH 3/4] Check whether pages are poisoned before copying
Date: Wed, 23 Mar 2011 18:32:06 +0100 [thread overview]
Message-ID: <20110323173206.GG21838@one.firstfloor.org> (raw)
In-Reply-To: <20110323172616.GA2170@in.ibm.com>
> On an extended note, I don't understand why hwpoison code should not
> handle Ksm pages the same way as other user-space pages. While it is
Noone has done the work for it so far.
However we did some evaluation some time ago with some simple
KVM setups and it turned out KSM was only very little physical memory
overall (< few percent) Normally it's better to focus on areas with more
payoff (= more memory), unless you can find a workload where KSM is actually
significant.
> It appears that the restriction for PageKsm() can be removed from
> memory-failure.c code without making the races any better or worse. Any
> opinions on that?
I don't know. The KSM code paths would need to be audited first.
Hugh added the checks originally and may have an opinion.
-Andi
next prev parent reply other threads:[~2011-03-23 17:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 2:30 [PATCH 0/4] THP: page collapsing vs. poisoning Hidetoshi Seto
2011-03-17 2:31 ` [PATCH 1/4] Lock the new THP when collapsing pages Hidetoshi Seto
2011-03-17 2:32 ` [PATCH 2/4] Free the collapsed pages after the new THP is mapped Hidetoshi Seto
2011-03-17 2:32 ` [PATCH 3/4] Check whether pages are poisoned before copying Hidetoshi Seto
2011-03-17 4:14 ` Andi Kleen
2011-03-17 5:20 ` Hidetoshi Seto
2011-03-17 6:26 ` Andi Kleen
2011-03-17 7:43 ` Hidetoshi Seto
2011-03-17 14:04 ` Andrea Arcangeli
2011-03-17 15:25 ` Andi Kleen
2011-03-17 16:12 ` Andrea Arcangeli
2011-03-17 16:27 ` Andi Kleen
2011-03-17 16:47 ` Andrea Arcangeli
2011-03-17 22:55 ` Andi Kleen
2011-03-23 17:26 ` K.Prasad
2011-03-23 17:32 ` Andi Kleen [this message]
2011-03-17 15:21 ` Andi Kleen
2011-03-18 5:26 ` Jin Dongming
2011-03-17 2:33 ` [PATCH 4/4] Check whether the new THP is poisoned before it is mapped to APL Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323173206.GG21838@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=hughd@google.com \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=vatsa@in.ibm.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).