linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Chad Talbott <ctalbott@google.com>
Cc: Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
	jaxboe@fusionio.com, linux-kernel@vger.kernel.org,
	mrubin@google.com, teravest@google.com
Subject: Re: [PATCH 0/3] cfq-iosched: Fair cross-group preemption
Date: Mon, 28 Mar 2011 13:24:47 -0400	[thread overview]
Message-ID: <20110328172447.GE7226@redhat.com> (raw)
In-Reply-To: <AANLkTinwmTjD-Q19U5nCPvoqN2DYGwtLDgeR8h39uWCX@mail.gmail.com>

On Mon, Mar 28, 2011 at 09:59:54AM -0700, Chad Talbott wrote:
> On Mon, Mar 28, 2011 at 6:15 AM, Vivek Goyal <vgoyal@redhat.com> wrote:
> > On Fri, Mar 25, 2011 at 04:53:13PM -0700, Chad Talbott wrote:
> >> Also, we'll soon be working to adopt the hierarchy series, and we'll
> >> likely revisit using an RT service tree there.  It's difficult to
> >> justify introducing RT service tree before those patches arrive.
> >
> > So once you move to hierachicy series, will be you using RT class and
> > use throttling and abandon this functionality?
> 
> I'll certainly investigate using RT class and throttling, but it's too
> early to know.  It's a known change in behavior, so it will need
> testing (as well as the user-space work to handle the different
> interface).

So why not assess that now and then go for the one which meets your
requirements in long term. If we introduce this patch now, this 
introduces a new user visible interface and we can't get rid of it
later. If two releases down the line you implement RT group functionality
and move to that, then we have this dead interface not being used.

So why not implement RT groups internally (It should be a huge patch) now
and test and see how well is it working with throttling logic and whether
it meets your needs or not.

Thanks
Vivek

  reply	other threads:[~2011-03-28 17:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22  1:10 [PATCH 0/3] cfq-iosched: Fair cross-group preemption Chad Talbott
2011-03-22  1:10 ` [PATCH 1/3] cfq-iosched: Fair cross-group preemption (interface and documentation) Chad Talbott
2011-03-22 10:03   ` Gui Jianfeng
2011-03-22 18:07     ` Chad Talbott
2011-03-22  1:10 ` [PATCH 2/3] cfq-iosched: Fair cross-group preemption (implementation) Chad Talbott
2011-03-22  1:10 ` [PATCH 3/3] cfq-iosched: Fair cross-group preemption (stats) Chad Talbott
2011-03-22 15:09 ` [PATCH 0/3] cfq-iosched: Fair cross-group preemption Vivek Goyal
2011-03-22 17:39   ` Chad Talbott
2011-03-22 18:12     ` Vivek Goyal
2011-03-22 23:46       ` Chad Talbott
2011-03-23  1:43         ` Vivek Goyal
2011-03-23 20:10       ` Chad Talbott
2011-03-23 20:41         ` Vivek Goyal
2011-03-24 21:47           ` Chad Talbott
2011-03-25  5:43             ` Gui Jianfeng
2011-03-25 21:32             ` Vivek Goyal
2011-03-25 23:53               ` Chad Talbott
2011-03-28 13:15                 ` Vivek Goyal
2011-03-28 16:59                   ` Chad Talbott
2011-03-28 17:24                     ` Vivek Goyal [this message]
2011-03-28 13:17                 ` Vivek Goyal
2011-03-28 17:02                   ` Chad Talbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110328172447.GE7226@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=ctalbott@google.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrubin@google.com \
    --cc=teravest@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).