linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Julian Anastasov <ja@ssi.bg>,
	jirislaby@gmail.com, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/6] TTY: unify tty_init_dev fail path handling
Date: Tue, 29 Mar 2011 06:12:19 -0700	[thread overview]
Message-ID: <20110329131219.GA17294@suse.de> (raw)
In-Reply-To: <4D91CDE6.9060006@suse.cz>

On Tue, Mar 29, 2011 at 02:17:42PM +0200, Jiri Slaby wrote:
> On 03/23/2011 09:53 PM, Julian Anastasov wrote:
> > 
> >     Hello,
> > 
> > On Wed, 23 Mar 2011, Jiri Slaby wrote:
> > 
> >> Change it so that we call the deinit functions at one place at the end
> >> of the function (by gotos). And while at it use some sane label names.
> >>
> >> This is a preparation for the deinitialization of tty in the next
> >> patch.
> >>
> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> >> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> >> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> >> Cc: Julian Anastasov <ja@ssi.bg>
> >> ---
> >>
> >> This is not tested yet, I'm building a kernel to test it a bit, but it
> >> will take some time. If you could too to check if your problem
> >> dissapears, it would be great.
> > 
> >     Thanks! Patches 1-5 work for me, I backported them
> > to 2.6.33.8 for the test.
> 
> Thanks for testing. I see no regressions either.
> 
> Greg, will you take it?

Yes I will queue it up in a week or so, thanks.

greg k-h

      reply	other threads:[~2011-03-29 13:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23  9:48 [PATCH 1/6] TTY: unify tty_init_dev fail path handling Jiri Slaby
2011-03-23  9:48 ` [PATCH 2/6] TTY: unify pty_install " Jiri Slaby
2011-03-23  9:48 ` [PATCH 3/6] TTY: unify pty_unix98_install " Jiri Slaby
2011-03-23  9:48 ` [PATCH 4/6] TTY: introduce deinit helpers for proper ldisc shutdown Jiri Slaby
2011-03-23  9:48 ` [PATCH 5/6] TTY: plug in deinitialize_tty_struct Jiri Slaby
2011-03-23  9:48 ` [PATCH 6/6] TTY: fix fail path in tty_open Jiri Slaby
2011-03-23 20:53 ` [PATCH 1/6] TTY: unify tty_init_dev fail path handling Julian Anastasov
2011-03-29 12:17   ` Jiri Slaby
2011-03-29 13:12     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110329131219.GA17294@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ja@ssi.bg \
    --cc=jirislaby@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).