From: Matt Helsley <matthltc@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
containers@lists.linux-foundation.org,
Nathan Lynch <ntl@pobox.com>,
linux-kernel@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH 05/10] Core checkpoint/restart support code
Date: Mon, 4 Apr 2011 14:55:11 -0700 [thread overview]
Message-ID: <20110404215511.GA27628@count0.beaverton.ibm.com> (raw)
In-Reply-To: <20110404124222.fd5eb85b.akpm@linux-foundation.org>
On Mon, Apr 04, 2011 at 12:42:22PM -0700, Andrew Morton wrote:
> On Mon, 4 Apr 2011 13:51:20 -0500 "Serge E. Hallyn" <serge.hallyn@ubuntu.com> wrote:
>
> > Quoting Andrew Morton (akpm@linux-foundation.org):
> > > On Mon, 4 Apr 2011 11:27:53 -0500 "Serge E. Hallyn" <serge@hallyn.com> wrote:
> > >
> > > > Andrew (Cc:d), did you see this thread go by, and it did it look
> > > > in any way more palatable to you? Have you had any thoughts on
> > > > checkpoint/restart in the last few months? Or did that horse quietly
> > > > die over winter?
> > >
> > > argh, it was the victim of LIFO.
> > >
> > > All I can say at this stage is that I'll be interested next time it
> > > comes past, sorry.
> >
> > Thanks, that's good to know.
> >
> > As you know, we started with a minimal patchset, then grew it over time
> > to answer the "but how will you (xyz) without uglifying the kernel".
> > Would you recommend we go back to keeping a separate minimal patchset,
> > or that we develop on the current, pretty feature-full version? I'm not
> > convinced believe there will be bandwidth to keep two trees and do both
> > justice.
>
> The minimal patchset is too minimal for Oren's use and the maximal
> patchset seems to have run aground on general kernel sentiment. So I
> guess you either take the minimal patchset and make it less minimal or
> take the maximal patchset and make it less maximal, ending up with the
> same thing. How's that for hand-waving useless obviousnesses :)
>
> One obvious approach is to merge the minimal patchset then, over time,
> sneak more stuff into it so we end up with the maximal patchset which
> people didn't like. Don't do that :)
Yes, merging this minimal patch set early is obviously premature.
It seems clear from your statement above that "the maximal patchset seems to
have run aground on general kernel sentiment" -- pushing that set isn't
going to make any progress. So I think we're left with modifying the new
minimal patch set.
However I think we need some review before we continue modifying it. We
had a minimal patch set which evolved into the current maximal set. It
never really got the reviews outside our little group that it needed.
Now we're back with a new minimal patch set. You're asking us to do the same
thing and expect different results -- stack more patches on top and expect to
get it reviewed. OK, but what reason do we have to believe this time will be
any different?
Cheers,
-Matt Helsley
next prev parent reply other threads:[~2011-04-04 22:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 23:40 [RFC 00/10] container-based checkpoint/restart prototype ntl
2011-02-28 23:40 ` [PATCH 01/10] Make exec_mmap extern ntl
2011-04-03 16:56 ` Serge E. Hallyn
2011-02-28 23:40 ` [PATCH 02/10] Introduce mm_has_pending_aio() helper ntl
2011-03-01 15:40 ` Jeff Moyer
2011-03-01 16:04 ` Nathan Lynch
2011-02-28 23:40 ` [PATCH 03/10] Introduce has_locks_with_owner() helper ntl
2011-04-03 18:55 ` Serge E. Hallyn
2011-02-28 23:40 ` [PATCH 04/10] Introduce vfs_fcntl() helper ntl
2011-04-03 18:57 ` Serge E. Hallyn
2011-02-28 23:40 ` [PATCH 05/10] Core checkpoint/restart support code ntl
2011-04-03 19:03 ` Serge E. Hallyn
2011-04-04 15:00 ` Nathan Lynch
2011-04-04 15:10 ` Serge E. Hallyn
2011-04-04 15:40 ` Nathan Lynch
2011-04-04 16:27 ` Serge E. Hallyn
2011-04-04 17:32 ` Oren Laadan
2011-04-04 21:43 ` Nathan Lynch
2011-04-04 22:03 ` Serge E. Hallyn
2011-04-04 23:42 ` Dan Smith
2011-04-05 2:17 ` Serge E. Hallyn
2011-04-05 19:18 ` Nathan Lynch
2011-04-04 22:29 ` Matt Helsley
2011-04-04 17:41 ` Andrew Morton
2011-04-04 18:51 ` Serge E. Hallyn
2011-04-04 19:42 ` Andrew Morton
2011-04-04 20:29 ` Serge E. Hallyn
2011-04-04 21:55 ` Matt Helsley [this message]
2011-04-04 23:15 ` Andrew Morton
2011-04-04 23:16 ` Valdis.Kletnieks
2011-04-04 23:43 ` Matt Helsley
2011-04-04 22:11 ` Serge E. Hallyn
2011-04-04 22:53 ` Serge E. Hallyn
2011-04-04 21:20 ` Nathan Lynch
2011-04-04 21:53 ` Serge E. Hallyn
2011-02-28 23:40 ` [PATCH 06/10] Checkpoint/restart mm support ntl
2011-02-28 23:40 ` [PATCH 07/10] Checkpoint/restart vfs support ntl
2011-02-28 23:40 ` [PATCH 08/10] Add generic '->checkpoint' f_op to ext filesystems ntl
2011-02-28 23:40 ` [PATCH 09/10] Add generic '->checkpoint()' f_op to simple char devices ntl
2011-02-28 23:40 ` [PATCH 10/10] x86_32 support for checkpoint/restart ntl
2011-03-01 1:08 ` [RFC 00/10] container-based checkpoint/restart prototype Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404215511.GA27628@count0.beaverton.ibm.com \
--to=matthltc@us.ibm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
--cc=serge.hallyn@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).