From: Scott Wood <scottwood@freescale.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: <trivial@kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>,
Harninder Rai <harninder.rai@freescale.com>
Subject: Re: [RFC 2/5]arch:powerpc:sysdev:Makefile Remove unused config in the Makefile.
Date: Tue, 5 Apr 2011 13:15:04 -0500 [thread overview]
Message-ID: <20110405131504.1d182da4@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <1302022702-24541-2-git-send-email-justinmattock@gmail.com>
On Tue, 5 Apr 2011 09:58:19 -0700
"Justin P. Mattock" <justinmattock@gmail.com> wrote:
> The patch below removes an unused config variable found by using a kernel
> cleanup script.
> Note: I did try to cross compile these but hit erros while doing so..
> (gcc is not setup to cross compile) and am unsure if anymore needs to be done.
> Please have a look if/when anybody has free time.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CC: linuxppc-dev@lists.ozlabs.org
>
> ---
> arch/powerpc/sysdev/Makefile | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
> index 1e0c933..243b6ad 100644
> --- a/arch/powerpc/sysdev/Makefile
> +++ b/arch/powerpc/sysdev/Makefile
> @@ -18,7 +18,6 @@ obj-$(CONFIG_FSL_PMC) += fsl_pmc.o
> obj-$(CONFIG_FSL_LBC) += fsl_lbc.o
> obj-$(CONFIG_FSL_GTM) += fsl_gtm.o
> obj-$(CONFIG_MPC8xxx_GPIO) += mpc8xxx_gpio.o
> -obj-$(CONFIG_FSL_85XX_CACHE_SRAM) += fsl_85xx_l2ctlr.o fsl_85xx_cache_sram.o
> obj-$(CONFIG_SIMPLE_GPIO) += simple_gpio.o
> obj-$(CONFIG_FSL_RIO) += fsl_rio.o
> obj-$(CONFIG_TSI108_BRIDGE) += tsi108_pci.o tsi108_dev.o
Those files do exist, and aren't pulled in by any other means I can see.
It was introduced by commit 6db92cc9d07db9f713da8554b4bcdfc8e54ad386, whose
changelog says:
Drivers can do the following in Kconfig to use these APIs "select
FSL_85XX_CACHE_SRAM if MPC85xx"
Now, the absence of such a kconfig option[1] is a problem, but I don't think
outright removal (labelled "trivial cleanup") is appropriate, unless nobody
fixes it after the problem is pointed out. And if it is removed, the files
should go with it.
-Scott
[1] and of any drivers that select it, though this was added fairly
recently -- perhaps such a driver change is on its way?
next prev parent reply other threads:[~2011-04-05 18:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 16:58 [RFC 1/5]arch/arm/common/Makefile Remove unused config in the Makefile Justin P. Mattock
2011-04-05 16:58 ` [RFC 2/5]arch:powerpc:sysdev:Makefile " Justin P. Mattock
2011-04-05 18:15 ` Scott Wood [this message]
2011-04-06 15:07 ` Justin Mattock
2011-04-06 16:03 ` Scott Wood
2011-04-06 16:09 ` Justin Mattock
2011-04-05 16:58 ` [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile " Justin P. Mattock
2011-04-08 13:08 ` Ralf Baechle
2011-04-08 15:10 ` Justin P. Mattock
2011-04-05 16:58 ` [RFC 4/5]arch:mn10300:kernel:Makefile " Justin P. Mattock
2011-04-05 16:58 ` [RFC 5/5]arch:powerpc:kernel:Makefile " Justin P. Mattock
2011-04-06 8:05 ` [RFC 1/5]arch/arm/common/Makefile " Uwe Kleine-König
2011-04-06 15:10 ` Justin P. Mattock
2011-04-07 22:23 ` Russell King - ARM Linux
2011-04-07 23:40 ` Justin P. Mattock
2011-04-07 3:59 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405131504.1d182da4@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=harninder.rai@freescale.com \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).