Re: [PATCH] rfkill: Regulator consumer driver for rfkill

From: Antonio Ospite <ospite@studenti.unina.it>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, openezx-devel@lists.openezx.org,
	"John W . Linville" <linville@tuxdriver.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
	Guiming Zhuo <gmzhuo@gmail.com>
Subject: Re: [PATCH] rfkill: Regulator consumer driver for rfkill
Date: Wed, 6 Apr 2011 16:24:31 +0200	[thread overview]
Message-ID: <20110406162431.cbcb0fd6.ospite@studenti.unina.it> (raw)
In-Reply-To: <1302098968.4090.0.camel@jlt3.sipsolutions.net>

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

On Wed, 06 Apr 2011 16:09:28 +0200
Johannes Berg <johannes@sipsolutions.net> wrote:

> On Wed, 2011-04-06 at 16:06 +0200, Antonio Ospite wrote:
> 
> > > > +	if (regulator_is_enabled(vcc)) {
> > > > +		dev_dbg(&pdev->dev, "Regulator already enabled\n");
> > > > +		rfkill_data->reg_enabled = 1;
> > > > +	}
> > > > +	rfkill_init_sw_state(rf_kill, !rfkill_data->reg_enabled);
> > > > +
> > > > +	ret = rfkill_register(rf_kill);
> > > 
> > > We recently had a thread about how rfkill_init_sw_state() isn't quite
> > > working the right way. Also, it is indented to be used for devices that
> > > keep their state over resume. I think you should remove it here and rely
> > > on rfkill to sync you after registration.
> > > 
> > > Cf. the long thread here:
> > > http://thread.gmane.org/gmane.linux.acpi.devel/49577
> > >
> > 
> > Ok, but I still need to replace that call with a rfkill_set_sw_state()
> > to expose the initial status of the regulator to the rfkill system,
> > right?
> 
> Well, you could, but if you don't do that then the rfkill subsystem will
> simply call set_block() shortly after registration to put it into the
> state that it thinks it should be in, which is usually more useful.
> 

I see, let's just drop rfkill_init_sw_state() then.

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]