From: Nick Bowler <nbowler@elliptictech.com>
To: oskar.andero@sonyericsson.com
Cc: linux@arm.linux.org.uk, nicolas.pitre@linaro.org,
will.deacon@arm.com, eric.y.miao@gmail.com,
catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Victor Boivie <victor.boivie@sonyericsson.com>
Subject: Re: [PATCH] ARM: Allow for kernel command line concatenation
Date: Thu, 7 Apr 2011 09:18:10 -0400 [thread overview]
Message-ID: <20110407131810.GA6450@elliptictech.com> (raw)
In-Reply-To: <1302164236-1516-1-git-send-email-oskar.andero@sonyericsson.com>
On 2011-04-07 10:17 +0200, oskar.andero@sonyericsson.com wrote:
> From: Victor Boivie <victor.boivie@sonyericsson.com>
>
> This patch allows the provided CONFIG_CMDLINE to be concatenated
> with the one provided by the boot loader. This is useful to
> merge the static values defined in CONFIG_CMDLINE with the
> boot loader's (possibly) more dynamic values, such as startup
> reasons and more.
This sounds very useful! One comment below.
> Signed-off-by: Victor Boivie <victor.boivie@sonyericsson.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@sonyericsson.com>
> Signed-off-by: Oskar Andero <oskar.andero@sonyericsson.com>
> ---
> arch/arm/Kconfig | 21 +++++++++++++++++++--
> arch/arm/kernel/setup.c | 9 ++++++++-
> 2 files changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
[...]
> +config CMDLINE_EXTEND
> + bool "Extend bootloader kernel arguments"
> + depends on CMDLINE != ""
> + help
> + The default kernel command string will be concatenated with the
> + arguments provided by the boot loader.
Since concatenation is not commutative, this help text should describe
exactly the order in which the arguments are concatenated. How about
this instead:
The command-line arguments provided by the boot loader will be
appended to the default kernel command string.
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
next prev parent reply other threads:[~2011-04-07 13:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 8:17 [PATCH] ARM: Allow for kernel command line concatenation oskar.andero
2011-04-07 9:01 ` Uwe Kleine-König
2011-04-07 10:35 ` Paul Bolle
2011-04-07 10:58 ` Uwe Kleine-König
2011-04-07 11:38 ` Boivie, Victor
2011-04-07 13:18 ` Nick Bowler [this message]
2011-04-07 13:22 ` Boivie, Victor
2011-04-07 11:47 oskar.andero
2011-04-07 13:29 oskar.andero
2011-04-07 18:50 ` Nicolas Pitre
2011-04-07 19:15 ` Uwe Kleine-König
2011-04-08 9:36 oskar.andero
2011-05-04 15:03 ` oskar.andero
2011-05-04 15:11 ` Uwe Kleine-König
2011-05-04 16:10 ` oskar.andero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110407131810.GA6450@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=catalin.marinas@arm.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=oskar.andero@sonyericsson.com \
--cc=victor.boivie@sonyericsson.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).