linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lucas De Marchi <lucas.demarchi@profusion.mobi>,
	Ameya Palande <ameya.palande@nokia.com>
Subject: linux-next: manual merge of the drivers-x86 tree with Linus' tree
Date: Fri, 8 Apr 2011 15:26:30 +1000	[thread overview]
Message-ID: <20110408152630.0aca7b6f.sfr@canb.auug.org.au> (raw)

Hi Matthew,

Today's linux-next merge of the drivers-x86 tree got a conflict in
drivers/platform/x86/intel_mid_thermal.c between commit 25985edcedea
("Fix common misspellings") from Linus' tree and commit 55488261b326
("platform-x86: intel_mid_thermal: Fix coding style") from the
drivers-x86 tree.

I fixed it up (see below) and can carry the fix as necessary.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc drivers/platform/x86/intel_mid_thermal.c
index c2f4bd8,9ee707f..0000000
--- a/drivers/platform/x86/intel_mid_thermal.c
+++ b/drivers/platform/x86/intel_mid_thermal.c
@@@ -178,47 -179,47 +179,47 @@@ static int adc_to_temp(int direct, uint
   */
  static int mid_read_temp(struct thermal_zone_device *tzd, unsigned long *temp)
  {
-        struct thermal_device_info *td_info = tzd->devdata;
-        uint16_t adc_val, addr;
-        uint8_t data = 0;
-        int ret;
-        unsigned long curr_temp;
- 
- 
-        addr = td_info->chnl_addr;
- 
-        /* Enable the msic for conversion before reading */
-        ret = intel_scu_ipc_iowrite8(MSIC_THERM_ADC1CNTL3, MSIC_ADCRRDATA_ENBL);
-        if (ret)
-                return ret;
- 
-        /* Re-toggle the RRDATARD bit (temporary workaround) */
-        ret = intel_scu_ipc_iowrite8(MSIC_THERM_ADC1CNTL3, MSIC_ADCTHERM_ENBL);
-        if (ret)
-                return ret;
- 
-        /* Read the higher bits of data */
-        ret = intel_scu_ipc_ioread8(addr, &data);
-        if (ret)
-                return ret;
- 
-        /* Shift bits to accommodate the lower two data bits */
-        adc_val = (data << 2);
-        addr++;
- 
-        ret = intel_scu_ipc_ioread8(addr, &data);/* Read lower bits */
-        if (ret)
-                return ret;
- 
-        /* Adding lower two bits to the higher bits */
-        data &= 03;
-        adc_val += data;
- 
-        /* Convert ADC value to temperature */
-        ret = adc_to_temp(td_info->direct, adc_val, &curr_temp);
-        if (ret == 0)
-                *temp = td_info->curr_temp = curr_temp;
-        return ret;
+ 	struct thermal_device_info *td_info = tzd->devdata;
+ 	uint16_t adc_val, addr;
+ 	uint8_t data = 0;
+ 	int ret;
+ 	unsigned long curr_temp;
+ 
+ 
+ 	addr = td_info->chnl_addr;
+ 
+ 	/* Enable the msic for conversion before reading */
+ 	ret = intel_scu_ipc_iowrite8(MSIC_THERM_ADC1CNTL3, MSIC_ADCRRDATA_ENBL);
+ 	if (ret)
+ 		return ret;
+ 
+ 	/* Re-toggle the RRDATARD bit (temporary workaround) */
+ 	ret = intel_scu_ipc_iowrite8(MSIC_THERM_ADC1CNTL3, MSIC_ADCTHERM_ENBL);
+ 	if (ret)
+ 		return ret;
+ 
+ 	/* Read the higher bits of data */
+ 	ret = intel_scu_ipc_ioread8(addr, &data);
+ 	if (ret)
+ 		return ret;
+ 
 -	/* Shift bits to accomodate the lower two data bits */
++	/* Shift bits to accommodate the lower two data bits */
+ 	adc_val = (data << 2);
+ 	addr++;
+ 
+ 	ret = intel_scu_ipc_ioread8(addr, &data);/* Read lower bits */
+ 	if (ret)
+ 		return ret;
+ 
+ 	/* Adding lower two bits to the higher bits */
+ 	data &= 03;
+ 	adc_val += data;
+ 
+ 	/* Convert ADC value to temperature */
+ 	ret = adc_to_temp(td_info->direct, adc_val, &curr_temp);
+ 	if (ret == 0)
+ 		*temp = td_info->curr_temp = curr_temp;
+ 	return ret;
  }
  
  /**

             reply	other threads:[~2011-04-08  5:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08  5:26 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-03-08  2:34 linux-next: manual merge of the drivers-x86 tree with Linus' tree Stephen Rothwell
2024-03-08  2:19 Stephen Rothwell
2024-03-01  3:14 Stephen Rothwell
2024-02-08  1:57 Stephen Rothwell
2024-01-02  2:30 Stephen Rothwell
2018-10-29  3:29 Stephen Rothwell
2018-10-29  9:34 ` Andy Shevchenko
2016-01-15  1:56 Stephen Rothwell
2015-06-02  6:07 Stephen Rothwell
2015-06-03  3:27 ` Darren Hart
2015-06-03  4:04   ` Stephen Rothwell
2012-05-31  2:06 Stephen Rothwell
2011-03-24  2:48 Stephen Rothwell
2011-03-24  2:52 ` Matthew Garrett
2010-08-25  1:22 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110408152630.0aca7b6f.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=ameya.palande@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).