From: Jonathan Corbet <corbet@lwn.net>
To: Tony Ibbs <tibs@tonyibbs.co.uk>
Cc: Grant Likely <grant.likely@secretlab.ca>,
lkml <linux-kernel@vger.kernel.org>,
Linux-embedded <linux-embedded@vger.kernel.org>,
Tibs at Kynesim <tibs@kynesim.co.uk>,
Richard Watts <rrw@kynesim.co.uk>
Subject: Re: [PATCH] extra/1 Allow setting the maximum KBUS message size
Date: Fri, 15 Apr 2011 16:46:08 -0600 [thread overview]
Message-ID: <20110415164608.489d82bf@bike.lwn.net> (raw)
In-Reply-To: <32934D05-E7A7-4A2C-92EF-96A0580F2234@tonyibbs.co.uk>
On Fri, 15 Apr 2011 22:34:53 +0100
Tony Ibbs <tibs@tonyibbs.co.uk> wrote:
> This patch provides mechanisms for setting an absolute maximum message
> size at compile time, and a per-device maximum at runtime.
It seems like a good step in the right direction. Do you really need to
add a bunch more configuration options, though? It seems like a
reasonable default and a way to change it (sysfs file, maybe) might be
better. Is there a way to cap the total memory used by the kbus subsystem?
The kzalloc() fixes seem like a good idea too, BUT: I honestly think that
the item at the top of your list, if you want to merge this code, must be
to get the user-space API more widely reviewed and accepted. It could, I
think, be a big sticking point, and it's something you want to try to
address sooner rather than later.
That means getting more people to look at the patch, which could be hard.
The problem is that, if you wait, they'll only squeal when the code is
close to going in, and you could find yourself set back a long way. A
good first step might be to CC Andrew Morton on your next posting.
Thanks,
jon
next prev parent reply other threads:[~2011-04-15 22:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 17:21 [PATCH 00/11] RFC: KBUS messaging subsystem Tony Ibbs
2011-03-18 17:21 ` [PATCH 01/11] Documentation for KBUS Tony Ibbs
2011-03-18 17:21 ` [PATCH 02/11] KBUS external header file Tony Ibbs
2011-03-18 17:21 ` [PATCH 03/11] KBUS internal " Tony Ibbs
2011-03-18 17:21 ` [PATCH 04/11] KBUS main source file, basic device support only Tony Ibbs
2011-03-18 17:21 ` [PATCH 05/11] KBUS add support for messages Tony Ibbs
2011-03-18 17:21 ` [PATCH 06/11] KBUS add ability to receive messages only once Tony Ibbs
2011-03-18 17:21 ` [PATCH 07/11] KBUS add ability to add devices at runtime Tony Ibbs
2011-03-18 17:21 ` [PATCH 08/11] KBUS add Replier Bind Events Tony Ibbs
2011-03-18 17:21 ` [PATCH 09/11] KBUS Replier Bind Event set-aside lists Tony Ibbs
2011-03-18 17:21 ` [PATCH 10/11] KBUS report state to userspace Tony Ibbs
2011-03-18 17:21 ` [PATCH 11/11] KBUS configuration and Makefile Tony Ibbs
2011-03-22 19:36 ` [PATCH 00/11] RFC: KBUS messaging subsystem Jonathan Corbet
2011-03-23 23:13 ` Tony Ibbs
2011-03-24 18:03 ` James Chapman
2011-03-27 19:07 ` Tony Ibbs
2011-04-15 21:34 ` [PATCH] extra/1 Allow setting the maximum KBUS message size Tony Ibbs
2011-04-15 22:46 ` Jonathan Corbet [this message]
2011-04-18 14:01 ` Mark Brown
2011-04-19 19:33 ` Tony Ibbs
2011-05-17 8:50 ` [PATCH 00/11] RFC: KBUS messaging subsystem Florian Fainelli
2011-05-22 19:58 ` Tony Ibbs
2011-07-06 16:15 ` Florian Fainelli
2011-07-28 21:48 ` RFC: [Restatement] " Tony Ibbs
2011-07-28 23:58 ` Colin Walters
2011-08-03 20:14 ` Tony Ibbs
2011-08-07 16:47 ` Tony Ibbs
2011-08-03 20:48 ` Pekka Enberg
2011-08-07 20:24 ` Tony Ibbs
2011-08-15 11:46 ` Pekka Enberg
2011-08-21 13:28 ` Tony Ibbs
2011-08-22 1:15 ` Bryan Donlan
2011-08-29 8:55 ` Tony Ibbs
2011-08-03 20:23 ` [PATCH 00/11] RFC: " Tony Ibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415164608.489d82bf@bike.lwn.net \
--to=corbet@lwn.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrw@kynesim.co.uk \
--cc=tibs@kynesim.co.uk \
--cc=tibs@tonyibbs.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).