From: Vasiliy Kulikov <segoon@openwall.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
solar@openwall.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, peak@argo.troja.mff.cuni.cz,
kees.cook@canonical.com, dan.j.rosenberg@gmail.com,
eugene@redhat.com, nelhage@ksplice.com, kuznet@ms2.inr.ac.ru,
pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net
Subject: Re: [PATCH net-next-2.6 v2] net: ping: dont call udp_ioctl()
Date: Mon, 16 May 2011 16:48:28 +0400 [thread overview]
Message-ID: <20110516124828.GA5943@albatros> (raw)
In-Reply-To: <1305530791.3120.217.camel@edumazet-laptop>
On Mon, May 16, 2011 at 09:26 +0200, Eric Dumazet wrote:
> Le dimanche 15 mai 2011 à 17:44 -0400, David Miller a écrit :
>
> > Just get rid of ping_ioctl() entirely, as that is the effect of
> > this change since inet_ioctl() returns -ENOIOCTLCMD when
> > sk_prot->ioctl is NULL.
> >
> > Also get rid of asm/ioctls.h since that will be no longer needed.
>
> Sure, here is updated version, thanks.
>
> [PATCH net-next-2.6 v2] net: ping: dont call udp_ioctl()
>
> udp_ioctl() really handles UDP and UDPLite protocols.
>
> 1) It can increment UDP_MIB_INERRORS in case first_packet_length() finds
> a frame with bad checksum.
>
> 2) It has a dependency on sizeof(struct udphdr), not applicable to
> ICMP/PING
>
> If ping sockets need to handle SIOCINQ/SIOCOUTQ ioctl, this should be
> done differently.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Vasiliy Kulikov <segoon@openwall.com>
Thanks,
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-05-16 12:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 10:15 [PATCH] net: ipv4: add IPPROTO_ICMP socket kind Vasiliy Kulikov
2011-04-12 5:06 ` Solar Designer
2011-04-12 21:25 ` David Miller
2011-04-13 11:22 ` Vasiliy Kulikov
2011-05-05 11:32 ` Vasiliy Kulikov
2011-05-10 18:09 ` [PATCH v2] " Vasiliy Kulikov
2011-05-10 19:15 ` David Miller
2011-05-10 19:45 ` Vasiliy Kulikov
2011-05-13 20:01 ` [PATCH v3] " Vasiliy Kulikov
2011-05-13 20:08 ` David Miller
2011-05-13 21:30 ` Andi Kleen
2011-05-13 22:22 ` [PATCH net-next-2.6] net: ipv4: add ping_group_range documentation Eric Dumazet
2011-05-15 8:18 ` [PATCH net-next-2.6] net: ping: dont call udp_ioctl() Eric Dumazet
2011-05-15 21:30 ` Solar Designer
2011-05-15 21:44 ` David Miller
2011-05-16 7:26 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2011-05-16 12:48 ` Vasiliy Kulikov [this message]
2011-05-16 15:50 ` David Miller
2011-04-13 10:29 ` [PATCH] net: ipv4: add IPPROTO_ICMP socket kind Alexey Dobriyan
2011-04-13 11:32 ` Vasiliy Kulikov
2011-04-14 9:16 ` Alexey Dobriyan
2011-04-14 1:53 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516124828.GA5943@albatros \
--to=segoon@openwall.com \
--cc=dan.j.rosenberg@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=eugene@redhat.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kees.cook@canonical.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=nelhage@ksplice.com \
--cc=netdev@vger.kernel.org \
--cc=peak@argo.troja.mff.cuni.cz \
--cc=pekkas@netcore.fi \
--cc=solar@openwall.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).