From: Felipe Balbi <balbi@ti.com>
To: Tatyana Brokhman <tlinder@codeaurora.org>
Cc: greg@kroah.com, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, balbi@ti.com,
ablay@codeaurora.org, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v14 7/9] usb:gadget: Add SuperSpeed support to the Gadget Framework
Date: Fri, 3 Jun 2011 11:03:35 +0300 [thread overview]
Message-ID: <20110603080333.GS2409@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1306847914-19876-8-git-send-email-tlinder@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
Hi,
On Tue, May 31, 2011 at 04:18:27PM +0300, Tatyana Brokhman wrote:
> @@ -377,9 +425,10 @@ static int config_desc(struct usb_composite_dev *cdev, unsigned w_value)
> u8 type = w_value >> 8;
> enum usb_device_speed speed = USB_SPEED_UNKNOWN;
>
> - if (gadget_is_dualspeed(gadget)) {
> - int hs = 0;
> -
> + if (gadget->speed == USB_SPEED_SUPER)
if (gadget_is_superspeed(gadget)) ??
> @@ -413,16 +469,22 @@ static int count_configs(struct usb_composite_dev *cdev, unsigned type)
> struct usb_configuration *c;
> unsigned count = 0;
> int hs = 0;
> + int ss = 0;
>
> if (gadget_is_dualspeed(gadget)) {
> if (gadget->speed == USB_SPEED_HIGH)
> hs = 1;
> + if (gadget->speed == USB_SPEED_SUPER)
> + ss = 1;
is this really correct under gadget_is_dualspeed() ?? puzzled.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-06-03 8:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1306847914-19876-1-git-send-email-tlinder@codeaurora.org>
2011-05-31 13:18 ` [PATCH/RESEND v14 1/9] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Tatyana Brokhman
2011-05-31 13:18 ` [PATCH/RESEND v14 2/9] usb: Configure endpoint according to gadget speed Tatyana Brokhman
2011-05-31 13:18 ` [PATCH/RESEND v14 3/9] usb: Modify existing gadget drivers to use config_ep_by_speed() instead of ep_choose Tatyana Brokhman
2011-05-31 13:18 ` [PATCH v14 4/9] usb: Add max_speed to usb_composite_driver structure Tatyana Brokhman
2011-06-06 11:17 ` Felipe Balbi
2011-06-06 11:33 ` Tanya Brokhman
2011-06-06 11:37 ` Felipe Balbi
2011-06-06 15:25 ` Alan Stern
2011-06-06 15:36 ` Felipe Balbi
2011-05-31 13:18 ` [PATCH/RESEND v14 5/9] usb: coding style fix Tatyana Brokhman
2011-05-31 13:18 ` [PATCH v14 6/9] usb: Add streams support to the gadget framework Tatyana Brokhman
2011-05-31 13:18 ` [PATCH v14 7/9] usb:gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-06-03 8:03 ` Felipe Balbi [this message]
2011-06-03 18:00 ` Tanya Brokhman
2011-06-06 11:14 ` Felipe Balbi
2011-05-31 13:18 ` [PATCH/RESEND v14 8/9] usb:dummy_hcd: use the shared_hcd infrastructure Tatyana Brokhman
2011-05-31 13:18 ` [PATCH v14 9/9] usb: Adding SuperSpeed support to dummy_hcd Tatyana Brokhman
2011-05-31 14:18 ` Alan Stern
2011-05-31 18:39 ` Brokhman Tatyana
2011-05-31 19:07 ` Alan Stern
2011-05-31 19:29 ` Brokhman Tatyana
2011-05-31 18:40 ` Brokhman Tatyana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603080333.GS2409@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=ablay@codeaurora.org \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).