From: Don Zickus <dzickus@redhat.com>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Marcin Slusarz <marcin.slusarz@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/4] watchdog: fix rounding issues in get_sample_period()
Date: Thu, 9 Jun 2011 07:47:45 -0400 [thread overview]
Message-ID: <20110609114745.GQ8162@redhat.com> (raw)
In-Reply-To: <20110519162631.GJ11023@google.com>
On Thu, May 19, 2011 at 09:26:31AM -0700, Mandeep Singh Baines wrote:
> Don Zickus (dzickus@redhat.com) wrote:
> > On Mon, May 16, 2011 at 04:34:58PM -0700, Mandeep Singh Baines wrote:
> > > In get_sample_period(), softlockup_thresh is integer divided by 5 before
> > > the multiplication by NSEC_PER_SEC. This results in softlockup_thresh
> > > being rounded down to the nearest integer multiple of 5.
> > >
> > > For example, a softlockup_thresh of 4 rounds down to 0.
> >
> > Mandeep,
> >
> > Thanks for the patches. Unfortunately, I am taking some time off so I'll
> > shephard these patches when I get back. For the most part they look fine,
> > aside from Ingo's comments.
> >
>
> No problem. Enjoy your time off:)
>
> Ingo, since Don is out, would you mind acking the patches (assuming you're
> happy). It simplifies pushing these patches into our local ChromiumOS tree
> if I have an upstream ack.
Hi Mandeep,
It looks like Ingo took most of your patches. Is there any outstanding
ones that didn't make it that you see?
Cheers,
Don
next prev parent reply other threads:[~2011-06-09 11:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 23:34 [PATCH 1/4] watchdog: fix rounding issues in get_sample_period() Mandeep Singh Baines
2011-05-16 23:34 ` [PATCH 2/4] watchdog: only disable/enable watchdog if neccessary Mandeep Singh Baines
2011-05-16 23:35 ` [PATCH 3/4] watchdog: disable watchdog when thresh is zero Mandeep Singh Baines
2011-05-17 7:10 ` Ingo Molnar
2011-05-18 3:36 ` [PATCH 3/4 v2] " Mandeep Singh Baines
2011-05-18 8:35 ` Ingo Molnar
2011-05-19 16:20 ` [PATCH 3/4 v3] " Mandeep Singh Baines
2011-05-23 11:13 ` [tip:perf/urgent] watchdog: Disable " tip-bot for Mandeep Singh Baines
2011-05-16 23:35 ` [PATCH 4/4] watchdog: configure nmi watchdog period based on watchdog_thresh Mandeep Singh Baines
2011-05-17 7:16 ` Ingo Molnar
2011-05-17 14:03 ` Don Zickus
2011-05-17 18:47 ` Ingo Molnar
2011-05-18 3:44 ` [PATCH 4/4 v2] " Mandeep Singh Baines
2011-05-18 8:39 ` Ingo Molnar
2011-05-18 13:51 ` Don Zickus
2011-05-23 11:13 ` [tip:perf/urgent] watchdog: Change the default timeout and " tip-bot for Mandeep Singh Baines
2011-05-24 3:58 ` [tip:perf/urgent] watchdog: Fix non-standard prototype of get_softlockup_thresh() tip-bot for Ingo Molnar
2011-05-18 13:53 ` [PATCH 1/4] watchdog: fix rounding issues in get_sample_period() Don Zickus
2011-05-19 16:26 ` Mandeep Singh Baines
2011-05-20 11:51 ` Ingo Molnar
2011-05-23 5:14 ` Mandeep Singh Baines
2011-06-09 11:47 ` Don Zickus [this message]
2011-06-09 14:51 ` Mandeep Singh Baines
2011-05-23 5:10 Mandeep Singh Baines
2011-05-23 5:10 ` [PATCH 2/4] watchdog: only disable/enable watchdog if neccessary Mandeep Singh Baines
2011-05-23 11:12 ` [tip:perf/urgent] watchdog: Only " tip-bot for Mandeep Singh Baines
2011-05-23 5:10 ` [PATCH 3/4] watchdog: disable watchdog when thresh is zero Mandeep Singh Baines
2011-05-23 5:10 ` [PATCH 4/4] watchdog: configure nmi watchdog period based on watchdog_thresh Mandeep Singh Baines
2011-05-23 11:12 ` [tip:perf/urgent] watchdog: Fix rounding bug in get_sample_period() tip-bot for Mandeep Singh Baines
2011-05-24 3:41 linux-next: build warning in Lunus' tree Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609114745.GQ8162@redhat.com \
--to=dzickus@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mingo@elte.hu \
--cc=msb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).