LKML Archive on
 help / color / Atom feed
From: Steven Rostedt <>
Cc: Ingo Molnar <>,
	Andrew Morton <>,
	Hillf Danton <>,
	Yong Zhang <>
Subject: [PATCH 1/2] sched: Fix need_resched() when checking peempt
Date: Tue, 14 Jun 2011 18:36:24 -0400
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #0: 0001-sched-Fix-need_resched-when-checking-peempt.patch --]
[-- Type: text/plain, Size: 1065 bytes --]

From: Hillf Danton <>

The RT preempt check tests the wrong task if NEED_RESCHED is set. It currently
checks the local CPU task. It is suppose to check the task that is running on
the run queue we are about to wake another task on.

Signed-off-by: Hillf Danton <>
Reviewed-by: Yong Zhang <>
Signed-off-by: Steven Rostedt <>
 kernel/sched_rt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 88725c9..9b8d5dc 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -1096,7 +1096,7 @@ static void check_preempt_curr_rt(struct rq *rq, struct task_struct *p, int flag
 	 * to move current somewhere else, making room for our non-migratable
 	 * task.
-	if (p->prio == rq->curr->prio && !need_resched())
+	if (p->prio == rq->curr->prio && !test_tsk_need_resched(rq->curr))
 		check_preempt_equal_prio(rq, p);

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 22:36 [PATCH 0/2] [GIT PULL][v3.0] sched: various fixes Steven Rostedt
2011-06-14 22:36 ` Steven Rostedt [this message]
2011-06-15  9:50   ` [tip:sched/urgent] sched: Fix need_resched() when checking peempt tip-bot for Hillf Danton
2011-06-14 22:36 ` [PATCH 2/2] sched: Check if lowest_mask is initialized in find_lowest_rq Steven Rostedt
2011-06-15  0:40   ` Paul E. McKenney
2011-06-15  8:17   ` Peter Zijlstra
2011-06-15  9:50   ` [tip:sched/urgent] sched: Check if lowest_mask is initialized in find_lowest_rq() tip-bot for Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git
	git clone --mirror lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone