From: Andrew Morton <akpm@linux-foundation.org>
To: Phillip Susi <psusi@cfl.rr.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix loopback devices to emit uevent on auto release
Date: Wed, 6 Jul 2011 15:45:58 -0700 [thread overview]
Message-ID: <20110706154558.1a87054e.akpm@linux-foundation.org> (raw)
In-Reply-To: <4E0912A9.7030403@cfl.rr.com>
On Mon, 27 Jun 2011 19:30:49 -0400
Phillip Susi <psusi@cfl.rr.com> wrote:
> commit 4d5498b2b400ee4781b25fa9fa219eadf11c1ef5
> Author: Phillip Susi <psusi@cfl.rr.com>
> Date: Mon Jun 27 18:55:00 2011 -0400
>
> Fixed loopback device to emit uevent on auto release
>
> The loopback driver failed to emit the change uevent
> when auto releasing the device. Fixed lo_release()
> to pass the bdev to loop_clr_fd() so it can emit
> the event.
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index dbf31ec..ba915ce 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1522,7 +1522,7 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
> * In autoclear mode, stop the loop thread
> * and remove configuration after last close.
> */
> - err = loop_clr_fd(lo, NULL);
> + err = loop_clr_fd(lo, lo->lo_device);
> if (!err)
> goto out_unlocked;
> } else {
The patch is missing your Signed-off-by:. Please review
Documentation/SubmittingPatches section 12 to see what this means.
Then, if agreeable, please send us that Signed-off-by:, thanks.
next prev parent reply other threads:[~2011-07-06 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 23:30 [PATCH] Fix loopback devices to emit uevent on auto release Phillip Susi
2011-07-06 22:45 ` Andrew Morton [this message]
2011-07-07 18:56 ` Phillip Susi
2011-07-07 19:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706154558.1a87054e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=psusi@cfl.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).