From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751621Ab1GFVnv (ORCPT ); Wed, 6 Jul 2011 17:43:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48773 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363Ab1GFVnu (ORCPT ); Wed, 6 Jul 2011 17:43:50 -0400 Date: Wed, 6 Jul 2011 14:43:40 -0700 From: Greg KH To: David Brown Cc: Prashant Shah , Stepan Moskovchenko , Abhijeet Dharmapurikar , Daniel Walker , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: msm: fixed style issues found by checkpatch.pl Message-ID: <20110706214338.GA2109@suse.de> References: <20110706074934.GA935@mail.fossee.in> <20110706155745.GB16625@suse.de> <20110706192656.GA30532@suse.de> <8yay60bytt5.fsf@huya.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8yay60bytt5.fsf@huya.qualcomm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 06, 2011 at 02:37:26PM -0700, David Brown wrote: > On Wed, Jul 06 2011, Greg KH wrote: > > > On Wed, Jul 06, 2011 at 09:45:08PM +0530, Prashant Shah wrote: > >> Hi, > >> > >> > So that would be one patch for fixing extra braces, one for extra > >> > spaces, and so on. That makes it easier to review. > >> > >> Ok I will redo them. > >> > >> On Wed, Jul 6, 2011 at 9:27 PM, Greg KH wrote: > >> > On Wed, Jul 06, 2011 at 01:19:34PM +0530, Prashant P. Shah wrote: > >> > Also, did you successfully build this code before and after your > >> > changes? > >> > >> I tried but the code does not build because of #include > >> in the msm_fb.c file. I dont know how to fix that. > > > > I say let's just delete this whole directory as if it doesn't build, no > > one is using it, and no one has tried to clean it up since it was > > originally added. > > > > Stepan or David or Abhijeet or Daniel, any objection to just deleting > > drivers/staging/msm/ at this point in time for the 3.1 kernel release? > > You haven't sent any patches to me to clean this code up since the > > original patch, way over a year ago. > > I have none. The non-staging driver has been getting updates, and I > asked the author if it was OK to remove the staging one. I believe the > real driver supports everything the staging one did. > > Should I generate a (large) patch, or is it easier for you to just > remove the tree? I'll just remove it, it's easier that way. Can I add your "Acked-by:" to the patch? thanks, greg k-h