From: Dan Carpenter <error27@gmail.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 5/5] Staging: comedi: fix warning issue in unioxx5.c
Date: Thu, 7 Jul 2011 12:01:56 +0300 [thread overview]
Message-ID: <20110707090156.GK18655@shale.localdomain> (raw)
In-Reply-To: <1310022039-25599-1-git-send-email-ravishankarkm32@gmail.com>
On Thu, Jul 07, 2011 at 12:30:39PM +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@greenturtles.in>
>
> This is a patch to the unioxx5.c file that fixes up a warning:line over 80 charcter found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/unioxx5.c | 25 ++++++++++++++++++-------
> 1 files changed, 18 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/unioxx5.c b/drivers/staging/comedi/drivers/unioxx5.c
> index 598884e..9b311c7 100644
> --- a/drivers/staging/comedi/drivers/unioxx5.c
> +++ b/drivers/staging/comedi/drivers/unioxx5.c
> @@ -75,8 +75,13 @@ Devices: [Fastwel] UNIOxx-5 (unioxx5),
> /* 'private' structure for each subdevice */
> struct unioxx5_subd_priv {
> int usp_iobase;
> - unsigned char usp_module_type[12]; /* 12 modules. each can be 70L or 73L */
> - unsigned char usp_extra_data[12][4]; /* for saving previous written value for analog modules */
> + unsigned char usp_module_type[12]; /* 12 modules. each can be 70L
> + * or 73L
> + */
^^^
The asterisks should line up. Maybe move the comment to the
line before.
/* 12 modules. each can be 70L or 73L */
unsigned char usp_module_type[12];
regards,
dan carpenter
prev parent reply other threads:[~2011-07-07 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 1/2]Staging: comedi: fix line over 80 character warning issues in unioxx5.c>
2011-07-07 7:00 ` [PATCH 5/5] Staging: comedi: fix warning issue in unioxx5.c Ravishankar
2011-07-07 8:28 ` Denis Kirjanov
2011-07-07 9:26 ` Dan Carpenter
2011-07-07 9:01 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707090156.GK18655@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).