From: Mandeep Singh Baines <msb@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mandeep Singh Baines <msb@chromium.org>,
Huang Ying <ying.huang@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Hugh Dickins <hughd@chromium.org>, Olaf Hering <olaf@aepfle.de>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic, vt: do not force oops output when panic_timeout < 0
Date: Fri, 15 Jul 2011 15:57:07 -0700 [thread overview]
Message-ID: <20110715225707.GE17254@google.com> (raw)
In-Reply-To: <20110706163312.17c104dc.akpm@linux-foundation.org>
Andrew Morton (akpm@linux-foundation.org) wrote:
> On Wed, 22 Jun 2011 15:30:39 -0700
> Mandeep Singh Baines <msb@chromium.org> wrote:
>
> > Mandeep Singh Baines (msb@chromium.org) wrote:
> > > Avoid risk (of screen_unblank) and wasted cycles unblanking if
> > > you intend to reboot immediately.
> > >
> >
> > The original patch doesn't work. It worked fine when I tested with
> > a serial port. When I disabled the serial out, my machine started to
> > get wedged on a panic. I guess screen_unblank was in bust_spinlocks
> > for a reason. It probably bust some spin_locks somewhere.
> >
> > Below is a replacement for this patch which calls screen_unblank but
> > does not force output when the panic timeout is negative (no wait).
> >
> > -- >8 -- (snip)
> >
> > Don't force output if you intend to reboot immediately.
> >
> > This patch depends on:
> >
> > http://lkml.kernel.org/r/1308612129-12488-1-git-send-email-msb@chromium.org
>
> Please fold this into that and resend the patch series. Please add
> the needed update to Documentation/kernel-parameters.txt.
Done:
http://lkml.kernel.org/r/1310770401-10739-1-git-send-email-msb@chromium.org
next prev parent reply other threads:[~2011-07-15 22:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 23:22 [PATCH 1/2] panic: panic=-1 for immediate reboot Mandeep Singh Baines
2011-06-20 23:22 ` [PATCH 2/2] panic: do not unblank_screen when panic_timeout < 0 Mandeep Singh Baines
2011-06-22 22:30 ` [PATCH] panic, vt: do not force oops output " Mandeep Singh Baines
2011-07-06 23:33 ` Andrew Morton
2011-07-15 22:57 ` Mandeep Singh Baines [this message]
2011-07-07 7:53 ` Alan Cox
2011-07-15 21:39 ` Mandeep Singh Baines
2011-07-15 23:17 ` Alan Cox
2011-06-22 9:39 ` [PATCH 1/2] panic: panic=-1 for immediate reboot Olaf Hering
2011-06-22 22:17 ` Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715225707.GE17254@google.com \
--to=msb@chromium.org \
--cc=airlied@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@chromium.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).